Commit Graph

5430 Commits

Author SHA1 Message Date
Jorge Manrubia 17ec7a367a We need the grid layout when filtering events 2025-09-29 18:50:22 +02:00
Jorge Manrubia 3548ab963c Merge pull request #1182 from basecamp/fix-filter-collection
Fix: proper filtering by collection in the collection perma
2025-09-29 18:43:21 +02:00
Jorge Manrubia e97c085a57 Fix: proper filtering by collection in the collection perma
https://fizzy.37signals.com/5986089/cards/2020
2025-09-29 18:42:29 +02:00
Jorge Manrubia b314eb5ef6 Merge pull request #1175 from basecamp/collapsing-columns
Columns
2025-09-29 17:49:28 +02:00
Jorge Manrubia 48d4a65c7d Fix test 2025-09-29 17:48:29 +02:00
Jorge Manrubia fa4106c13e Fix test 2025-09-29 17:45:36 +02:00
Andy Smith 27ccde8419 Position expander menu 2025-09-29 10:34:15 -05:00
Andy Smith 75379d1305 Use parent layout when using with_manual_pagination 2025-09-29 10:20:17 -05:00
Andy Smith 4aec61a4e8 Reinstate gap to cards list 2025-09-29 10:16:07 -05:00
Jorge Manrubia 2d029d075e Fix: include collection filter in the collection perma 2025-09-29 16:59:43 +02:00
Jorge Manrubia c95bdf0dc7 Add some basic caching for the new columns approach 2025-09-29 15:09:38 +02:00
Jorge Manrubia fffdb623c1 Merge main into collapsing-columns branch
Resolved conflict in card-columns.css by keeping both changes:
- Added padding-inline for non-collapsed cards from collapsing-columns
- Kept bubble positioning, hover effects, and card steps from main
2025-09-29 14:03:59 +02:00
Jorge Manrubia 0b7926f36a Format 2025-09-29 13:14:33 +02:00
Jorge Manrubia 1bb8de8564 Fix tests 2025-09-29 13:13:40 +02:00
Jorge Manrubia 859a016a2e No need to use extra method here 2025-09-29 13:03:54 +02:00
Jorge Manrubia 1a46199199 Move actions to stream templates 2025-09-28 22:48:26 +02:00
Jorge Manrubia d57824b951 Prevent recursive loop now that we have nested frames 2025-09-28 22:27:40 +02:00
Jorge Manrubia 60671b280e Use official Lexxy gem 2025-09-28 22:11:52 +02:00
Jorge Manrubia 97dd5513b7 Use official Lexxy gem 2025-09-28 22:11:21 +02:00
Jorge Manrubia 876a76933e Updating lexxy 2025-09-28 22:05:45 +02:00
Jorge Manrubia 402fe6ca39 No default columns for new collections
https://3.basecamp.com/2914079/buckets/37331921/todos/9104429380#__recording_9118363137
2025-09-28 22:04:06 +02:00
Jorge Manrubia e1f052935a Add test for triaging cards 2025-09-28 22:02:34 +02:00
Jorge Manrubia f7f4aa6eaf Add more controller tests 2025-09-28 22:02:01 +02:00
Jorge Manrubia 23895e53aa Add tests for new controllers 2025-09-28 21:11:07 +02:00
Jorge Manrubia 5a4cef98c9 Fix tests 2025-09-28 20:50:11 +02:00
Jorge Manrubia d16e0c942c Fix test and adjust prompts to reflect the column 2025-09-28 20:49:25 +02:00
Jorge Manrubia 24f1394ca3 Remove workflows code, remove more unused code 2025-09-28 20:39:47 +02:00
Jorge Manrubia 0b0fb57e58 Fix tests 2025-09-28 20:31:41 +02:00
Jorge Manrubia e14262dc01 Fix tests, remove workflow controllers 2025-09-28 18:50:26 +02:00
Jorge Manrubia b0e62a3a4f Add default columns when creating a collection 2025-09-28 18:43:23 +02:00
Jorge Manrubia 4103e0c346 Adapt public collections/cards to the new columns model 2025-09-28 18:33:06 +02:00
Jorge Manrubia 6e1e0eddd8 Add pagination to the rest of the sections 2025-09-28 14:28:13 +02:00
Jorge Manrubia 72fb15dd0f Pagination working for columns
Bring pagination system from KIA that is compatible with page refreshes
2025-09-28 14:21:16 +02:00
Jorge Manrubia b5dd91f4a4 Tidy up 2025-09-28 13:32:23 +02:00
Jorge Manrubia 7209c4ced7 Remove unnecessary defensive check 2025-09-28 13:28:33 +02:00
Jorge Manrubia f0da1b483d Tidy up 2025-09-28 13:28:08 +02:00
Jorge Manrubia e670add34b Format 2025-09-28 13:26:28 +02:00
Jorge Manrubia be8fcae4c6 Use aria-controls and aria-expanded for columns 2025-09-28 13:17:10 +02:00
Jorge Manrubia 531315f253 Restore the class-based approach
aria-expanded should go on the toggle
2025-09-28 13:02:58 +02:00
Jorge Manrubia c4a23102e9 Remove unused code 2025-09-28 11:33:09 +02:00
Jorge Manrubia b9b013d7e6 Format 2025-09-28 11:32:06 +02:00
Jorge Manrubia 5a90de8bcb Use aria-expanded instead of class 2025-09-28 11:31:03 +02:00
Jorge Manrubia 1b39e0b45e Format 2025-09-28 11:18:54 +02:00
Jorge Manrubia ce065623f7 Delete columns 2025-09-28 11:09:33 +02:00
Jorge Manrubia 7a97d978f5 Rename columns 2025-09-28 11:06:40 +02:00
Jorge Manrubia 47eaecae31 Add columns 2025-09-27 08:40:45 +02:00
Jorge Manrubia f3959ced0d Extract expander to partial 2025-09-27 07:57:36 +02:00
Jorge Manrubia 0969a30961 Fix script condition 2025-09-27 07:52:37 +02:00
Jorge Manrubia 6a231b48f2 Fix: script should consider old considering cards as belonging to the stream now 2025-09-27 07:42:04 +02:00
Andy Smith 6efd4c8b0e Fix bubble position 2025-09-26 17:12:09 -05:00