Commit Graph

5430 Commits

Author SHA1 Message Date
Jason Zimdars 7f714bc7ee Merge branch 'main' into jz-6-5-25
* main:
  Fix that flash notices invisibly overlapped navbar
  Use card header in events
  Cap height and scroll list
  Fix: update option when changing index
  Use `vfs` tag on production accessories
2025-06-05 11:29:14 -05:00
Jason Zimdars c4aa46a35e Fix that flash notices invisibly overlapped navbar 2025-06-05 11:28:58 -05:00
Jason Zimdars a22a78e60a Use card header in events 2025-06-05 11:28:58 -05:00
Jason Zimdars 33e9a6e645 Cap height and scroll list 2025-06-05 11:28:58 -05:00
Jason Zimdars 20d0515031 Fix that flash notices invisibly overlapped navbar 2025-06-05 11:21:52 -05:00
Jason Zimdars ad27d856bb Use card header in events 2025-06-05 11:16:53 -05:00
Jorge Manrubia 35b8b6f470 Fix: update option when changing index 2025-06-05 17:03:21 +02:00
Jorge Manrubia 5107eebbdb Fix: calculate days here 2025-06-05 16:38:59 +02:00
Jorge Manrubia 2e60fcdf98 Dynamic bubble timers 2025-06-05 16:11:48 +02:00
Jorge Manrubia 0cb5b9ecd6 Reactions reset entropy 2025-06-05 16:07:19 +02:00
Jorge Manrubia ae6813ba0a Merge branch 'main' into stalled-cards
* main:
  Use `vfs` tag on production accessories
  Invalidate card cache when editing collection entropy config
  Use VFS-based Beamer
  Introduce a staging environment
2025-06-05 16:01:42 +02:00
Kevin McConnell d78a61b8fc Use vfs tag on production accessories 2025-06-05 14:55:02 +01:00
Jorge Manrubia 310b8ad4e9 Make sure we only detect activity spikes when we should
The detection logic wasn't really working before
2025-06-05 15:49:27 +02:00
Jason Zimdars 7976895f96 Cap height and scroll list 2025-06-05 08:45:11 -05:00
Mike Dalessio 711bf829dd Merge pull request #584 from basecamp/flavorjones/staging-env
Introduce a staging environment
2025-06-05 09:37:31 -04:00
Mike Dalessio b8fe29ab9b Merge pull request #591 from basecamp/flavorjones/card-cache-entropy-config
Invalidate card cache when editing collection entropy config
2025-06-05 09:32:19 -04:00
Jorge Manrubia e70827b2ca Parametrize method instead of hanving methods hanging around
If we need more complex calculations for those we can extract again
2025-06-05 15:23:15 +02:00
Jorge Manrubia b9ec71ff84 Format 2025-06-05 15:21:18 +02:00
Jorge Manrubia 0ac937b208 Rename 2025-06-05 15:20:36 +02:00
Jorge Manrubia 6688ca3e82 Consider reopened cards as an activity spike 2025-06-05 15:16:13 +02:00
Mike Dalessio b0a1983553 Invalidate card cache when editing collection entropy config 2025-06-05 09:13:27 -04:00
Jorge Manrubia 67b45cc5a6 Test scope 2025-06-05 15:11:06 +02:00
Jorge Manrubia d22cbe6f7f Add tests for stalled detection 2025-06-05 15:09:55 +02:00
Jorge Manrubia 35731980fb extract method 2025-06-05 14:06:21 +02:00
Jorge Manrubia fee3ae45c8 Fix duplicated reopened card 2025-06-05 13:55:53 +02:00
Jorge Manrubia eb95af4add Add test for reopening cards 2025-06-05 13:29:34 +02:00
Jorge Manrubia 7c1bd23460 Exclude body checking in this test
Requests like summarize can result in completely different responses
2025-06-05 13:02:40 +02:00
Kevin McConnell e998783155 Use VFS-based Beamer 2025-06-05 11:59:30 +01:00
Jorge Manrubia 3df7d3e5a8 Match requests by body
So that modifying the prompt make the tests fail

If not, the tests defeat their purpose!
2025-06-05 12:45:45 +02:00
Jorge Manrubia 9b4cd7eff2 Remove vcr_record! 2025-06-05 12:36:37 +02:00
Jorge Manrubia 7eb1930eb3 Test for stalled cards 2025-06-05 12:36:12 +02:00
Jorge Manrubia 7c657a2bd9 Support stalled filtering 2025-06-05 12:07:55 +02:00
Jorge Manrubia 6fec61edf4 Tweak params 2025-06-05 11:19:03 +02:00
Jorge Manrubia 19e27370fa Stimulus can't handle "null" JSON string 2025-06-05 11:10:09 +02:00
Jorge Manrubia fbe12014ab Format 2025-06-05 11:08:37 +02:00
Jorge Manrubia 6e8087ee2e Toggle entropy/stalled container in the bubbles controller 2025-06-05 11:08:20 +02:00
Jorge Manrubia bfa4dc626b Restructure to make it easy to extend rendering logic 2025-06-05 10:39:51 +02:00
Jorge Manrubia 76119b17bd Entropy, not bubble! 2025-06-05 10:33:02 +02:00
Jorge Manrubia 22ed605884 Namespace bubble-related targets 2025-06-05 10:32:14 +02:00
Jorge Manrubia 2cbd451944 Group entropy options in an object value
We'll add stalling considerations next, this helps keeping things organized.
2025-06-05 10:28:33 +02:00
Jorge Manrubia c52e49ef91 Merge branch 'main' into stalled-cards
* main: (33 commits)
  Rename helpers since they are not related to collections only anymore
  Simplify
  Reorder method
  Update brakeman
  Fix tests after removing the index action
  Format
  Extract partials
  Format
  Tidy up code
  We're not using this right now
  Wire up knob UI design
  Contain images
  Extract the header so we can explain in context
  Display users and invite on `account/settings`
  Link to workflows
  Link to account settings
  Update to use two-column layout, add title and nav
  Add comment
  Properly parameterize the field name
  Remove leftover console.log
  ...
2025-06-05 10:09:12 +02:00
Jorge Manrubia 1fe16e1416 Merge pull request #585 from basecamp/entropy-settings-ui
Entropy improvements
2025-06-05 09:19:56 +02:00
Jorge Manrubia a5f7f34750 Rename helpers since they are not related to collections only anymore 2025-06-05 09:19:08 +02:00
Jorge Manrubia a014af6ef0 Simplify 2025-06-05 09:16:38 +02:00
Jorge Manrubia 8a63bac3c0 Reorder method 2025-06-05 09:14:51 +02:00
Jorge Manrubia e8322afb59 Update brakeman 2025-06-05 09:13:19 +02:00
Jorge Manrubia 540254def4 Fix tests after removing the index action
The show action makes more sense in the controller. Also, the filter
scoped was failing due to Rails raising on missing actions (because we
have deleted the index action). Inlining the concern fixes it and clarifies
where this action is implemented.
2025-06-05 09:12:07 +02:00
Jorge Manrubia de87f4ed6c Format 2025-06-05 08:58:15 +02:00
Jorge Manrubia acd1038359 Extract partials 2025-06-05 08:57:38 +02:00
Jorge Manrubia cb1ee9eabd Format 2025-06-05 08:54:42 +02:00