Commit Graph

5430 Commits

Author SHA1 Message Date
Jorge Manrubia b510ca0318 Don't choke for nil values 2025-04-23 10:56:00 +02:00
Jorge Manrubia 68e2e96076 Fix indentation 2025-04-23 10:44:42 +02:00
Jorge Manrubia af8701567a Extract method 2025-04-23 10:35:18 +02:00
Jorge Manrubia c3cd873588 Rename collect => create 2025-04-23 10:30:30 +02:00
Jason Zimdars 14d0b995a8 Fix summary 2025-04-22 23:09:29 -05:00
Jason Zimdars 8fec68c34c Remove index columns 2025-04-22 23:07:06 -05:00
Jason Zimdars b29afcd518 Same treatment for the events index 2025-04-22 22:57:48 -05:00
Jason Zimdars 0a9d16bf2d New menu filters and navigates 2025-04-22 22:29:33 -05:00
Jason Zimdars 72c1fa3b05 Merge branch 'main' into fixes-tues-22
* main:
  Indention
  @collection is always available when card scoped
  Style
  Duh, no before destroy commit, but this is still not right!
  No long transactions!
  But feels more essentially part of the User, so list first
  Not related to the other two
  Style
  Try a slimmer version
  We werent using any of the other avatar methods
  Dont do a lot of work inside a single transaction
  Really liking the new it-style yields in many places
  Bump nokogiri from 1.18.7 to 1.18.8
2025-04-22 15:06:36 -05:00
Jason Zimdars 537903ba0b Don't test for _Added by_ events
Note: The join method in `event_summary.rb` inserts a space that we need to account for
2025-04-22 15:06:05 -05:00
David Heinemeier Hansson cf3cbccf23 Indention 2025-04-22 21:56:23 +02:00
David Heinemeier Hansson 93516f2e48 @collection is always available when card scoped 2025-04-22 21:51:38 +02:00
David Heinemeier Hansson dff55d6cb6 Style 2025-04-22 21:48:32 +02:00
Jason Zimdars 647971f205 Remove check for _Added by..._ line 2025-04-22 14:46:46 -05:00
Jason Zimdars 1412932666 The placeholder attribute is on the house-md element 2025-04-22 14:45:39 -05:00
David Heinemeier Hansson 5048e9c970 Duh, no before destroy commit, but this is still not right! 2025-04-22 21:40:30 +02:00
David Heinemeier Hansson 7124835e60 No long transactions!
If you intend to deactivate someone, and the process fails mid process,
so you only delete some sessions, or some accesses, you are actually
fine. The system is never left in an incomplete state. And that's really
the only time we should be using transactions with sqlite3 -- to prevent
actual data integrity issues.

The rest of the time, we should optimize for each transaction to be as
quick as possible. The sqlite3 writer lock is the one bottleneck that we
cant afford to overload.
2025-04-22 21:29:03 +02:00
Jason Zimdars 5de85fa6bf Don't display published event in threads 2025-04-22 14:25:35 -05:00
David Heinemeier Hansson 90f05b7310 But feels more essentially part of the User, so list first 2025-04-22 21:25:30 +02:00
David Heinemeier Hansson 72d1d0baee Not related to the other two 2025-04-22 21:24:51 +02:00
Jason Zimdars 8c43615d71 Missing controller 2025-04-22 14:23:44 -05:00
David Heinemeier Hansson ad1e97767d Style 2025-04-22 21:22:42 +02:00
Jason Zimdars b46461d7ed Errant bubbles => cards replacement 2025-04-22 14:21:14 -05:00
David Heinemeier Hansson c4fbed3156 Try a slimmer version
And I actually stopped liking that setup automatically starts the
server.
2025-04-22 21:20:55 +02:00
David Heinemeier Hansson 6cd8d54bf7 We werent using any of the other avatar methods 2025-04-22 21:20:18 +02:00
Jason Zimdars 024b54a8a7 Get this effect with mix-blend-mode 2025-04-22 14:15:48 -05:00
Jason Zimdars d9481eb021 Whitespace 2025-04-22 14:08:48 -05:00
David Heinemeier Hansson 134333ae44 Dont do a lot of work inside a single transaction
Especially with sqlite3!
2025-04-22 21:01:11 +02:00
David Heinemeier Hansson 78d186bebd Really liking the new it-style yields in many places 2025-04-22 20:59:49 +02:00
Jason Zimdars d7de62a047 Pinned cards might be on the same screen which causes a name collision 2025-04-22 13:57:24 -05:00
Jason Zimdars 9b57480b40 ticket is a vestige of a previous design 2025-04-22 13:55:46 -05:00
Jason Zimdars 83a56e4ffe No longer used 2025-04-22 13:54:25 -05:00
Jason Zimdars c4864752f4 Card descriptions need styles shared with comments 2025-04-22 13:53:08 -05:00
Jason Zimdars 3792966a23 Blind attempt fix select options in browsers with non-native pickers
See: https://37s.fizzy.37signals.com/collections/693169850/cards/999008955
2025-04-22 13:40:55 -05:00
Jason Zimdars cde8634bfe Adjust the stages column sizing 2025-04-22 12:59:36 -05:00
Jason Zimdars 51ef76ff4b This was on the wrong element
Caused some pinned cards to be an irregular height
2025-04-22 12:04:53 -05:00
Jason Zimdars 4f87472e5a Restore clicks on pinned cards 2025-04-22 12:00:49 -05:00
Jorge Manrubia cdadc0373a Don't trigger unless the mentionable content changes
This is also needed to prevent incorrect triggering on cascade touches!
2025-04-22 18:10:27 +02:00
Mike Dalessio bcd6468dc7 Merge pull request #424 from basecamp/dependabot/bundler/nokogiri-1.18.8
Bump nokogiri from 1.18.7 to 1.18.8
2025-04-22 11:48:50 -04:00
Jorge Manrubia a567e662e2 Fix: wrong delegation 2025-04-22 17:23:47 +02:00
Jorge Manrubia 9b4fec936e Move mentions to comments
- It does not make sense to scan "event summaries" for notifications.
- Placing them at the message level prevents us from using the generic approach to extract the mentionable content
2025-04-22 16:17:37 +02:00
Jorge Manrubia 81961a3523 Fix unclosed tag 2025-04-22 15:30:03 +02:00
Jorge Manrubia c75d4cb329 Fix broken permalinks 2025-04-22 15:26:56 +02:00
David Heinemeier Hansson dcf135c003 Fix rubocop 2025-04-22 14:45:22 +02:00
David Heinemeier Hansson 3d28203224 Use singular staging resource and beef up testing 2025-04-22 14:44:55 +02:00
Jorge Manrubia 3bf73a0b71 Rename to match actual action 2025-04-22 14:22:23 +02:00
Jorge Manrubia beac61699c Not needed 2025-04-22 14:21:26 +02:00
Jorge Manrubia d5f0359338 Extract mentionable content using reflection to remove duplicated logic and the need for additional concerns 2025-04-22 14:19:45 +02:00
Jorge Manrubia 9db675e589 Format 2025-04-22 14:15:40 +02:00
Jorge Manrubia 22df208f9a Render proper content for mentions, don't send mentions to yourself 2025-04-22 14:11:21 +02:00