 Andy Smith
|
6fb69294a3
|
Smaller badge size
|
2025-04-16 10:14:24 -05:00 |
|
|
David Heinemeier Hansson
|
7c5a58bf4d
|
Note that this need to be able to dynamically appear
|
2025-04-16 17:12:31 +02:00 |
|
|
David Heinemeier Hansson
|
5dc6e0394f
|
Style
|
2025-04-16 17:12:20 +02:00 |
|
|
David Heinemeier Hansson
|
96cf3af022
|
Merge pull request #405 from basecamp/refactor-notifications
Refactor notifications
|
2025-04-16 17:10:11 +02:00 |
|
|
David Heinemeier Hansson
|
00cbe8101c
|
Slim it down
|
2025-04-16 17:07:43 +02:00 |
|
|
Jason Zimdars
|
dd39d03398
|
Copy edit
|
2025-04-16 10:06:48 -05:00 |
|
|
Jason Zimdars
|
d22bea8ac5
|
Change alignment
|
2025-04-16 10:05:02 -05:00 |
|
|
David Heinemeier Hansson
|
cfa2f2d1f9
|
Trailing spaces
|
2025-04-16 17:02:48 +02:00 |
|
|
David Heinemeier Hansson
|
2ced8e643d
|
Clarify a bit
|
2025-04-16 17:01:32 +02:00 |
|
|
David Heinemeier Hansson
|
d8ec2c3364
|
More natural to fetch that which will be shown first
|
2025-04-16 16:58:03 +02:00 |
|
|
David Heinemeier Hansson
|
5ce289642f
|
Rely on caching of notifications
|
2025-04-16 16:57:54 +02:00 |
|
|
Jason Zimdars
|
78fb19789c
|
Clearer assignment icon
|
2025-04-16 09:55:41 -05:00 |
|
|
David Heinemeier Hansson
|
6135909b7e
|
Card readings just need to remove the notification
No need to broadcast everything again
|
2025-04-16 16:51:18 +02:00 |
|
|
Andy Smith
|
7f944b601f
|
Remove unused DaysUntilFormatter
|
2025-04-16 09:49:42 -05:00 |
|
|
David Heinemeier Hansson
|
2757cd8e62
|
Dont render inline
|
2025-04-16 16:49:16 +02:00 |
|
|
David Heinemeier Hansson
|
98401b9536
|
Explain this
|
2025-04-16 16:44:04 +02:00 |
|
|
Jason Zimdars
|
134e7f5d6e
|
No longer used
|
2025-04-16 09:41:48 -05:00 |
|
|
David Heinemeier Hansson
|
4bb9085737
|
Hide implementation detail of reading
|
2025-04-16 16:41:22 +02:00 |
|
|
David Heinemeier Hansson
|
91194d1b66
|
Fixed up controller test
|
2025-04-16 16:37:06 +02:00 |
|
|
David Heinemeier Hansson
|
ac3307ee23
|
Allow for the footer frames to be hidden on the notifications page
Otherwise you will have multiple notification dom elements with the same
id.
|
2025-04-16 16:23:05 +02:00 |
|
|
David Heinemeier Hansson
|
158b694d31
|
Simplify the containers
Need to use CSS to hide headings in empty containers
|
2025-04-16 16:22:36 +02:00 |
|
|
David Heinemeier Hansson
|
397fc1d2bd
|
Only broadcast creations
|
2025-04-16 16:21:54 +02:00 |
|
|
David Heinemeier Hansson
|
8ff71b2650
|
Dont turbo stream when coming from a read_all redirect
|
2025-04-16 16:21:31 +02:00 |
|
|
David Heinemeier Hansson
|
5932bf9316
|
This is rare enough that a redirect is fine
|
2025-04-16 16:21:16 +02:00 |
|
|
David Heinemeier Hansson
|
f9952e0fd6
|
Style
|
2025-04-16 15:57:02 +02:00 |
|
|
David Heinemeier Hansson
|
d00a0433e9
|
Inline anemic method
|
2025-04-16 15:34:28 +02:00 |
|
|
David Heinemeier Hansson
|
13c44ba650
|
Actually need it for the lazy load of course
|
2025-04-16 12:00:54 +02:00 |
|
|
David Heinemeier Hansson
|
980345d176
|
Drop the frame, we will do it with streams
|
2025-04-16 12:00:11 +02:00 |
|
|
David Heinemeier Hansson
|
3fc34257c4
|
No longer used
|
2025-04-16 11:59:58 +02:00 |
|
|
David Heinemeier Hansson
|
50e4587dd9
|
Fix trailing spaces
|
2025-04-16 11:56:21 +02:00 |
|
|
David Heinemeier Hansson
|
375afeac7b
|
Fix test
|
2025-04-16 11:55:35 +02:00 |
|
|
Andy Smith
|
f1dbe1bcaf
|
Better prop names
|
2025-04-15 13:26:41 -05:00 |
|
|
Andy Smith
|
adad6dd657
|
Remind 7 days before auto close
|
2025-04-15 13:24:40 -05:00 |
|
|
Andy Smith
|
eeadc1c494
|
Make it look like a stamp
|
2025-04-15 13:22:12 -05:00 |
|
|
Andy Smith
|
ad80aee38e
|
Stub out working auto close reminder
|
2025-04-15 13:15:29 -05:00 |
|
|
David Heinemeier Hansson
|
73f272f132
|
Use one controller for all notification readings
|
2025-04-15 19:14:50 +02:00 |
|
|
David Heinemeier Hansson
|
2ea898324f
|
We can just set the namespace directly in the class name
|
2025-04-15 16:36:40 +02:00 |
|
|
David Heinemeier Hansson
|
ac65f39c0d
|
Inline anemic partial
|
2025-04-15 16:32:56 +02:00 |
|
|
David Heinemeier Hansson
|
b9f5293231
|
Style
|
2025-04-15 16:15:13 +02:00 |
|
|
David Heinemeier Hansson
|
f30a9308d2
|
Line up scopes in order of the flow
|
2025-04-15 16:13:54 +02:00 |
|
|
David Heinemeier Hansson
|
8e479dddba
|
Clearer still
|
2025-04-15 16:04:11 +02:00 |
|
|
David Heinemeier Hansson
|
5d22809e29
|
No public use of this concept, so inline it
|
2025-04-15 16:03:14 +02:00 |
|
|
David Heinemeier Hansson
|
680611503d
|
Distinguish between administering and just changing
|
2025-04-15 16:00:29 +02:00 |
|
|
David Heinemeier Hansson
|
a6a96fd5c8
|
Dont repeat the same checks from doing, make it clearer where the difference is
|
2025-04-15 15:55:29 +02:00 |
|
|
David Heinemeier Hansson
|
93178636cd
|
Flesh out all the tests
|
2025-04-15 15:41:01 +02:00 |
|
|
David Heinemeier Hansson
|
2e8df45680
|
Flesh out tests for users controller
|
2025-04-15 15:36:11 +02:00 |
|
|
David Heinemeier Hansson
|
af0a42080b
|
Allow users to edit themselves
|
2025-04-15 15:35:39 +02:00 |
|
|
David Heinemeier Hansson
|
abd2af3d8a
|
Dont need an index for a single record
|
2025-04-15 15:35:28 +02:00 |
|
|
David Heinemeier Hansson
|
2ace519d91
|
There is only one account, so just check join code directly
|
2025-04-15 15:35:10 +02:00 |
|
|
David Heinemeier Hansson
|
7e5f71fedd
|
We will only have one account record per account
Not sure why this was added in the first place.
|
2025-04-15 15:17:30 +02:00 |
|