Commit Graph

5430 Commits

Author SHA1 Message Date
Jorge Manrubia 2af619176e Format 2025-04-03 18:16:21 +02:00
Jorge Manrubia c29768e988 Add missing transaction 2025-04-03 18:04:23 +02:00
Jorge Manrubia 0c458ef893 Add tests to make sure popping and engagement play well together 2025-04-03 18:03:34 +02:00
Jorge Manrubia c02262867e Fix merge issue 2025-04-03 17:45:11 +02:00
Jorge Manrubia 84c4003b67 Remove morphing since it's not compatible with House 2025-04-03 17:43:31 +02:00
Jorge Manrubia e07bd966f5 Enable morphing so that we get smooth page refreshes when redirecting back 2025-04-03 17:43:31 +02:00
Jorge Manrubia cfe91c25c9 Add admin role, make sure only admins can remove and promote other users 2025-04-03 17:43:29 +02:00
Jorge Manrubia 7cb2a476c4 Fix tests 2025-04-03 17:41:55 +02:00
Kevin McConnell 7eee5ce705 Remove empty helper 2025-04-03 16:37:58 +01:00
Kevin McConnell b1803e9853 Use an icon for the button 2025-04-03 16:37:22 +01:00
Kevin McConnell e7d9259828 Show button on collection page and notif settings 2025-04-03 16:37:20 +01:00
Kevin McConnell 0820badcc3 Add involvement types to accesses
This provides a way to set the level of involvement that a user has with
a collection, and from which we determine the level of notifications to
send. Users can be access-only, watching, or being notified about
everything.

If you're access-only, you won't get an notifications. If you're
watching, you'll only get notifications for the items you're watching
(which includes the items you've been assigned, have commented on, etc).
If you're set to everything you'll get notifications about all activity
in that collection.

This change replaces our previous concept of subscriptions. Where
previously you'd subscribe to a collection to get notifications in it,
now you'll simply set the notification level on your access.
2025-04-03 16:35:13 +01:00
Jorge Manrubia 8c1efa9e89 Only active cards can be in doing/considered 2025-04-03 17:20:43 +02:00
Jorge Manrubia 31e30e3053 Caching 2025-04-03 15:14:11 +02:00
Jorge Manrubia dc527e8f8a Format 2025-04-03 15:03:31 +02:00
Jorge Manrubia ac0baed663 Add some missing tests 2025-04-03 14:46:35 +02:00
Jorge Manrubia 073d799f44 Format 2025-04-03 14:41:07 +02:00
Jorge Manrubia 834b7095d3 Don't dup to avoid the memoized bubbles cache 2025-04-03 14:34:02 +02:00
Jorge Manrubia cf8331dad7 No need to modify this filter, it was already working well 2025-04-03 14:25:48 +02:00
Jorge Manrubia 91ddb1d093 Oversight 2025-04-03 14:21:21 +02:00
Jorge Manrubia 41b6f437b0 Update workflow stages with streams 2025-04-03 14:14:28 +02:00
Jorge Manrubia 17c1b2051f Add toggles to switch between doing/considering 2025-04-03 13:46:29 +02:00
Jorge Manrubia 49ef811d25 Load queries asynchronously to leverage concurrency 2025-04-03 13:28:14 +02:00
Jorge Manrubia 5a2b7c5abd Rework buckets index using proper queries and tidy up 2025-04-03 13:26:16 +02:00
Jorge Manrubia 796ee44158 Tidy up header templates for listing buckets 2025-04-03 12:53:19 +02:00
Jorge Manrubia 4fcb5a9c85 Add basic models for tracking engagement 2025-04-03 12:11:06 +02:00
Jorge Manrubia 832134385a Merge pull request #339 from basecamp/enable-morphing
Enable page refreshes with morphing
2025-04-03 11:26:25 +02:00
Jorge Manrubia 75be594534 Fix merge issues 2025-04-03 11:21:46 +02:00
Jorge Manrubia 6c201fed4c Reload stages with morphing too 2025-04-03 11:16:51 +02:00
Jorge Manrubia 4a2e3b6ebb Make frames reload compatible with page refreshes to avoid flickering 2025-04-03 11:16:39 +02:00
Jorge Manrubia c4b92eb7c3 Persist terminal turbo frame across navigations 2025-04-03 11:16:07 +02:00
Jorge Manrubia 5a740a4251 Enable page refreshes with morphing
Update Trix to a compatible version https://github.com/basecamp/house/tree/morphing-2
2025-04-03 11:16:07 +02:00
Jason Zimdars f7e2d04808 Rework the flow for closing and moving between columns 2025-04-02 17:27:34 -05:00
Andy Smith cac95d552c Extract a couple components 2025-04-02 16:28:28 -05:00
Andy Smith e91bda7ffc Add cascade layers to all CSS files 2025-04-02 16:19:56 -05:00
Andy Smith 0545639cdb Merge pull request #342 from basecamp/icon-helper
Icon helper
2025-04-02 16:10:01 -05:00
Andy Smith edf7b60f17 Remove unused class 2025-04-02 14:41:25 -05:00
Andy Smith 1beff6c89d Clean img and svg from buttons.css 2025-04-02 14:41:00 -05:00
Andy Smith 24427644a2 Replace remaining image_tags with icon_tag 2025-04-02 14:38:30 -05:00
Andy Smith 51d907fca3 Replace stray image_tag instances and remove colorize class 2025-04-02 14:32:21 -05:00
Andy Smith b8a1acefd8 Use mask icons everywhere 2025-04-02 14:22:42 -05:00
Andy Smith f662c9aa0f Add mask icon helper 2025-04-02 13:19:51 -05:00
Jorge Manrubia 4bd2a06f31 Merge pull request #341 from basecamp/fix-cache-2
Fix another caching issue
2025-04-02 18:13:27 +02:00
Jorge Manrubia 45fc687ddd Only hide stages for completed cards
We will miss the picker otherwise!
2025-04-02 18:11:39 +02:00
Jorge Manrubia d5d0b02012 Merge pull request #340 from basecamp/cache-fixes
Fix caching issue with cards
2025-04-02 17:57:14 +02:00
Jorge Manrubia c53e9680e8 Fix caching issue 2025-04-02 17:53:16 +02:00
Jason Zimdars 887489b452 Merge pull request #335 from basecamp/two-cols
Two column Collection design
2025-04-02 09:49:43 -05:00
Jason Zimdars 87304f1e27 Merge branch 'main' into two-cols
* main:
  Linting
2025-04-02 09:46:43 -05:00
Jorge Manrubia 6d716fa932 Prevent turbo frames from loading edit forms when previwing cards in collections
To render N cards we were loading 3xN turbo frames. I suspect this makes staging choke.
2025-04-02 11:21:30 +02:00
Jorge Manrubia d2cd20fe5b Add script to populate some buckets and cards 2025-04-02 11:17:23 +02:00