Commit Graph

137 Commits

Author SHA1 Message Date
Jose Farias e73f44cde9 Unnecessary parens 2024-11-06 18:16:18 -06:00
Jose Farias f7495ac1fa Improve denormalized filters note 2024-11-06 18:13:05 -06:00
Jose Farias 9efe94a277 idempotent_create -> persist 2024-11-06 18:09:55 -06:00
Jose Farias 32618debf6 Pull out strip_default_params 2024-11-06 18:05:15 -06:00
Jose Farias 49f3894bcb Update denormalization comment 2024-11-06 18:01:40 -06:00
Jose Farias be0973705c Unnecessary newline 2024-11-06 17:56:46 -06:00
Jose Farias a853f75ef9 No need to set resources in to_params anymore
They're denormalized now
2024-11-06 17:54:43 -06:00
Jose Farias e6cf8d3571 Delegate default_params to class 2024-11-06 17:52:31 -06:00
Jose Farias 12ce07639d Add tests 2024-11-06 17:49:14 -06:00
Jose Farias 3d9d169477 Many-to-many relationship for filters and filterables 2024-11-05 21:21:46 -06:00
Jose Farias f2706d0f74 Unnest bubble filters 2024-11-05 13:04:05 -06:00
Jose Farias 2f7baaff29 create -> create! 2024-10-28 10:47:49 -06:00
Jose Farias cf9b07711a Document left_joins_messageable smell 2024-10-28 10:27:50 -06:00
Jose Farias 5cdf83163c Document with_status name smell 2024-10-28 10:25:56 -06:00
Jose Farias dbad5a1a8c Document intention to persist summary body 2024-10-28 10:24:43 -06:00
Jose Farias 404755c9d9 Clean up Bubble#track_event 2024-10-28 10:20:39 -06:00
Jose Farias c571c4400d Inline EventSummary#tallied_boosts 2024-10-28 10:07:25 -06:00
Jose Farias 8b062b4432 Pull out Bubble#activity_count 2024-10-28 10:07:12 -06:00
Jose Farias 46d1ce4702 Make it clear where the boost_count is coming from 2024-10-27 19:53:37 -06:00
Jose Farias 2fb6ed76b3 Fix comments-dependent scopes 2024-10-27 19:50:06 -06:00
Jose Farias 61d68bf79d Account for event summaries with no boosts 2024-10-27 17:53:00 -06:00
Jose Farias 287a956364 Let EventSummary do the work to summarize events 2024-10-27 17:41:48 -06:00
Jose Farias 0727414017 Lean into delegated types APIs 2024-10-27 17:39:30 -06:00
Jose Farias f782b43ef5 find_or_create_next_summary -> find_or_create_active_summary 2024-10-27 12:36:37 -06:00
Jose Farias ede04d6d96 Fix search tests 2024-10-27 12:33:33 -06:00
Jose Farias 993870c10c Messageable concerns aren't actually dependent on Messages 2024-10-27 12:23:47 -06:00
Jose Farias 45ba9b7a70 Use helpers instead of partials for events 2024-10-27 12:13:03 -06:00
Jose Farias f9712ea53f Messageables don't belong to bubble directly 2024-10-27 11:57:33 -06:00
Jose Farias 1b2df2200f Unnecessary after_touch 2024-10-25 16:06:43 -06:00
Jose Farias a3edee6e58 Extract grouping of boosts 2024-10-25 16:06:34 -06:00
Jose Farias 7b104287ba Roll up boosts server-side 2024-10-25 15:39:54 -06:00
Jose Farias 46c2b450da has_one allows for touch: true 2024-10-25 15:25:57 -06:00
Jose Farias 85d47a35ab threadables -> messageables 2024-10-25 15:03:31 -06:00
Jose Farias 3cd1d34f9d Thread entries relay touches to thread 2024-10-24 19:27:55 -06:00
Jose Farias 78232fabf8 map -> pluck 2024-10-24 18:15:23 -06:00
Jose Farias f5b01415aa Bubble events can be deleted 2024-10-24 18:01:32 -06:00
Jose Farias 652ec68e9c Threadables should thread entry 2024-10-24 17:48:32 -06:00
Jose Farias 3db14a117c Store stage ids in event particulars 2024-10-24 17:36:40 -06:00
Jose Farias c57f18c20c Materialize abstract thread
The domain language is clearer if we just persist a thread. Also rename some models so their purpose is clear.
2024-10-24 17:36:14 -06:00
Jose Farias ad88f90302 Fine not to denormalize user names in events 2024-10-24 15:50:00 -06:00
Jose Farias e2f608eb71 Remove *_names accessors for bucket views 2024-10-24 15:47:39 -06:00
Jose Farias 28a024b1da Pull out Threadable::TYPES 2024-10-24 11:36:24 -06:00
Jose Farias 042bc2c10e Use Proc for Threadable after_create 2024-10-24 11:31:06 -06:00
Jose Farias 70ff52f883 Move inverse_of further up 2024-10-24 11:28:59 -06:00
Jose Farias e3db8e8700 Inline thread entry creation 2024-10-24 11:25:50 -06:00
Jose Farias c41da5837c Add back bubble association to events 2024-10-24 11:22:23 -06:00
Jose Farias 5fed37a8c4 Refactor Bubble::Thread#latest_rollup 2024-10-24 10:55:30 -06:00
Jose Farias a49c6dc3f6 Refactor Bubble#toggle_stage 2024-10-24 10:51:23 -06:00
Jose Farias 804be0a971 Create thread entry in a callback 2024-10-24 10:38:59 -06:00
Jose Farias e1f03fb8fd comment! -> comment 2024-10-23 19:13:35 -06:00