Jorge Manrubia
aee7f4f886
Not used
2025-04-24 12:34:33 +02:00
Jorge Manrubia
13b0c0fc41
First pass to tidy up activity time rendering
2025-04-24 12:28:16 +02:00
Jorge Manrubia
965100df51
Access events through collections
2025-04-24 12:28:16 +02:00
Jorge Manrubia
54f4bd5144
Generalize event's cards as eventable,add collection
...
Lots to tidy up but this is working
2025-04-24 12:28:16 +02:00
Jorge Manrubia
e8e3bd16a6
First step to make events more generic in nature
2025-04-24 12:28:16 +02:00
Jorge Manrubia
f166b30f2f
Fix: dismiss mention notifications in cards and comments when reading a card
2025-04-24 12:19:20 +02:00
Jason Zimdars
7e3bd75b15
Overflow long menus
2025-04-23 16:43:55 -05:00
Jason Zimdars
db5df1a596
Update filter on events screen
...
- Allow proper sizing
- Bring back All Collections option
2025-04-23 16:39:47 -05:00
Jason Zimdars
4bce7f1b5c
Adjust spacing, bring back "All Collections" option
2025-04-23 16:39:47 -05:00
Jason Zimdars
8c51ca391b
Move card delete button to a far less prominent position
2025-04-23 16:39:47 -05:00
Jason Zimdars
b57f049ae0
Alignment
2025-04-23 16:39:47 -05:00
Jason Zimdars
e7f4aaeeaa
More breathing room for button
2025-04-23 16:39:47 -05:00
Jason Zimdars
435d89cbe1
Just click to edit directly
2025-04-23 16:39:47 -05:00
Jason Zimdars
f9cd725c84
Tighten spacing, improve allignment
2025-04-23 16:39:47 -05:00
Jason Zimdars
c595713843
Unnecessary
2025-04-23 16:39:47 -05:00
Jorge Manrubia
646e4a59bc
Fix missing variable name
2025-04-23 18:45:55 +02:00
Jorge Manrubia
3793718e72
Fix concern I lost during merge
2025-04-23 17:25:36 +02:00
Jorge Manrubia
b08326ccbe
Merge branch 'main' into plain-text-mentions
...
* main: (48 commits)
Improve layout and truncation
This is annoying
Fix summary
Remove index columns
Same treatment for the events index
New menu filters and navigates
Don't test for _Added by_ events
Indention
@collection is always available when card scoped
Style
Remove check for _Added by..._ line
The placeholder attribute is on the `house-md` element
Duh, no before destroy commit, but this is still not right!
No long transactions!
Don't display published event in threads
But feels more essentially part of the User, so list first
Not related to the other two
Missing controller
Style
Errant `bubbles` => `cards` replacement
...
# Conflicts:
# app/models/card.rb
# app/models/user.rb
# db/schema.rb
# db/schema_cache.yml
2025-04-23 17:24:01 +02:00
Jason Zimdars
b3a2c65527
Improve layout and truncation
2025-04-23 09:24:31 -05:00
Jorge Manrubia
5749ad77e5
Rename classes
2025-04-23 16:19:50 +02:00
Jorge Manrubia
f258b05b23
Delegate target to the notifiable objects
2025-04-23 16:19:50 +02:00
Jorge Manrubia
5dac14ab50
Move logic to the model
2025-04-23 16:06:20 +02:00
Jason Zimdars
23bd8a569e
This is annoying
2025-04-23 08:53:43 -05:00
Jorge Manrubia
970a51db28
No need for it!
2025-04-23 15:49:22 +02:00
Jorge Manrubia
b4cfd40a2f
Inline, no need to duplicate the conditional
2025-04-23 15:37:28 +02:00
Jorge Manrubia
6f98f2f573
Order methods
2025-04-23 15:32:22 +02:00
Jorge Manrubia
e964c5f9c9
Not used!
2025-04-23 15:31:26 +02:00
Jorge Manrubia
53eba9bd0b
Favor after_create_commit to keep transactions fast
2025-04-23 15:28:28 +02:00
Jorge Manrubia
ea66845e71
There is always an action
2025-04-23 15:27:58 +02:00
Jorge Manrubia
e8e95bd511
Use it
2025-04-23 15:27:25 +02:00
Jorge Manrubia
4bef466df2
1-line
2025-04-23 15:22:41 +02:00
Jorge Manrubia
ad58de9e76
Remove access checks when watching
...
https://github.com/basecamp/fizzy/pull/425#discussion_r2056039581
2025-04-23 15:22:18 +02:00
Jorge Manrubia
a9df2d48d1
Remove delegate
2025-04-23 15:17:51 +02:00
Jorge Manrubia
6ff9f7a154
Fix identation
2025-04-23 15:07:02 +02:00
Jorge Manrubia
469fb9f049
Simplify the logic to determine action text changes
2025-04-23 15:02:31 +02:00
Jorge Manrubia
e446080367
Don't create duplicated mentions
...
E.g: when editing a comment or description with a mention
2025-04-23 14:45:56 +02:00
Jorge Manrubia
f43629f849
Format
2025-04-23 14:39:10 +02:00
Jorge Manrubia
dc5f64ab30
Remove redundant default queue declaration
2025-04-23 14:37:09 +02:00
Jorge Manrubia
ab73417e73
Leverage existing resolve route for comments
2025-04-23 14:34:59 +02:00
Jorge Manrubia
07d3447e7e
Resolve notifications URLs
2025-04-23 14:34:59 +02:00
Jorge Manrubia
2eae58725a
Remove notifications' resource relationship
...
Is confusing since "source" already captures the origin of the notifications. It's
needed to interpret things at rendering time, so we can query things as needed there.
2025-04-23 13:52:47 +02:00
Jorge Manrubia
696732a90a
Rename mentions' container => source
2025-04-23 13:41:34 +02:00
Jorge Manrubia
7c0aff0680
Don't indent case
2025-04-23 13:36:39 +02:00
Jorge Manrubia
043230394e
Tidy up event helper code
...
Also, revert to using a helper method to determine the event action, since this is purely a view concern. Keep method at the event model to identify initial assignments.
2025-04-23 13:35:09 +02:00
Jorge Manrubia
2e3ffcfb9d
Remove identation
2025-04-23 13:35:08 +02:00
Jorge Manrubia
755c9b45c7
Rename and fix problem where after_touch was overriding the saved content
2025-04-23 12:38:33 +02:00
Jorge Manrubia
edcc9e3279
Add mentionees as watchers
2025-04-23 12:38:06 +02:00
Jorge Manrubia
8ebb3f2fa9
We need to remember on after_touch so that the mechanism triggers when touch-cascading records automatically via associations
2025-04-23 11:38:34 +02:00
Jorge Manrubia
8b6cfccded
Rename to clarify usage
2025-04-23 11:20:33 +02:00
Jorge Manrubia
ab54cafd84
Inline event notifiers
2025-04-23 11:06:43 +02:00