Commit Graph

636 Commits

Author SHA1 Message Date
Mike Dalessio a66dc2a789 Move tags and assignments partials out of "bubbles/sidebar"
They're part of the card now, let's name them that way.

Also, rename the "tag" partial to "tagging", following the naming
convention established by the controller.
2025-03-24 17:11:58 -04:00
Mike Dalessio 5ae87d8140 Ensure the tags dropdown is not subject to the cached card fragment
- Rearrange the _tags and _tag partial, so they are properly nested concerns
- Add turbo frames for _tags and _tag
- Load _tag in a separate request, so it's not cached with the card
- Cache _tag using the bubble and the account
- New model behavior: touch Account when tags are added or removed
- New controller action: "new" for taggings toggles, which renders the _tag partial
- Updating taggings responds with a turbo stream response that updates the _tags frame

This is very much a parallel change to what was done with assignments
in #317.
2025-03-24 16:48:11 -04:00
Jason Zimdars 9c690c5822 Don't display before login 2025-03-24 15:19:51 -05:00
Mike Dalessio df377861fc Merge pull request #317 from basecamp/flavorjones-assignee-card-cache
Assignee dropdown no longer subject to the card fragment cache
2025-03-24 15:27:53 -04:00
Jason Zimdars bc5858081a Make sure back restores any active filters 2025-03-24 14:15:45 -05:00
Jason Zimdars 4bc125c7eb Load the form in a turbo frame so focused field doesn't intercept hotkeys 2025-03-24 14:15:28 -05:00
Jason Zimdars 9b9e09601e Introduce text-based UI 2025-03-24 11:33:04 -05:00
Mike Dalessio 44650cc36e Reload the assignees turbo frame when assigments are updated
Also, add a cache around the dropdown keyed on [bubble, bucket].
2025-03-21 17:53:41 -04:00
Mike Dalessio a830ec1999 Extract an "assignees" partial
pulling the avatars down from the "people" partial, and pulling the
add button up from the "assignment" partial.

The result is:

- the "bubbles/sidebar/assignment" partial is just the dialog box
- the "bubbles/assignees" partial contains everything about assignees
- the "bubbles/people" partial makes one render call

and I've introduced some turbo frames in the expectation of the next
commit which will load the dialog in the background.
2025-03-21 17:20:14 -04:00
Jason Zimdars cbc9567966 Smaller tray cards 2025-03-21 14:54:26 -05:00
Jason Zimdars 53b906423a Overflow needs to be on the nearest item 2025-03-20 18:12:43 -05:00
Jason Zimdars 39ebeadc08 Hide button when empty 2025-03-20 18:04:39 -05:00
Jason Zimdars 9dba039096 Missing class 2025-03-20 17:59:29 -05:00
Jason Zimdars eaf927f1a8 Refactor tray styles 2025-03-20 17:54:24 -05:00
Jason Zimdars 0da84efd01 Tray pins design 2025-03-20 16:52:56 -05:00
Jason Zimdars 1802a6391a Tweak events and dates 2025-03-20 13:54:56 -05:00
Jason Zimdars 2e0f787777 Polish trays behavior 2025-03-20 11:41:17 -05:00
Jason Zimdars e92995b5e5 Account for untitled bubbles 2025-03-20 11:41:02 -05:00
Jason Zimdars 7f06504a55 Ensure something is rendered when title is blank 2025-03-20 11:16:31 -05:00
Jason Zimdars 015b26e7e8 Dark mode 2025-03-20 11:16:31 -05:00
Jason Zimdars e315e66d58 Keep it top right 2025-03-19 17:54:52 -05:00
Jason Zimdars 05d377e919 Actually let's use the icons and the state 2025-03-19 17:45:20 -05:00
Jason Zimdars 264d78b21a Update test 2025-03-19 16:37:06 -05:00
Jason Zimdars 572428bfbc Improved comments and events layout 2025-03-19 16:33:03 -05:00
Jason Zimdars 714ae9d317 Differentiate events with an icon 2025-03-19 13:35:17 -05:00
Mike Dalessio a6197753ff Make sure first runs redirect will work
by turning off turbo on the form
2025-03-19 12:36:32 -04:00
Jason Zimdars 5973d14e2c Trays everywhere 2025-03-18 17:13:57 -05:00
Jason Zimdars fc163886e8 Move search onto home 2025-03-18 17:11:42 -05:00
Jason Zimdars de851fa69c Move back to edges 2025-03-18 17:10:50 -05:00
Jason Zimdars b99fc7484b Handful of tweaks 2025-03-18 16:01:31 -05:00
Kevin McConnell bc5e32e737 Only "published" notifies collection subscribers
The other notifications are only sent to the watchers of the bubble.
2025-03-18 17:46:57 +00:00
Jason Zimdars 28a569c49b Tickets 2025-03-17 21:24:08 -05:00
Jason Zimdars e53052b7e7 Fix visual button regression
`.for-screen-reader` has specific behavior inside `.btn` that makes it unsuitable for use on form elements. This fix adds a second, functionally identical, class `visually-hidden` for those cases. Later we can figure out a way to make it clear when to use which.
2025-03-14 09:58:50 -05:00
Bruno Prieto 10cdb8c1a8 Improve accessibility of comments and reactions 2025-03-14 02:29:44 +01:00
Bruno Prieto 7354e74432 Improve bubble readability for screen readers 2025-03-14 01:35:40 +01:00
Bruno Prieto 63a098fcdb Fix filter input and label id assigments 2025-03-13 23:44:05 +01:00
Bruno Prieto 793a43ff27 Add aria-label and aria-description to filter dialog
Otherwise the browser will try to infer the properties. That process is slow for screen readers
2025-03-13 22:56:28 +01:00
Bruno Prieto dfb49d0f87 Add aria-label and aria-description to filter dialog
Otherwise the browser will try to infer the properties. That process is slow for screen readers
2025-03-13 22:46:19 +01:00
Bruno Prieto cea43da13f Organize filter inputs by group, similar to fieldset
Menu tag is deprecated, li elements are only valid inside ul or ol elements
2025-03-13 22:36:12 +01:00
Bruno Prieto fdd3fb53c0 Label tag don't need a for attribute if it has a input as a children
Then input ids aren't required
2025-03-13 22:20:40 +01:00
Bruno Prieto 8a9d57e4c8 Show filter inputs for screen readers 2025-03-13 21:53:53 +01:00
Bruno Prieto bcda67e114 Div is not a valid parent for list of li elements 2025-03-13 21:25:26 +01:00
Bruno Prieto 4425e0d16a Hide bubbles for SR users for now 2025-03-13 21:24:30 +01:00
Kevin McConnell 16a80ff3a6 More dynamic activity scores
This introduces a more dynamic system of activity scoring, to improve
the way bubbles "bubble up" due to their activity. There are a few
different parts we can tune here, and it's likely we'll need to make
adjustments once we get a feel for how this works in practice.

The basic idea here is:

- We assign points for certain types of event that happen on a bubble. A
  boost gets 1 point, a comment gets 10 points, and so on.
- These points decay over time, at a rate of 50% per day. So old
  activity is worth much less than new activity. Bubbles should rise up
  quickly when acted upon, bit will float back down if left idle.
- Some comments can score higher than others: the first comment from
  each person on a bubble is worth more (20) because it signals that
  more people are getting involved; and comments that follow a comment
  by a different author are also worth more (15) because that signals
  there's ongoing conversation between people, not just a series of
  notes being left by one individual.

In terms of implementation, we persist the score on the bubble
whenever it changes, but we handle the decay on the client side. That
allows us to cache the bubble representation without having to
continually change it while its activity decays.

We also keep a separate `activity_score_order` attribute on the model.
This can be used to sort the bubbles in order of "most active", without
having to think about the decay.
2025-03-05 17:16:31 +00:00
Kevin McConnell 748d09a5f7 Cache comment partial 2025-03-03 17:04:16 +00:00
Kevin McConnell 49fa8b21a6 Move current user check to controller
This is necessary to a) ensure people can't edit/delete comments they
don't own, and b) make the comment partial cacheable.
2025-03-03 17:04:16 +00:00
Jason Zimdars 65ceb3c5f0 Tighten-up headings so they look good when they wrap to two lines (rare) 2025-03-03 09:04:37 -07:00
Jason Zimdars 72592ec3cc Order events in the cluster so that the oldest is closest to the timestamp 2025-03-03 09:04:08 -07:00
Jason Zimdars a87ffd6473 Avoid squishing the switch when the bucket name is very long 2025-03-03 08:55:49 -06:00
Kevin McConnell e7da0d5327 Merge pull request #276 from basecamp/autosave-comments
Autosave comments
2025-02-28 15:30:21 +00:00