Commit Graph

26 Commits

Author SHA1 Message Date
David Heinemeier Hansson f725a69dee Let BubbleScoped find its own bucket
Then it will be easier to break things that are double nested out of
that nesting.
2025-04-05 15:44:47 +02:00
David Heinemeier Hansson 8ff017fc5b Only one invocation of this, not carrying the worth of its indirection
Generally I am wary of including global state checks in the belly of
models. It is one thing to do it as a default parameter, but I think it
is too far to do it inside an actual method.
2025-04-05 12:40:08 +02:00
Kevin McConnell 49fa8b21a6 Move current user check to controller
This is necessary to a) ensure people can't edit/delete comments they
don't own, and b) make the comment partial cacheable.
2025-03-03 17:04:16 +00:00
Kevin McConnell 93536c3e41 Don't reload entire page when creating comment 2025-01-07 14:47:31 +00:00
Kevin McConnell 4a4b4113c8 Don't use a new request for every comment 2025-01-07 14:14:12 +00:00
Jason Zimdars 33d2d098f1 Wire up comment deletion 2024-12-16 17:46:01 -06:00
Jason Zimdars 4644fe43ee Wire up editing comments 2024-12-16 17:28:27 -06:00
Jose Farias 0727414017 Lean into delegated types APIs 2024-10-27 17:39:30 -06:00
Jose Farias f9712ea53f Messageables don't belong to bubble directly 2024-10-27 11:57:33 -06:00
Jose Farias 804be0a971 Create thread entry in a callback 2024-10-24 10:38:59 -06:00
Jose Farias e1f03fb8fd comment! -> comment 2024-10-23 19:13:35 -06:00
Jose Farias 567dec2197 Simplify threadable<>bubble relationships 2024-10-23 17:29:24 -06:00
David Heinemeier Hansson c00dcd8c66 Already comes as a hash 2024-10-19 19:55:14 -07:00
David Heinemeier Hansson 255435a38f No need for a non-standard factory method for something this simple 2024-10-19 19:53:20 -07:00
David Heinemeier Hansson 0c5778495e Resolve bubble to bucket_bubble for ease of redirecting 2024-10-19 19:48:31 -07:00
David Heinemeier Hansson b7efd04a43 Use _path consistently in the controllers when not changing host 2024-10-19 19:00:04 -07:00
David Heinemeier Hansson 2995c1571f Use the new params#expect syntax where applicable
To ensure we don't get spurious 500s when we can serve 400s on bad data
2024-10-19 18:53:41 -07:00
Jose Farias ec7fc75054 Spike events system 2024-10-11 20:14:09 -05:00
Jeffrey Hardy 4e579e5a34 Rename Project to Bucket 2024-09-24 15:32:44 -04:00
Jeffrey Hardy 355e144ddc Nest bubbles et al under projects 2024-09-18 13:09:06 -04:00
Jeffrey Hardy 7f45b8fe6e Extract BubbleScoped 2024-09-13 19:16:36 -04:00
Jeffrey Hardy 23248d8447 Tidy up comments 2024-09-05 17:36:51 -04:00
Jeffrey Hardy 5aae70298b Rename Splat to Bubble 2024-09-04 14:54:11 -04:00
Jason Zimdars 7b2ecf5d1a Anchor to newly created comments
This doesn't actually work but I thought I'd leave it in since it's a reproducible case for: https://github.com/hotwired/turbo/issues/211
2024-08-19 14:16:32 -05:00
Jason Zimdars 6860a0ea36 Create comments on splats 2024-08-19 14:14:26 -05:00
Jason Zimdars 09cc76c4f7 Render comments on splats 2024-08-14 17:36:13 -05:00