Commit Graph

99 Commits

Author SHA1 Message Date
David Heinemeier Hansson 18419c52b8 Latest schema 2025-04-05 21:46:50 +02:00
Jorge Manrubia f437aecf00 Sort completed bubbles by most recently completed first 2025-04-04 15:39:00 +02:00
Jorge Manrubia 0e3f756a27 Merge pull request #351 from basecamp/close-with-label
Close as...
2025-04-04 15:09:47 +02:00
Jorge Manrubia be4a738f1d Make reason not null 2025-04-04 15:06:43 +02:00
Jorge Manrubia 11d16d1c17 Move script to migration 2025-04-04 13:46:58 +02:00
Jorge Manrubia 77d0cd5e7f Close as working with default fallback label 2025-04-04 10:59:53 +02:00
Jorge Manrubia a4a2ea47ba Add script to populate last active at 2025-04-04 10:15:21 +02:00
Jorge Manrubia 08cb69aca5 Replace auto_pop_at with generic last_activity column
so that we can use it in other scenarios
2025-04-04 09:45:56 +02:00
Jason Zimdars 6b3231a535 Regenerate file 2025-04-03 19:34:05 -05:00
Jason Zimdars 1ea70d7d3b Merge branch 'main' into two-columns-refactor
* main:
  Fix image icons
  Revert "Merge pull request #345 from basecamp/cascade-layers"
  Fine tune notifications states
  Remove empty helper
  Use an icon for the button
  Show button on collection page and notif settings
  Add involvement types to accesses
  Extract a couple components
  Add cascade layers to all CSS files
2025-04-03 19:30:37 -05:00
Kevin McConnell 0820badcc3 Add involvement types to accesses
This provides a way to set the level of involvement that a user has with
a collection, and from which we determine the level of notifications to
send. Users can be access-only, watching, or being notified about
everything.

If you're access-only, you won't get an notifications. If you're
watching, you'll only get notifications for the items you're watching
(which includes the items you've been assigned, have commented on, etc).
If you're set to everything you'll get notifications about all activity
in that collection.

This change replaces our previous concept of subscriptions. Where
previously you'd subscribe to a collection to get notifications in it,
now you'll simply set the notification level on your access.
2025-04-03 16:35:13 +01:00
Jorge Manrubia 4fcb5a9c85 Add basic models for tracking engagement 2025-04-03 12:11:06 +02:00
Jason Zimdars 1cf2e24bcc Set buckets at the workflow level
- All bubbles inherit the bucket's set workflow
2025-03-27 14:35:07 -05:00
Mike Dalessio 2c87c2fb15 Update schema files and fix some trivial test failures. 2025-03-18 09:14:16 -04:00
Jason Zimdars 28a569c49b Tickets 2025-03-17 21:24:08 -05:00
Mike Dalessio d9ece38753 Make the application multi-tenant 2025-03-12 07:53:31 -04:00
Kevin McConnell 16a80ff3a6 More dynamic activity scores
This introduces a more dynamic system of activity scoring, to improve
the way bubbles "bubble up" due to their activity. There are a few
different parts we can tune here, and it's likely we'll need to make
adjustments once we get a feel for how this works in practice.

The basic idea here is:

- We assign points for certain types of event that happen on a bubble. A
  boost gets 1 point, a comment gets 10 points, and so on.
- These points decay over time, at a rate of 50% per day. So old
  activity is worth much less than new activity. Bubbles should rise up
  quickly when acted upon, bit will float back down if left idle.
- Some comments can score higher than others: the first comment from
  each person on a bubble is worth more (20) because it signals that
  more people are getting involved; and comments that follow a comment
  by a different author are also worth more (15) because that signals
  there's ongoing conversation between people, not just a series of
  notes being left by one individual.

In terms of implementation, we persist the score on the bubble
whenever it changes, but we handle the decay on the client side. That
allows us to cache the bubble representation without having to
continually change it while its activity decays.

We also keep a separate `activity_score_order` attribute on the model.
This can be used to sort the bubbles in order of "most active", without
having to think about the decay.
2025-03-05 17:16:31 +00:00
Kevin McConnell 2b8d41a752 Start with subscriptions on for everyone
To prevent people missing a notification they care about when we ship
the subscriptions feature, we'll start out with everything toggled on
(which matches the previous behaviour). People can then opt out as they
like.
2025-02-27 10:42:19 +00:00
Kevin McConnell d29e999552 Make Buckets subscribable 2025-02-26 10:53:03 +00:00
Kevin McConnell 59144ad17a Add Watches to track notification preferences 2025-02-26 10:53:03 +00:00
Kevin McConnell 1910bba681 Add missing table to schema 2025-02-26 10:52:50 +00:00
Jason Zimdars fb01444a88 "Added by…" is a more useful filter than "Assigned by…" 2025-02-20 16:07:07 -06:00
Jason Zimdars 000bd158eb Reactions on comments 2025-02-18 17:08:56 -06:00
Kevin McConnell dac2611c57 Auto-pop bubbles 2025-02-12 13:20:05 +00:00
Kevin McConnell e9ff277599 Add auto_pop_at 2025-02-12 13:19:55 +00:00
Kevin McConnell 485a056ba2 Add a "system" role & specific user 2025-02-12 13:19:53 +00:00
Kevin McConnell b347d77f4d Add a new "creating" state 2025-02-11 14:34:39 +00:00
Jason Zimdars d1ddb8d299 Track events on due dates 2025-02-04 15:49:34 -06:00
Jason Zimdars 881e1d07fc Merge branch 'main' into latest-activity
* main: (27 commits)
  Leave some space for the tray
  Let's not assume it's a due date
  Avoid overlap
  Let's try without the big drag button, extend beyond the column a touch
  Tighten labels
  Match notification dot
  Spacing
  Add more context
  Avoid leaving the tray open
  This shouldn't be here
  Paginate the read notifications
  Add a test case
  Split up a big view
  Allow filtering by stage
  Send beacon request on disconnect as well
  Wire up notifications "Mark all as read" button
  Add unread dot
  Set state for when there are no new notifications
  Move to right side, smooth transition
  Open tray on click, stub mark-as-read button
  ...
2025-01-24 15:07:17 -06:00
Jason Zimdars c068fac93f Merge branch 'notification-index'
* notification-index:
  This shouldn't be here
  Paginate the read notifications
  Send beacon request on disconnect as well
  Wire up notifications "Mark all as read" button
  Add unread dot
  Set state for when there are no new notifications
  Move to right side, smooth transition
  Open tray on click, stub mark-as-read button
  Refactor
  `New for you` empty state
  Add a notifications button to the tray for reaching the index when you have no unreads
  Needed when truncating so the avatar isn't squished
  Style notifications index; add truncation for long notifications
  Add an index view for all notifications
  Move notifications to tray controller
2025-01-24 13:41:59 -06:00
Kevin McConnell 85d5f7d7d7 Allow filtering by stage 2025-01-24 10:28:12 +00:00
Kevin McConnell e6fe7f680d Associate Event with Bubble
It's kind of a long way to get from one to the other right now. Every
event belongs to a bubble, so let's link them directly.
2025-01-17 14:40:36 +00:00
Kevin McConnell 6706802b89 Add an index view for all notifications 2025-01-16 17:48:38 +00:00
Kevin McConnell e807c2a8d1 Migration shouldn't unpublish existing bubbles 2025-01-15 12:34:58 +00:00
Kevin McConnell cd1e6378d0 Add drafted and published states 2025-01-15 10:58:00 +00:00
Kevin McConnell ab154f2f35 Generate notification content in a helper 2025-01-14 13:08:12 +00:00
Kevin McConnell 30b58f716b Make title a notifier attribute 2025-01-14 10:21:47 +00:00
Kevin McConnell c62e800b08 Notifications are all related to a Bubble 2025-01-13 14:21:47 +00:00
Kevin McConnell af5ac65116 Make notification target polymorphic 2025-01-13 14:21:47 +00:00
Kevin McConnell d0ae5b4bdc Add notification model 2025-01-13 14:21:47 +00:00
Kevin McConnell 90538afb3b Add Solid Queue
We'll run jobs via the Puma plugin for now, to simplify the deployment.
2025-01-08 14:02:45 +00:00
Kevin McConnell 2e892e0766 Add Solid Cache 2025-01-08 14:02:45 +00:00
Kevin McConnell 67f4038d46 Don't use fixtures as seeds
Otherwise each new deployment starts out with dev data instead of going
through the first run flow.
2025-01-06 10:58:09 +00:00
Kevin McConnell 648e9b2296 Add solid_cable 2025-01-03 16:29:43 +00:00
Jose Farias 326bdc74cf Merge branch 'main' into house
* main: (23 commits)
  Improve the flow for editing bubble titles
  Use path helpers in tests
  Revising access shouldn't do a replace turbo-action
  Split into new tests
  Update this test, too
  Adjust tests to match new behavior
  Reapply "Destroy equivalent filters upon resource removal"
  Revert "Destroy equivalent filters upon resource removal"
  Destroy equivalent filters upon resource removal
  Don't autocomplete
  Rework boosts form so you can enter any integer
  Pull out access_menu_tag
  Punt on removing filters for inaccessible buckets
  Can't see bubbles in buckets you've lost access to
  Users can remove themselves from buckets
  Fix redirect assertion
  Fix redirect assertion
  Submit form when toggling all-access + caching
  Unnecessary parens
  Can't revoke access to all-access bucket
  ...
2024-12-16 13:50:55 -06:00
Jose Farias 59c66923f0 Implement all_access buckets 2024-12-10 19:46:40 -06:00
Jose Farias d556e21287 Use House for MD comments 2024-11-27 18:59:15 -06:00
Jose Farias f266e46b57 Wire up comboboxes 2024-11-21 19:58:21 -06:00
Jose Farias e117f4e5af boost_count -> boosts_count
This aligns better with counter_cache conventions, in case we turn boosts into a model later
2024-11-19 14:22:51 -06:00
Jose Farias b4e8adca47 Pre-calculate comment counts and activity scores 2024-11-15 18:17:42 -06:00