Commit Graph

4652 Commits

Author SHA1 Message Date
Jorge Manrubia 111d4900ef Only show draft banner if the card had some data 2025-11-03 14:41:27 +01:00
Jorge Manrubia 2d1619fd34 Merge pull request #1455 from basecamp/fix-broadcasts
Don't broadcast card changes when touching activity spikes
2025-11-03 14:36:36 +01:00
Jorge Manrubia c007176ed0 Don't broadcast card changes when touching activity spikes
We do this from jobs, so there is no request id to discard the page refresh in the client. We
don't want page refreshes in these cases, as those are normally handled via the change that
originated this detection, in any case.
2025-11-03 14:35:06 +01:00
David Heinemeier Hansson 61d05ee073 No longer used 2025-11-03 14:31:16 +01:00
David Heinemeier Hansson 992b149395 No longer used 2025-11-03 14:29:01 +01:00
David Heinemeier Hansson f9ff13cdc4 Add http caching for user events 2025-11-03 14:25:32 +01:00
David Heinemeier Hansson b05e7c04e1 Ensure you can only delete your own avatar or else you have to be admin 2025-11-03 14:21:48 +01:00
David Heinemeier Hansson 4c2f3ef0b8 Style 2025-11-03 14:21:25 +01:00
David Heinemeier Hansson 3ec9308345 Always bang for exceptions 2025-11-03 14:21:06 +01:00
David Heinemeier Hansson aeb23b691c Always use templates for turbo streaming to stay consistentn 2025-11-03 13:46:34 +01:00
David Heinemeier Hansson 0a9e1620a0 No longer needed 2025-11-03 13:46:22 +01:00
Jorge Manrubia 37ce2c98d1 Refresh the cards perma dynamically with page refreshes 2025-11-03 13:04:21 +01:00
Jorge Manrubia 5f7feed6c4 Refresh activity-related bits in the card perma dynamically:
- Remove entropy bubble
- Refresh the auto close notice https://app.box-car.com/5986089/cards/2683
2025-11-03 12:48:57 +01:00
Jorge Manrubia da6d1011fd Replace card replacement with stream actions to prevent flickering when managing steps 2025-11-03 10:59:24 +01:00
Jorge Manrubia 1d6cc37bb4 Add missing blank content validation 2025-11-03 10:57:35 +01:00
Jorge Manrubia 1df8d42811 Create cards with CTRL/CMD enter 2025-11-03 09:32:29 +01:00
Jorge Manrubia 9d4dd3b00e Remove "save as draft"
Removes the creating status completely as well as the abandoned cards system. It will
always resume drafts if they exist, for a given collection and user.

https://app.box-car.com/5986089/cards/2489
2025-11-03 09:32:29 +01:00
Jorge Manrubia ebe1617f42 Format 2025-11-03 09:29:43 +01:00
Jorge Manrubia b76ff27b96 Keep the last search in place
https://app.box-car.com/5986089/cards/2703
2025-11-03 09:25:46 +01:00
David Heinemeier Hansson 9caf39ad2c Use modern strong params syntax 2025-11-02 20:26:12 +01:00
David Heinemeier Hansson 39dc2b6ab9 Prefer explicit turbo stream templates 2025-11-02 20:22:15 +01:00
David Heinemeier Hansson cf503bfba3 Prefer templates for turbo streams in all but the very simplest cases
(And probably even then)
2025-11-02 20:20:01 +01:00
David Heinemeier Hansson 3ccc93294f Style 2025-11-02 18:13:23 +01:00
David Heinemeier Hansson 3ff7a88294 Style 2025-11-02 18:11:00 +01:00
David Heinemeier Hansson fd61b4426c Conventional to do includes first 2025-11-02 18:09:30 +01:00
David Heinemeier Hansson 828ac5d2c1 Conventional order of actions 2025-11-02 18:08:49 +01:00
David Heinemeier Hansson 43069b1ea4 Extract Users::JoinsController from overloaded UsersController
Good code smell is when the before_action callbacks stack up but can't
be shared across actions
2025-11-02 17:49:25 +01:00
David Heinemeier Hansson bced7405df Extract events loading from overloaded UsersController 2025-11-02 17:31:28 +01:00
David Heinemeier Hansson 6a62df470c No longer used 2025-11-02 16:34:29 +01:00
David Heinemeier Hansson 877e62dec5 No CR when there are only two statements 2025-11-02 16:30:49 +01:00
David Heinemeier Hansson 02bd57089d Use before_action to pull up account assignment 2025-11-02 16:04:44 +01:00
David Heinemeier Hansson c834cce504 Simplify join code creation and validation and test controller
cc @monorkin
2025-11-02 15:58:33 +01:00
David Heinemeier Hansson f09183bc9a Don't want to balloon txn, but also don't want to end up with a state with broken data 2025-11-02 15:46:05 +01:00
David Heinemeier Hansson 2c9845eb62 No need to hide that the top-level entropy is tied to the Account 2025-11-02 15:24:55 +01:00
David Heinemeier Hansson a1543f2660 Inline anemic helper method with no additional explaining purpose 2025-11-02 14:20:07 +01:00
David Heinemeier Hansson d6c88736bd No need for validation when we have rely on update!/create! on db constraints 2025-11-02 14:19:26 +01:00
David Heinemeier Hansson 0af74bfa11 Style 2025-11-02 14:17:46 +01:00
David Heinemeier Hansson 966aa51a37 Get rid of unnecessary touch jobs
touch_all on 10K cards took 6ms in testing
2025-11-02 14:15:53 +01:00
David Heinemeier Hansson 105585c26c Merge pull request #1451 from basecamp/entropies
Entropy::Configuration -> Entropy
2025-11-02 13:59:43 +01:00
David Heinemeier Hansson 7052d6ecec Fix style 2025-11-02 13:54:46 +01:00
David Heinemeier Hansson 2c4159d11a Style 2025-11-02 13:29:07 +01:00
David Heinemeier Hansson fb395c8b07 Keep all entropy definitions together in the concern 2025-11-02 13:17:55 +01:00
David Heinemeier Hansson b3474ec97d Rename Entropy::Configuration to just Entropy 2025-11-02 13:11:41 +01:00
David Heinemeier Hansson d29e4dcdcf No CR when there are only two statements in total 2025-11-02 12:49:54 +01:00
David Heinemeier Hansson e6459cede3 Use existing authorization method 2025-11-02 08:34:06 +01:00
David Heinemeier Hansson 8e48167774 Merge branch 'main' into events-daily-cut-off 2025-11-02 08:12:02 +01:00
Jason Zimdars b07345724a Merge pull request #1438 from basecamp/profile-layout
Put profile boxes side-by-side
2025-10-31 17:11:30 -05:00
Jason Zimdars 56d30d6d97 Merge pull request #1439 from basecamp/event-title-style
Underline event titles
2025-10-31 17:09:04 -05:00
Jason Zimdars 693fe6bf50 Merge pull request #1435 from basecamp/bar-icon-align
Align bar shortcuts better
2025-10-31 17:07:49 -05:00
Jason Zimdars 2a8d361c5a Merge pull request #1440 from basecamp/new-board-in-nav
Shift Add Board around in the nav
2025-10-31 17:05:48 -05:00