Donal McBreen
eecdb486b7
Remove unused attribute
2025-11-21 14:42:28 +00:00
Donal McBreen
bef4b86212
Use card_search_records instead of join class method
2025-11-21 14:42:09 +00:00
Donal McBreen
aaf512875e
Add search_record has_one
2025-11-21 14:34:41 +00:00
Donal McBreen
32c3bcec9f
Merge branch 'main' into sqlite
2025-11-21 14:26:21 +00:00
Donal McBreen
ea06b2d46f
Simplify and test highlighing
2025-11-21 14:25:38 +00:00
Jorge Manrubia
41905068c0
Bundle after notification is committed to mitigate reading stale data when bundling
...
Attempt to deal with overlapping bundles being created by notifications created immediately
one after the other.
2025-11-21 14:34:05 +01:00
Donal McBreen
6e749d2b5f
Drop for_user
2025-11-21 12:39:47 +00:00
Donal McBreen
aebe3f97ed
Drop parentheses
2025-11-21 12:37:29 +00:00
Donal McBreen
02da6dbf8f
Parameterised queries
2025-11-21 12:36:45 +00:00
Donal McBreen
463a5f089a
Consolidate scopes and extract search_fields
2025-11-21 12:31:25 +00:00
Donal McBreen
f91c41d75a
Drop variables
2025-11-21 12:11:15 +00:00
Donal McBreen
01d16f96d4
Remove Search::Record.for_account
...
Instead we'll compute the table name dynamically based on
Current.account where needed. Also we'll prevent searchable records
from being saved if Current.account is not set, otherwise the after
commit callbacks will fail.
2025-11-21 12:09:21 +00:00
Donal McBreen
4008819390
Use table_name with Current.account to drop for_account
2025-11-21 11:54:21 +00:00
Donal McBreen
b92aba383e
account_key is MySQL specific
2025-11-21 11:47:28 +00:00
Stanko Krtalić
90113206e3
Merge pull request #1676 from basecamp/fix-filters-obscuring-jump-menu
...
Fix pickers obscuring jump menu
2025-11-21 12:45:54 +01:00
Donal McBreen
2e4d0b38db
Fix matching scope after merge
2025-11-21 11:43:01 +00:00
Stanko K.R.
dd5cf6f628
Fix pickers obscuring jump menu
2025-11-21 12:41:45 +01:00
Donal McBreen
366dbd393c
Merge branch 'main' into sqlite
2025-11-21 11:39:47 +00:00
Donal McBreen
adff4591fe
Search with the tenant key
...
The key has been added and populated so use it for searching.
2025-11-21 11:09:06 +00:00
Stanko Krtalić
342ebc4975
Merge pull request #1672 from basecamp/fix-back-navigation-not-opening-new-tabs
...
Fix inability to open "Back to" inks in a new tab
2025-11-21 11:53:10 +01:00
Stanko K.R.
7c15be02f8
Skip navigation when opening a new tab
2025-11-21 11:48:29 +01:00
Donal McBreen
a4ce9fc5c0
Merge pull request #1671 from basecamp/search-tenant-key
...
Search tenant key
2025-11-21 10:42:47 +00:00
Donal McBreen
74d1cf735b
Only add and fill account_key
2025-11-21 10:20:27 +00:00
Stanko K.R.
2b23d85653
Add dir=auto to title inputs
...
See: https://github.com/basecamp/once-campfire/pull/97
2025-11-21 11:13:44 +01:00
Donal McBreen
70dd754cf7
Account key for search records
...
Add an account key field to improve search performance. This field
allows us to filter the records by account directly in the fulltext
index, so we only need to examine rows belonging to the relevant account.
2025-11-21 09:38:35 +00:00
Donal McBreen
4f6ec19491
Drop comments
2025-11-21 09:15:19 +00:00
Donal McBreen
0e11a139a5
Move quoting
2025-11-21 09:15:19 +00:00
Donal McBreen
62d102578f
Table name already correct
2025-11-21 09:15:19 +00:00
Donal McBreen
ca17193620
Belongs_to not optional
2025-11-21 09:15:19 +00:00
Donal McBreen
6dfb961b83
Delegate to_s to terms
2025-11-21 09:15:19 +00:00
Donal McBreen
ec06b7085b
No need to default created_at
2025-11-21 09:15:19 +00:00
Donal McBreen
19b0e25eac
Split sqlite/mysql record stuff
2025-11-21 09:15:19 +00:00
Donal McBreen
a4850fbe73
Remove adapter specific logic from searchable
2025-11-21 09:15:19 +00:00
Donal McBreen
a682a807ed
Handle SQLite date subtraction
2025-11-21 09:15:19 +00:00
Donal McBreen
cc7e091508
Disable multi-db for SQLite
2025-11-21 09:15:19 +00:00
Donal McBreen
bb36b4846f
Support SQLite searching
2025-11-21 09:15:19 +00:00
Donal McBreen
a2333d9a37
Add SQLite support
...
- UUID support
- Schema compatibility layer, ignore MySQL specific options
- Search not working yet
2025-11-21 09:15:19 +00:00
Jorge Manrubia
9d08f26c59
Disable turbo when navigating to another account
...
So that the turbo-permanent trays get properly replaced
https://app.fizzy.do/5986089/cards/3094
2025-11-21 09:54:16 +01:00
Jorge Manrubia
021831f810
Extract partials for the different sections
2025-11-21 09:48:00 +01:00
Jorge Manrubia
85b9e3dfd4
Make the notifications tray reload on broadcasted refreshes
...
We can't use the normal refresh: :morph because everything is contained in a turbo permanent section
so that the trays persist across regular navigation.
2025-11-21 09:41:03 +01:00
Jorge Manrubia
e813b7eaf0
Invalidate HTTP caching when the cards change
...
https://app.fizzy.do/5986089/cards/3067
2025-11-21 09:32:02 +01:00
Jorge Manrubia
649888dbd4
Making the frame permanent with an id would reconnect the editor causing the dup
...
This is something we need to fix in Lexxy for good, but for now this patch will do it.
https://github.com/basecamp/lexxy/issues/263
2025-11-21 08:52:10 +01:00
Jason Zimdars
9bae30f771
Show account if you have multiple
...
It's hard to know which account email notifications are coming from
2025-11-20 22:03:54 -06:00
Jason Zimdars
b1762ea6b6
Display code right in the subject line
2025-11-20 21:45:26 -06:00
Jason Zimdars
5e18d79999
Merge pull request #1661 from basecamp/revert-1660-revert-1659-notifications-copy
...
Add more detail to events summaries
2025-11-20 21:41:09 -06:00
Jason Zimdars
ad7eb594d3
Match copy coming in #1663
2025-11-20 21:31:40 -06:00
Mike Dalessio
1bbb6d0c03
Fix race condition in Card::ActivitySpike::DetectionJob
...
The check-then-act pattern in `register_activity_spike` has been
replaced with `find_or_create_by!` to eliminate the race condition
that could lead to creating multiple activity spikes for a card. To
support this change, the `card_id` index on `cards_activity_spikes`
has been made unique.
ref: https://app.fizzy.do/5986089/cards/3063
2025-11-20 15:40:42 -05:00
Jorge Manrubia
c052839bd6
Removed quotes since we were not using them
2025-11-20 21:37:41 +01:00
Jorge Manrubia
a5b58e47fe
Remove unclosed span
2025-11-20 21:32:43 +01:00
Jorge Manrubia
baadd484b4
Review triage
2025-11-20 21:28:41 +01:00