Commit Graph

7462 Commits

Author SHA1 Message Date
Donal McBreen 4c4f6957ec Drop sqlite compability, using a separate schema.rb 2025-11-21 17:25:40 +00:00
Stanko Krtalić 08f13f13f3 Merge pull request #1685 from basecamp/fix-crash-on-very-long-card-titles
Fix crash on very long card titles
2025-11-21 18:20:00 +01:00
Stanko K.R. 2c1a0301c2 Fix crash on very long card titles 2025-11-21 18:17:49 +01:00
Stanko Krtalić 99f5e2b280 Merge pull request #1684 from basecamp/fix-call-to-nonexistant-blur-action
Fix call to non-existant blur action
2025-11-21 18:00:58 +01:00
Stanko K.R. 6f8364071c Fix call to non-existant blur action 2025-11-21 17:57:38 +01:00
Andy Smith 7fb46ee6b7 Merge pull request #1683 from basecamp/andy-nov-20
Andy nov 20
2025-11-21 10:02:02 -06:00
Donal McBreen 2199dcc0c8 Fix name in SQL string 2025-11-21 16:01:05 +00:00
Mike Dalessio 7a057b81af Merge pull request #1682 from basecamp/flavorjones/active-storage-cleanup
Drop the "max previewable file size" limit
2025-11-21 10:56:54 -05:00
Mike Dalessio b2e3c7b1c7 Drop the "max previewable file size" limit
which was originally introduced to work around timing issues causing
us to try (and fail) to generate previews on sqlite read replicas.
2025-11-21 10:55:20 -05:00
Donal McBreen 6f02cb40b1 Drop unnecessary html_safes 2025-11-21 15:46:31 +00:00
Donal McBreen d09deca038 Fallback to search_records_0, so eager loading has a valid table 2025-11-21 15:35:58 +00:00
Jason Zimdars 2c4d2df469 Merge pull request #1679 from basecamp/notifications
Cap the max number of unread notifications to 500
2025-11-21 09:34:26 -06:00
Jorge Manrubia 95b555869b not used 2025-11-21 16:31:06 +01:00
Donal McBreen 0989017f62 Fix rubocop 2025-11-21 15:31:00 +00:00
Donal McBreen d48eb523b8 Fix rubocop 2025-11-21 15:30:14 +00:00
Jason Zimdars c0920f046f Move to bottom, use utility classes 2025-11-21 09:29:21 -06:00
Donal McBreen be0ce5efa0 Use dependant delete on fts table 2025-11-21 15:28:25 +00:00
Donal McBreen b1862733dd Merge branch 'main' into sqlite 2025-11-21 15:23:34 +00:00
Donal McBreen 525e53a2f7 Add FTS ActiveRecord model
Needs some special handling for the FTS virtual table format. Set the
primary key to rowid and manually specify the columns.
2025-11-21 15:21:11 +00:00
Jason Zimdars 2382326a13 Merge pull request #1638 from basecamp/expand-activity-columns
Expand activity columns
2025-11-21 09:11:22 -06:00
Stanko Krtalić b5a28388e6 Merge pull request #1681 from basecamp/blur-comment-field-on-submit
Blur comment field after submission
2025-11-21 16:03:59 +01:00
Stanko K.R. ac2ed4851e Blur comment field after submission 2025-11-21 15:59:22 +01:00
Kevin McConnell 1f7495a5fe Merge pull request #1680 from basecamp/restore-automatic-migrations
Restore automatic migrations
2025-11-21 14:56:40 +00:00
Jorge Manrubia 42a39b224c Cap the max number of unread notifications to 500
Simpler than adding 2 levels of pagination here
2025-11-21 15:55:24 +01:00
Kevin McConnell 621c3ec993 Restore automatic migrations 2025-11-21 14:53:29 +00:00
Donal McBreen 04c9d9268b Remove wrapper methods and kwargs 2025-11-21 14:53:17 +00:00
Donal McBreen eecdb486b7 Remove unused attribute 2025-11-21 14:42:28 +00:00
Donal McBreen bef4b86212 Use card_search_records instead of join class method 2025-11-21 14:42:09 +00:00
Donal McBreen aaf512875e Add search_record has_one 2025-11-21 14:34:41 +00:00
Donal McBreen f384a0d9b8 Fix database.yml merge error 2025-11-21 14:30:17 +00:00
Donal McBreen 32c3bcec9f Merge branch 'main' into sqlite 2025-11-21 14:26:21 +00:00
Donal McBreen ea06b2d46f Simplify and test highlighing 2025-11-21 14:25:38 +00:00
Jorge Manrubia d14ffc1b79 Merge pull request #1678 from basecamp/notification-bundles
Fix: overlapping notification bundles
2025-11-21 14:46:24 +01:00
Jorge Manrubia c1f5699443 Switch READ-COMMITED so that queries see the last committed data
This should help solving the problem with overlapping bundles

It is what we use in HEY and Basecamp
2025-11-21 14:35:29 +01:00
Jorge Manrubia 41905068c0 Bundle after notification is committed to mitigate reading stale data when bundling
Attempt to deal with overlapping bundles being created by notifications created immediately
one after the other.
2025-11-21 14:34:05 +01:00
Donal McBreen 6e749d2b5f Drop for_user 2025-11-21 12:39:47 +00:00
Donal McBreen aebe3f97ed Drop parentheses 2025-11-21 12:37:29 +00:00
Donal McBreen 02da6dbf8f Parameterised queries 2025-11-21 12:36:45 +00:00
Donal McBreen 463a5f089a Consolidate scopes and extract search_fields 2025-11-21 12:31:25 +00:00
Donal McBreen f91c41d75a Drop variables 2025-11-21 12:11:15 +00:00
Donal McBreen 01d16f96d4 Remove Search::Record.for_account
Instead we'll compute the table name dynamically based on
Current.account where needed. Also we'll prevent searchable records
from being saved if Current.account is not set, otherwise the after
commit callbacks will fail.
2025-11-21 12:09:21 +00:00
Donal McBreen 4008819390 Use table_name with Current.account to drop for_account 2025-11-21 11:54:21 +00:00
Jorge Manrubia 6daccc88ae Deselect column/card selection when clicking outside 2025-11-21 12:53:13 +01:00
Donal McBreen b92aba383e account_key is MySQL specific 2025-11-21 11:47:28 +00:00
Stanko Krtalić 90113206e3 Merge pull request #1676 from basecamp/fix-filters-obscuring-jump-menu
Fix pickers obscuring jump menu
2025-11-21 12:45:54 +01:00
Donal McBreen e76f159f05 Gate search_record shard migrations on adapter type 2025-11-21 11:44:37 +00:00
Donal McBreen 2e4d0b38db Fix matching scope after merge 2025-11-21 11:43:01 +00:00
Stanko K.R. dd5cf6f628 Fix pickers obscuring jump menu 2025-11-21 12:41:45 +01:00
Donal McBreen 366dbd393c Merge branch 'main' into sqlite 2025-11-21 11:39:47 +00:00
Donal McBreen 50b3ae1d79 Merge pull request #1675 from basecamp/tenant-key-remove-indexes
Remove the old fulltext indexes
2025-11-21 11:34:54 +00:00