Jason Zimdars
fe48aecaae
Eliminate double-tab behavior
2025-05-07 12:28:09 -05:00
Jason Zimdars
28659c1295
Clear error state when you start editing
...
- It feels wrong to persist the error state while you're fixing the command
2025-05-07 11:52:20 -05:00
Jason Zimdars
19a7972a46
Don't indicate spelling errors
2025-05-07 11:43:45 -05:00
Andy Smith
03473d8842
Merge pull request #406 from basecamp/closing-soon-badge
...
Closing soon badge
2025-05-07 11:13:35 -05:00
Jorge Manrubia
6776e69ed8
Stop propagation so that it doesn't navigate back on ESC
2025-05-07 14:43:11 +02:00
Jorge Manrubia
87484dbca0
Add basic keyboard navigation support for the Fizzy do menu
2025-05-07 13:46:19 +02:00
Jorge Manrubia
0dcc6959da
Extract constant to clarify regexp
2025-05-07 13:31:52 +02:00
Jorge Manrubia
4d2f2067ed
Format
2025-05-07 12:13:45 +02:00
Jorge Manrubia
181e35b5b2
Restore command when clicking on it
2025-05-07 12:03:02 +02:00
Jorge Manrubia
8697cabbe2
Show confirmation when submitting certain commands
...
https://3.basecamp.com/2914079/buckets/37331921/todos/8617430347
2025-05-07 10:20:32 +02:00
Jorge Manrubia
22c3c33c0b
Merge pull request #460 from basecamp/fizzy-do-initial
...
Fizzy Do (initial)
2025-05-07 08:57:37 +02:00
Jorge Manrubia
6f382b68e0
Rename command controller => terminal controller and name the error class after terminal
2025-05-07 08:53:25 +02:00
Jorge Manrubia
55ea460d3e
Handle form errors with a stimulus class
...
We need to keep the focus in place when submitting the form. We are using a data-turbo-permanent for that. We were rendering the error form with a turbo stream. The problem was that turbo streams ignore permanent elements as per this https://github.com/hotwired/turbo/pull/688 , so the system wasn't updating the input field as expected.
Handling this as the stimulus level will also help with managing additional error states (such as the one we need for confirmations).
2025-05-07 08:46:47 +02:00
Jason Zimdars
94e2ab25f9
Make command a button
2025-05-06 17:45:05 -05:00
Jason Zimdars
10890df97f
Style undo button
2025-05-06 17:32:45 -05:00
Jason Zimdars
521351da16
Add a keyboard shortcut
2025-05-06 16:15:19 -05:00
Jason Zimdars
36fb154ee1
Display obvious chip when filtering by stage
2025-05-06 15:45:28 -05:00
Andy Smith
4d1c215f02
Merge branch 'main' into closing-soon-badge
2025-05-06 15:25:01 -05:00
Jorge Manrubia
1faaed4a16
Prefer ul
2025-05-06 16:06:47 +02:00
Jorge Manrubia
a8d4cbcff0
Keep focus in place when navigating and morphing
2025-05-06 12:14:04 +02:00
Jorge Manrubia
bf443a2438
Remove turbo permanent that messes up with error rendering
2025-05-06 11:15:03 +02:00
Jorge Manrubia
5280221d5f
Format
2025-05-06 10:45:40 +02:00
Jorge Manrubia
08507048ea
Add aria label
2025-05-06 10:43:59 +02:00
Jorge Manrubia
5c417ada63
Keep focus
2025-05-06 10:20:37 +02:00
Jorge Manrubia
8ad3461d1b
Keep focus on error
2025-05-06 10:16:38 +02:00
Jorge Manrubia
0bdbcbf156
Highlight errors
2025-05-06 09:56:12 +02:00
Jorge Manrubia
456463ffef
Reset form automatically
2025-05-06 09:30:37 +02:00
Jorge Manrubia
3954033e61
Make confirmation for undo work
2025-05-06 09:27:00 +02:00
Jorge Manrubia
3e8896ef93
Undo working for assignments
2025-05-06 09:25:52 +02:00
Jorge Manrubia
7a51e13d7c
Remove old code
2025-05-06 08:56:56 +02:00
Jorge Manrubia
9d7459f865
Show recent commands
2025-05-06 08:54:58 +02:00
Jorge Manrubia
ea1f39ac6c
Move partial
2025-05-06 07:59:20 +02:00
Jorge Manrubia
56318dbcb1
Not used
2025-05-06 07:54:38 +02:00
Jorge Manrubia
72ffcfac8b
Assignments working
2025-05-06 06:45:37 +02:00
Jorge Manrubia
65d809dd8d
Basic models for Fizzy do and searches working with them
2025-05-06 06:42:33 +02:00
Jason Zimdars
8e0154addc
Subtle fading and overlapping grid lines
2025-05-02 15:51:50 -05:00
Jason Zimdars
bc6709c4eb
Display card id
2025-05-02 20:00:51 +02:00
Jason Zimdars
ba83625a60
Don't count the system user
2025-05-02 18:17:03 +02:00
Jason Zimdars
4cf0242443
Handle the case where you can only see one collection
2025-05-02 18:08:57 +02:00
Jason Zimdars
360d37d6ff
Stub stalled setting, adjust auto-close options
2025-05-02 16:04:32 +02:00
Jason Zimdars
1ef1839a81
No need for it to be huge
2025-05-02 15:51:29 +02:00
Jason Zimdars
61be8ef3b8
No need to separate users with a space
2025-05-02 15:48:06 +02:00
Jason Zimdars
c9d5a78ac4
Avoid truncating workflow name, adjust alignment and sizing
2025-05-02 15:47:14 +02:00
Jason Zimdars
38062aab47
No need to set this here, it's inherited
2025-05-02 15:38:36 +02:00
Jason Zimdars
4797896686
Copy edit
2025-05-02 14:18:42 +02:00
Jason Zimdars
9c813720e5
Remove duplicate class name
2025-05-02 14:18:28 +02:00
Andy Smith
6c7de54137
Rename 'badge' to 'bubble'
2025-05-01 11:19:58 +02:00
Andy Smith
0d086cd39e
Merge branch 'main' into closing-soon-badge
2025-05-01 09:59:42 +02:00
Andy Smith
78941e5068
Address PR feedback
2025-05-01 09:58:23 +02:00
Jason Zimdars
8e5209a4a5
Merge branch 'main' into jz-4-30
...
* main:
New line
Not used
Remove another reference to message
Remove summary id column too
Script to re-create system comments
Drop event summaries too
Extract method
Add tests and clean unused events
Format
Remove default chronological order
Format
Create system comments on events
Rename test that was being skipped
Flatten out comments and messages
2025-04-30 11:30:04 +02:00