Jeremy Daer
a52b6f1c87
* Add explicit wrap_parameters to controllers for flat JSON API support Virtual attributes (has_rich_text, has_one_attached, delegated setters, ActiveModel attrs) are not in Model.attribute_names, so wrap_parameters auto-detection silently drops them from flat JSON requests. Add explicit include: lists matching each controller's permitted params. * Convert short-form wrap_parameters to explicit include: lists Defense-in-depth: these controllers only have real-column params today, so auto-detection works, but explicit lists prevent future regressions if virtual attributes are added. * Add flat JSON param tests for all wrap_parameters controllers 17 new tests covering every controller with wrap_parameters, verifying that flat (unwrapped) JSON payloads are correctly wrapped and processed. Focuses on virtual attributes that would be silently dropped without explicit include: lists.
54 lines
1.1 KiB
Ruby
54 lines
1.1 KiB
Ruby
class Boards::ColumnsController < ApplicationController
|
|
wrap_parameters :column, include: %i[ name color ]
|
|
|
|
include BoardScoped
|
|
|
|
before_action :set_column, only: %i[ show update destroy ]
|
|
|
|
def index
|
|
@columns = @board.columns.sorted
|
|
fresh_when etag: @columns
|
|
end
|
|
|
|
def show
|
|
set_page_and_extract_portion_from @column.cards.active.latest.with_golden_first.preloaded
|
|
fresh_when etag: @page.records
|
|
end
|
|
|
|
def create
|
|
@column = @board.columns.create!(column_params)
|
|
|
|
respond_to do |format|
|
|
format.turbo_stream
|
|
format.json { render :show, status: :created, location: board_column_path(@board, @column, format: :json) }
|
|
end
|
|
end
|
|
|
|
def update
|
|
@column.update!(column_params)
|
|
|
|
respond_to do |format|
|
|
format.turbo_stream
|
|
format.json { head :no_content }
|
|
end
|
|
end
|
|
|
|
def destroy
|
|
@column.destroy
|
|
|
|
respond_to do |format|
|
|
format.html { redirect_back_or_to @board }
|
|
format.json { head :no_content }
|
|
end
|
|
end
|
|
|
|
private
|
|
def set_column
|
|
@column = @board.columns.find(params[:id])
|
|
end
|
|
|
|
def column_params
|
|
params.expect(column: [ :name, :color ])
|
|
end
|
|
end
|