Jeremy Daer
21f3f72647
Process variants synchronously on attachment to close the window between image upload and variant availability, guaranteeing that we won't have lazy variant processing attempts in GET requests. Tradeoff is that we do variant processing in upload requests, which is actually desirable. We're working with images that should take milliseconds to resize given that we'll already have the file on hand. References https://github.com/rails/rails/pull/51951
51 lines
2.2 KiB
Ruby
51 lines
2.2 KiB
Ruby
require "test_helper"
|
|
|
|
class User::AvatarTest < ActiveSupport::TestCase
|
|
test "avatar_thumbnail returns variant for variable images" do
|
|
blob = ActiveStorage::Blob.create_and_upload!(io: File.open(file_fixture("moon.jpg")), filename: "moon.jpg", content_type: "image/jpeg")
|
|
users(:david).avatar.attach(blob)
|
|
|
|
assert users(:david).avatar.variable?
|
|
assert_equal users(:david).avatar.variant(:thumb).blob, users(:david).avatar_thumbnail.blob
|
|
end
|
|
|
|
test "avatar_thumbnail returns original blob for non-variable images" do
|
|
users(:david).avatar.attach(io: File.open(file_fixture("avatar.svg")), filename: "avatar.svg", content_type: "image/svg+xml")
|
|
|
|
assert_not users(:david).avatar.variable?
|
|
assert_equal users(:david).avatar.blob, users(:david).avatar_thumbnail.blob
|
|
end
|
|
|
|
test "allows valid image content types" do
|
|
blob = ActiveStorage::Blob.create_and_upload!(io: File.open(file_fixture("moon.jpg")), filename: "test.jpg", content_type: "image/jpeg")
|
|
users(:david).avatar.attach(blob)
|
|
|
|
assert users(:david).valid?
|
|
end
|
|
|
|
test "rejects SVG uploads" do
|
|
users(:david).avatar.attach(io: File.open(file_fixture("avatar.svg")), filename: "avatar.svg")
|
|
|
|
assert_not users(:david).valid?
|
|
assert_includes users(:david).errors[:avatar], "must be a JPEG, PNG, GIF, or WebP image"
|
|
end
|
|
|
|
test "thumb variant is processed immediately on attachment" do
|
|
# Create blob separately to ensure file is uploaded before variant processing.
|
|
#
|
|
# Root cause: When ActiveStorage::Record uses `connects_to` for read replica support
|
|
# (as in SAAS mode), it creates a separate connection pool from application models.
|
|
# Since after_commit callbacks are tracked per connection pool, the callback order
|
|
# between User's pool (upload) and Attachment's pool (create_variants) isn't guaranteed.
|
|
# In MySQL/SAAS mode, the Attachment callback fires before the file is uploaded.
|
|
blob = ActiveStorage::Blob.create_and_upload!(
|
|
io: File.open(file_fixture("avatar.png")),
|
|
filename: "avatar.png",
|
|
content_type: "image/png"
|
|
)
|
|
users(:david).avatar.attach(blob)
|
|
|
|
assert users(:david).avatar.variant(:thumb).processed?
|
|
end
|
|
end
|