Rob Zolkos
23ac76555b
* Validate and normalize auto-postpone period to days - Add Entropy::AUTO_POSTPONE_PERIODS and validate auto_postpone_period against the allowed set - Introduce auto_postpone_period_in_days for forms and entropy update endpoints - Fall back to index 0 in knob partial when current value isn't in options - Remove entropy_auto_close_options helper in favor of model constant - Update tests to use allowed period values * Use auto_postpone_period_in_days for JSON entropy updates The JSON API was accepting auto_postpone_period (seconds) which bypassed the days normalization and validation. Switch to auto_postpone_period_in_days consistently and add explicit wrap_parameters so flat JSON params are wrapped correctly for the virtual attribute. * Default to account or 30-day fallback when knob value is invalid * Address PR review feedback for entropy validation - Fall back to first knob option (index 0) when persisted value isn't in the allowed set, preventing nil index errors for legacy values - Use integer division (1.day.to_i) for consistent day calculations * Default to account entropy period instead of first option for knob fallback * Test that default auto-postpone period is in the allowed periods * Return 422 instead of 500 for invalid entropy auto-postpone values Rescue ActiveRecord::RecordInvalid in entropy controllers so invalid auto_postpone_period_in_days values return 422 Unprocessable Entity instead of raising a 500. * Fix NoMethodError when board entropy falls back to account default Use container.account.entropy.auto_postpone_period_in_days instead of container.account.auto_postpone_period_in_days since Account doesn't delegate that method. * Test board entropy fallback to account default for invalid periods
86 lines
3.4 KiB
Ruby
86 lines
3.4 KiB
Ruby
require "test_helper"
|
|
|
|
class Card::EntropicTest < ActiveSupport::TestCase
|
|
setup do
|
|
Current.session = sessions(:david)
|
|
end
|
|
|
|
test "auto_postpone_at uses the period defined in the account by default" do
|
|
freeze_time
|
|
|
|
entropies(:writebook_board).destroy
|
|
entropies("37s_account").reload.update! auto_postpone_period: 365.days
|
|
cards(:layout).update! last_active_at: 2.day.ago
|
|
assert_equal (365 - 2).days.from_now, cards(:layout).entropy.auto_clean_at
|
|
end
|
|
|
|
test "auto_postpone_at infers the period from the board when present" do
|
|
freeze_time
|
|
|
|
entropies(:writebook_board).update! auto_postpone_period: 90.days
|
|
cards(:layout).update! last_active_at: 2.day.ago
|
|
assert_equal (90 - 2).days.from_now, cards(:layout).entropy.auto_clean_at
|
|
end
|
|
|
|
test "setting auto_postpone_period in the board without entropy will create it, without affecting the account entropy" do
|
|
account_entropy = entropies("37s_account")
|
|
original_period = account_entropy.auto_postpone_period
|
|
|
|
entropies(:writebook_board).destroy
|
|
boards(:writebook).update! auto_postpone_period: 365.days
|
|
|
|
assert_equal original_period, account_entropy.reload.auto_postpone_period
|
|
end
|
|
|
|
test "auto postpone all due using the default account entropy" do
|
|
entropies(:writebook_board).destroy
|
|
|
|
cards(:logo).update!(last_active_at: 1.day.ago - entropies("37s_account").auto_postpone_period)
|
|
cards(:shipping).update!(last_active_at: 1.day.from_now - entropies("37s_account").auto_postpone_period)
|
|
|
|
assert_difference -> { Card.postponed.count }, +1 do
|
|
Card.auto_postpone_all_due
|
|
end
|
|
|
|
assert cards(:logo).reload.postponed?
|
|
assert_equal accounts("37s").system_user, cards(:logo).postponed_by
|
|
assert_not cards(:shipping).reload.postponed?
|
|
end
|
|
|
|
test "auto postpone all due using entropy defined at the board level" do
|
|
cards(:logo).update!(last_active_at: 1.day.ago - entropies(:writebook_board).auto_postpone_period)
|
|
cards(:shipping).update!(last_active_at: 1.day.from_now - entropies(:writebook_board).auto_postpone_period)
|
|
|
|
assert_difference -> { Card.postponed.count }, +1 do
|
|
Card.auto_postpone_all_due
|
|
end
|
|
|
|
assert cards(:logo).reload.postponed?
|
|
assert_not cards(:shipping).reload.postponed?
|
|
end
|
|
|
|
test "postponing soon scope" do
|
|
cards(:logo, :shipping).each(&:published!)
|
|
|
|
cards(:logo).update!(last_active_at: entropies(:writebook_board).auto_postpone_period.seconds.ago + 2.days)
|
|
cards(:shipping).update!(last_active_at: entropies(:writebook_board).auto_postpone_period.seconds.ago - 2.days)
|
|
|
|
assert_includes Card.postponing_soon, cards(:logo)
|
|
assert_not_includes Card.postponing_soon, cards(:shipping)
|
|
end
|
|
|
|
test "due_to_be_postponed scope works properly cross-account" do
|
|
cards(:logo).update!(last_active_at: entropies(:writebook_board).auto_postpone_period.seconds.ago - 2.days)
|
|
cards(:radio).update!(last_active_at: entropies(:miltons_wish_list_board).auto_postpone_period.seconds.ago - 2.days)
|
|
|
|
assert_equal(cards(:logo, :radio).to_set, Card.due_to_be_postponed.to_set)
|
|
end
|
|
|
|
test "postponing_soon scope works properly cross-account" do
|
|
cards(:logo).update!(last_active_at: entropies(:writebook_board).auto_postpone_period.seconds.ago + 2.days)
|
|
cards(:radio).update!(last_active_at: entropies(:miltons_wish_list_board).auto_postpone_period.seconds.ago + 2.days)
|
|
|
|
assert_equal(cards(:logo, :radio).to_set, Card.postponing_soon.to_set)
|
|
end
|
|
end
|