Kevin McConnell
23fe40fa81
The `ipaddr` arg here is being interpreted as a positional arg (since the keyword arg doesn't exist), which results in an invalid connection object. This was causing push notifications to silently fail. We should initialise the property on the object instead.
45 lines
1.2 KiB
Ruby
45 lines
1.2 KiB
Ruby
# Extends WebMock to support ipaddr matching for testing IP pinning.
|
|
#
|
|
# Usage:
|
|
# stub_request(:post, "https://example.com/push")
|
|
# .with(ipaddr: "93.184.216.34")
|
|
# .to_return(status: 201)
|
|
#
|
|
# If the HTTP connection's ipaddr doesn't match, the stub won't match and
|
|
# WebMock will raise an error about an unregistered request.
|
|
|
|
module WebMock
|
|
class RequestSignature
|
|
attr_accessor :ipaddr
|
|
end
|
|
|
|
module RequestPatternIpaddrExtension
|
|
attr_accessor :ipaddr_pattern
|
|
|
|
def assign_options(options)
|
|
options = options.dup
|
|
@ipaddr_pattern = options.delete(:ipaddr) || options.delete("ipaddr")
|
|
super(options)
|
|
end
|
|
|
|
def matches?(request_signature)
|
|
super && ipaddr_matches?(request_signature)
|
|
end
|
|
|
|
private
|
|
def ipaddr_matches?(request_signature)
|
|
@ipaddr_pattern.nil? || @ipaddr_pattern == request_signature.ipaddr
|
|
end
|
|
end
|
|
|
|
RequestPattern.prepend RequestPatternIpaddrExtension
|
|
|
|
module NetHTTPUtilityIpaddrExtension
|
|
def request_signature_from_request(net_http, request, body = nil)
|
|
super.tap { |signature| signature.ipaddr = net_http.ipaddr }
|
|
end
|
|
end
|
|
|
|
NetHTTPUtility.singleton_class.prepend NetHTTPUtilityIpaddrExtension
|
|
end
|