Rosa Gutierrez
60b3c9c772
Event notifiers used the `mentionees` DB association to exclude mentioned users from comment/card notifications. Since mentions are created async via Mention::CreateJob, a race condition meant the mentionee list could be empty when the event notification job ran first, causing the user to receive both a comment and a mention push notification. Use `scan_mentionees` instead, which scans the rich text body directly for mentioned users without depending on Mention records existing yet. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
125 lines
4.1 KiB
Ruby
125 lines
4.1 KiB
Ruby
require "test_helper"
|
|
|
|
class Notifier::EventNotifierTest < ActiveSupport::TestCase
|
|
test "for returns the matching notifier class for the event" do
|
|
assert_kind_of Notifier::CardEventNotifier, Notifier.for(events(:logo_published))
|
|
end
|
|
|
|
test "generate does not create notifications if the event was system-generated" do
|
|
cards(:logo).drafted!
|
|
events(:logo_published).update!(creator: accounts("37s").system_user)
|
|
|
|
assert_no_difference -> { Notification.count } do
|
|
Notifier.for(events(:logo_published)).notify
|
|
end
|
|
end
|
|
|
|
test "creates a notification for each watcher, other than the event creator (events)" do
|
|
notifications = Notifier.for(events(:layout_commented)).notify
|
|
|
|
assert_equal [ users(:kevin) ], notifications.map(&:user)
|
|
end
|
|
|
|
test "creates a notification for each watcher (mentions)" do
|
|
notifications = Notifier.for(events(:layout_commented)).notify
|
|
|
|
assert_equal [ users(:kevin) ], notifications.map(&:user)
|
|
end
|
|
|
|
test "does not create a notification for access-only users" do
|
|
boards(:writebook).access_for(users(:kevin)).access_only!
|
|
|
|
notifications = Notifier.for(events(:layout_commented)).notify
|
|
|
|
assert_equal [ users(:kevin) ], notifications.map(&:user)
|
|
end
|
|
|
|
test "links to the card" do
|
|
boards(:writebook).access_for(users(:kevin)).watching!
|
|
|
|
Notifier.for(events(:logo_published)).notify
|
|
|
|
assert_equal cards(:logo), Notification.last.source.eventable
|
|
end
|
|
|
|
test "assignment events only create a notification for the assignee" do
|
|
boards(:writebook).access_for(users(:jz)).watching!
|
|
boards(:writebook).access_for(users(:kevin)).watching!
|
|
|
|
notifications = Notifier.for(events(:logo_assignment_jz)).notify
|
|
|
|
assert_equal [ users(:jz) ], notifications.map(&:user)
|
|
end
|
|
|
|
test "assignment events do not notify users who are access-only for the board" do
|
|
boards(:writebook).access_for(users(:jz)).watching!
|
|
events(:logo_assignment_jz).update! creator: users(:jz)
|
|
|
|
notifications = Notifier.for(events(:logo_assignment_jz)).notify
|
|
|
|
assert_empty notifications
|
|
end
|
|
|
|
test "assignment events do not notify you if you assigned yourself" do
|
|
boards(:writebook).access_for(users(:david)).watching!
|
|
|
|
notifications = Notifier.for(events(:logo_assignment_david)).notify
|
|
|
|
assert_empty notifications
|
|
end
|
|
|
|
test "create notifications on publish for mentionees" do
|
|
users(:kevin).mentioned_by(users(:david), at: cards(:logo))
|
|
|
|
notifications = Notifier.for(events(:logo_published)).notify
|
|
|
|
assert_includes notifications.map(&:user), users(:kevin)
|
|
end
|
|
|
|
test "create notifications on publish for mentionees that are not watching" do
|
|
users(:kevin).mentioned_by(users(:david), at: cards(:logo))
|
|
cards(:logo).unwatch_by(users(:kevin))
|
|
|
|
notifications = Notifier.for(events(:logo_published)).notify
|
|
|
|
assert_includes notifications.map(&:user), users(:kevin)
|
|
end
|
|
|
|
test "don't create notifications on comment for mentionees" do
|
|
users(:david).mentioned_by(users(:kevin), at: cards(:layout))
|
|
|
|
assert_no_difference -> { users(:david).notifications.count } do
|
|
Notifier.for(events(:layout_commented)).notify
|
|
end
|
|
end
|
|
|
|
test "don't create notifications on comment for mentionees even before mention records exist" do
|
|
comment = cards(:layout).comments.create!(
|
|
body: "Hey #{mention_html_for(users(:kevin))}, what do you think?",
|
|
creator: users(:david)
|
|
)
|
|
event = boards(:writebook).events.create!(
|
|
action: "comment_created", creator: users(:david), eventable: comment
|
|
)
|
|
|
|
assert_empty comment.mentionees, "Mention records should not exist yet"
|
|
|
|
notifications = Notifier.for(event).notify
|
|
|
|
assert_not_includes notifications.map(&:user), users(:kevin)
|
|
end
|
|
|
|
test "assignment events notify assignees regardless of involvement level" do
|
|
boards(:writebook).access_for(users(:jz)).access_only!
|
|
|
|
notifications = Notifier.for(events(:logo_assignment_jz)).notify
|
|
|
|
assert_equal [ users(:jz) ], notifications.map(&:user)
|
|
end
|
|
|
|
private
|
|
def mention_html_for(user)
|
|
ActionText::Attachment.from_attachable(user).to_html
|
|
end
|
|
end
|