b6edb93c47
This makes it way more difficult to brute-force a magic link. Original implementation by udiudi. Ref: https://github.com/udiudi/fizzy/pull/1/files Discussion: https://github.com/basecamp/fizzy/discussions/1981 Co-Authored-By: Udi <udi@udi.codes>
75 lines
2.4 KiB
Ruby
75 lines
2.4 KiB
Ruby
require "test_helper"
|
|
|
|
class Sessions::MagicLinksControllerTest < ActionDispatch::IntegrationTest
|
|
test "show" do
|
|
untenanted do
|
|
get session_magic_link_url
|
|
|
|
assert_response :success
|
|
end
|
|
end
|
|
|
|
test "create with sign in code" do
|
|
identity = identities(:kevin)
|
|
magic_link = MagicLink.create!(identity: identity)
|
|
|
|
untenanted do
|
|
post session_path, params: { email_address: identity.email_address }
|
|
post session_magic_link_url, params: { code: magic_link.code }
|
|
|
|
assert_response :redirect
|
|
assert cookies[:session_token].present?
|
|
assert_redirected_to landing_path, "Should redirect to after authentication path"
|
|
assert_not MagicLink.exists?(magic_link.id), "The magic link should be consumed"
|
|
end
|
|
end
|
|
|
|
test "create with sign up code" do
|
|
identity = identities(:kevin)
|
|
magic_link = MagicLink.create!(identity: identity, purpose: :sign_up)
|
|
|
|
untenanted do
|
|
post session_path, params: { email_address: identity.email_address }
|
|
post session_magic_link_url, params: { code: magic_link.code }
|
|
|
|
assert_response :redirect
|
|
assert cookies[:session_token].present?
|
|
assert_redirected_to new_signup_completion_path, "Should redirect to signup completion"
|
|
assert_not MagicLink.exists?(magic_link.id), "The magic link should be consumed"
|
|
end
|
|
end
|
|
|
|
test "create with cross-user code" do
|
|
identity = identities(:kevin)
|
|
other_identity = identities(:jason)
|
|
magic_link = MagicLink.create!(identity: other_identity)
|
|
|
|
untenanted do
|
|
post session_path, params: { email_address: identity.email_address }
|
|
post session_magic_link_url, params: { code: magic_link.code }
|
|
|
|
assert_redirected_to new_session_path
|
|
assert_not cookies[:session_token].present?
|
|
end
|
|
end
|
|
|
|
test "create with invalid code" do
|
|
identity = identities(:kevin)
|
|
magic_link = MagicLink.create!(identity: identity)
|
|
|
|
untenanted do
|
|
post session_magic_link_url, params: { code: "INVALID" }
|
|
end
|
|
|
|
assert_response :redirect, "Invalid code should redirect"
|
|
|
|
expired_link = MagicLink.create!(identity: identity)
|
|
expired_link.update_column(:expires_at, 1.hour.ago)
|
|
|
|
post session_magic_link_url, params: { code: expired_link.code }
|
|
|
|
assert_response :redirect, "Expired magic link should redirect"
|
|
assert MagicLink.exists?(expired_link.id), "Expired magic link should not be consumed"
|
|
end
|
|
end
|