Rob Zolkos
23ac76555b
* Validate and normalize auto-postpone period to days - Add Entropy::AUTO_POSTPONE_PERIODS and validate auto_postpone_period against the allowed set - Introduce auto_postpone_period_in_days for forms and entropy update endpoints - Fall back to index 0 in knob partial when current value isn't in options - Remove entropy_auto_close_options helper in favor of model constant - Update tests to use allowed period values * Use auto_postpone_period_in_days for JSON entropy updates The JSON API was accepting auto_postpone_period (seconds) which bypassed the days normalization and validation. Switch to auto_postpone_period_in_days consistently and add explicit wrap_parameters so flat JSON params are wrapped correctly for the virtual attribute. * Default to account or 30-day fallback when knob value is invalid * Address PR review feedback for entropy validation - Fall back to first knob option (index 0) when persisted value isn't in the allowed set, preventing nil index errors for legacy values - Use integer division (1.day.to_i) for consistent day calculations * Default to account entropy period instead of first option for knob fallback * Test that default auto-postpone period is in the allowed periods * Return 422 instead of 500 for invalid entropy auto-postpone values Rescue ActiveRecord::RecordInvalid in entropy controllers so invalid auto_postpone_period_in_days values return 422 Unprocessable Entity instead of raising a 500. * Fix NoMethodError when board entropy falls back to account default Use container.account.entropy.auto_postpone_period_in_days instead of container.account.auto_postpone_period_in_days since Account doesn't delegate that method. * Test board entropy fallback to account default for invalid periods
29 lines
1021 B
Ruby
29 lines
1021 B
Ruby
require "test_helper"
|
|
|
|
class Entropy::Test < ActiveSupport::TestCase
|
|
test "touch cards when entropy changes for board" do
|
|
assert_changes -> { boards(:writebook).cards.first.updated_at } do
|
|
boards(:writebook).entropy.update!(auto_postpone_period: 7.days)
|
|
end
|
|
end
|
|
|
|
test "default auto-postpone period is included in allowed periods" do
|
|
assert_includes Entropy::AUTO_POSTPONE_PERIODS_IN_DAYS, Entropy::DEFAULT_AUTO_POSTPONE_PERIOD_IN_DAYS
|
|
end
|
|
|
|
test "board entropy falls back to account entropy period when value is invalid" do
|
|
board = boards(:writebook)
|
|
board.entropy.update_column(:auto_postpone_period, 999.days.to_i)
|
|
|
|
assert_equal Current.account.entropy.auto_postpone_period_in_days, board.entropy.auto_postpone_period_in_days
|
|
end
|
|
|
|
test "touch cards when entropy changes for account container" do
|
|
account = Current.account
|
|
|
|
assert_changes -> { account.cards.first.updated_at } do
|
|
boards(:writebook).entropy.update!(auto_postpone_period: 7.days)
|
|
end
|
|
end
|
|
end
|