Jeremy Daer
a52b6f1c87
* Add explicit wrap_parameters to controllers for flat JSON API support Virtual attributes (has_rich_text, has_one_attached, delegated setters, ActiveModel attrs) are not in Model.attribute_names, so wrap_parameters auto-detection silently drops them from flat JSON requests. Add explicit include: lists matching each controller's permitted params. * Convert short-form wrap_parameters to explicit include: lists Defense-in-depth: these controllers only have real-column params today, so auto-detection works, but explicit lists prevent future regressions if virtual attributes are added. * Add flat JSON param tests for all wrap_parameters controllers 17 new tests covering every controller with wrap_parameters, verifying that flat (unwrapped) JSON payloads are correctly wrapped and processed. Focuses on virtual attributes that would be silently dropped without explicit include: lists.
74 lines
1.7 KiB
Ruby
74 lines
1.7 KiB
Ruby
class CardsController < ApplicationController
|
|
wrap_parameters :card, include: %i[ title description image created_at last_active_at ]
|
|
|
|
include FilterScoped
|
|
|
|
before_action :set_board, only: %i[ create ]
|
|
before_action :set_card, only: %i[ show edit update destroy ]
|
|
before_action :redirect_if_drafted, only: :show
|
|
before_action :ensure_permission_to_administer_card, only: %i[ destroy ]
|
|
|
|
def index
|
|
set_page_and_extract_portion_from @filter.cards
|
|
end
|
|
|
|
def create
|
|
respond_to do |format|
|
|
format.html do
|
|
card = Current.user.draft_new_card_in(@board)
|
|
redirect_to card_draft_path(card)
|
|
end
|
|
|
|
format.json do
|
|
@card = @board.cards.create! card_params.merge(creator: Current.user, status: "published")
|
|
render :show, status: :created, location: card_path(@card, format: :json)
|
|
end
|
|
end
|
|
end
|
|
|
|
def show
|
|
end
|
|
|
|
def edit
|
|
end
|
|
|
|
def update
|
|
@card.update! card_params
|
|
|
|
respond_to do |format|
|
|
format.turbo_stream
|
|
format.json { render :show }
|
|
end
|
|
end
|
|
|
|
def destroy
|
|
@card.destroy!
|
|
|
|
respond_to do |format|
|
|
format.html { redirect_to @card.board, notice: "Card deleted" }
|
|
format.json { head :no_content }
|
|
end
|
|
end
|
|
|
|
private
|
|
def set_board
|
|
@board = Current.user.boards.find params[:board_id]
|
|
end
|
|
|
|
def set_card
|
|
@card = Current.user.accessible_cards.find_by!(number: params[:id])
|
|
end
|
|
|
|
def redirect_if_drafted
|
|
redirect_to card_draft_path(@card) if @card.drafted?
|
|
end
|
|
|
|
def ensure_permission_to_administer_card
|
|
head :forbidden unless Current.user.can_administer_card?(@card)
|
|
end
|
|
|
|
def card_params
|
|
params.expect(card: [ :title, :description, :image, :created_at, :last_active_at ])
|
|
end
|
|
end
|