From 02df03282e27095d4c75dfe0fb68f5661c6d6dbb Mon Sep 17 00:00:00 2001
From: BenClaw <benclaw@mozo.bar>
Date: Sun, 17 May 2026 20:12:22 +0200
Subject: [PATCH] Revert "fix(broadcasting): broadcast on mark_helped! even
 when already false"

This reverts commit 4ad701c1a5015cf305301f1ad02f6a61467110f6.
---
 app/models/list.rb | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/app/models/list.rb b/app/models/list.rb
index ca3dfc92..77777155 100644
--- a/app/models/list.rb
+++ b/app/models/list.rb
@@ -236,21 +236,23 @@ class List
 
   def mark_helped!
     self.needs_help = false
-    save
-    broadcast_users 'list_helped', id: id
-    broadcast_supplier supplier_id, 'list_helped', id: id
+    if save
+      broadcast_users 'list_helped', id: id
+      broadcast_supplier supplier_id, 'list_helped', id: id
+    end
   end
 
   def remove_needs_payment!
     self.needs_payment = false
-    save
-    broadcast_users 'remove_list_needs_payment', id: id
-    broadcast_supplier supplier_id, 'remove_list_needs_payment', id: id
+    if save
+      broadcast_users 'remove_list_needs_payment', id: id
+      broadcast_supplier supplier_id, 'remove_list_needs_payment', id: id
+    end
   end
 
   def needs_payment!
     self.needs_payment = true
-    save
+    if save
       broadcast_users 'list_needs_payment', id: id
       broadcast_supplier supplier_id, 'list_needs_payment', id: id
     end