Store: fail loudly on untranslatable views; quoting hardening; true batched bulk KV
- database.view now raises SimplyBased::UnsupportedView when a declared view carries CouchDB-era options the N1QL translation silently ignored before: :conditions (a JS fragment) and :emit_value, plus CouchDB list functions. Silently dropping :conditions was the worst of these — a 'view :completed, key: :name, conditions: ...' query returned *unfiltered* results with no hint anything was wrong. Covered by unsupported_view_spec. - All column/property names interpolated into N1QL are now routed through quote_ident, which rejects backticks/backslashes. These names come from the model DSL rather than user input, but a smuggled backtick must never become query text. Class names in index predicates go through a proper string literal quoting helper for the same reason. - ensure_index: failures are still swallowed (an index build in progress must not take down queries) but now emit a warning naming the index, because the silent version left every subsequent query on a primary-index scan with no trace. The ensured-indexes bookkeeping is mutex-guarded for multithreaded servers (Puma). - bulk_load / bulk_destroy now actually batch (collection.get_multi / remove_multi — one KV round trip). The README already advertised 'bulk (batched KV)' but the code looped one get/remove per id. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
1 parent
1beb8ead11
commit
84c76bb093
3 files changed
+130
-30
No files matched your search
@@ -21,6 +21,10 @@ unless defined?(SimplyBased::VERSION)
|
||||
class NotImplementedError < RuntimeError; end
|
||||
class ModelNotInstantiatedError < RuntimeError; end
|
||||
class NotFound < RuntimeError; end
|
||||
# Raised when a declared view carries options the N1QL translation cannot
|
||||
# honour (e.g. :conditions / :emit_value / list functions). Failing loudly
|
||||
# beats silently returning unfiltered results.
|
||||
class UnsupportedView < Error; end
|
||||
|
||||
# No-op retained for source compatibility with SimplyCouch. SimplyBased
|
||||
# never interpolates values into JavaScript views — queries are N1QL with
|
||||
|
||||
Reference in new issue
Block a user