Stop caching threads — YAGNI

Gemfile

@@ -8,7 +8,6 @@ gem "importmap-rails"
 gem "propshaft"
 gem "stimulus-rails"
 gem "turbo-rails"
-gem "local_time"
 
 # Deployment and drivers
 gem "bootsnap", require: false

Gemfile.lock

@@ -145,7 +145,6 @@ GEM
       reline (>= 0.4.2)
     json (2.7.2)
     language_server-protocol (3.17.0.3)
-    local_time (3.0.2)
     logger (1.6.1)
     loofah (2.22.0)
       crass (~> 1.0.2)
@@ -327,7 +326,6 @@ DEPENDENCIES
   capybara
   debug
   importmap-rails
-  local_time
   propshaft
   puma (>= 5.0)
   rails!

app/javascript/application.js

@@ -1,4 +1,3 @@
 // Configure your import map in config/importmap.rb. Read more: https://github.com/rails/importmap-rails
 import "@hotwired/turbo-rails"
-import "initializers"
 import "controllers"

app/javascript/controllers/animation_controller.js

@@ -1,5 +1,5 @@
 import { Controller } from "@hotwired/stimulus"
-import { nextFrame } from "helpers"
+import { nextFrame } from "helpers/timing_helpers"
 
 export default class extends Controller {
   static classes = [ "play" ]

app/javascript/controllers/filter_controller.js

@@ -1,5 +1,5 @@
 import { Controller } from "@hotwired/stimulus"
-import { debounce } from "helpers"
+import { debounce } from "helpers/timing_helpers"
 
 export default class extends Controller {
   static targets = [ "list" ]

app/javascript/controllers/thread_controller.js

@@ -1,13 +0,0 @@
-import { Controller } from "@hotwired/stimulus"
-
-export default class extends Controller {
-  static classes = [ "myComment" ]
-
-  connect() {
-    this.#myComments.forEach(comment => comment.classList.add(this.myCommentClass))
-  }
-
-  get #myComments() {
-    return this.element.querySelectorAll(`.comment[data-creator-id='${Current.user.id}']`)
-  }
-}

app/javascript/helpers/index.js

@@ -1 +0,0 @@
-export * from "helpers/timing_helpers"

app/javascript/initializers/current.js

@@ -1,15 +0,0 @@
-class Current {
-  get user() {
-    const currentUserId = this.#extractContentFromMetaTag("current-user-id")
-
-    if (currentUserId) {
-      return { id: parseInt(currentUserId) }
-    }
-  }
-
-  #extractContentFromMetaTag(name) {
-    return document.head.querySelector(`meta[name="${name}"]`)?.getAttribute("content")
-  }
-}
-
-window.Current = new Current()

app/javascript/initializers/index.js

@@ -1,2 +0,0 @@
-import "initializers/current"
-import "initializers/local_time"

app/javascript/initializers/local_time.js

@@ -1,2 +0,0 @@
-import LocalTime from "local-time"
-LocalTime.start()

app/models/bubble/thread.rb

@@ -13,10 +13,6 @@ class Bubble::Thread
     "bubbles/threads/thread"
   end
 
-  def cache_key
-    ActiveSupport::Cache.expand_cache_key bubble, :thread
-  end
-
   private
     delegate :events, :comments, to: :bubble, private: true
 

app/models/bubble/thread/rollup.rb

@@ -13,14 +13,10 @@ class Bubble::Thread::Rollup
     "bubbles/threads/rollup"
   end
 
-  def cache_key
-    ActiveSupport::Cache.expand_cache_key [ thread, entries.first, entries.last ], "rollup"
-  end
-
   private
     attr_reader :thread, :entries, :first_position
 
-    delegate :local_time_ago, to: "ApplicationController.helpers", private: true
+    delegate :time_ago_in_words, to: "ApplicationController.helpers", private: true
 
     def first_position?
       first_position
@@ -47,10 +43,10 @@ class Bubble::Thread::Rollup
     def summarize(entry, chunk_size)
       case entry.action
       when "created"
-        "added by #{entry.creator.name} #{local_time_ago(entry.created_at)}"
+        "added by #{entry.creator.name} #{time_ago_in_words(entry.created_at)} ago"
       when "assigned"
         summary = "assigned to #{entry.assignee_names.to_sentence}"
-        summary += " #{local_time_ago(entry.created_at)}" unless first_position?
+        summary += " #{time_ago_in_words(entry.created_at)} ago" unless first_position?
         summary
       when "boosted"
         "#{entry.creator.name} +#{chunk_size}"

app/views/bubbles/threads/_entry.html.erb

@@ -1,3 +0,0 @@
-<%# Template Dependency: comments/comment %>
-<%# Template Dependency: bubbles/threads/rollup %>
-<%= render entry %>

app/views/bubbles/threads/_rollup.html.erb

@@ -1,3 +1,3 @@
 <div class="comment--upvotes flex-inline flex-wrap align-start fill-white border-radius center position-relative">
-  <%= rollup.body.html_safe %>
+  <%= rollup.body %>
 </div>

app/views/bubbles/threads/_thread.html.erb

@@ -1,13 +1,6 @@
 <% bubble = thread.bubble %>
 
-<section id="<%= dom_id(bubble, :thread) %>"
-  class="comments align-center center borderless margin flex flex-column gap-half"
-  style="--bubble-color: <%= bubble.color %>;"
-  data-controller="thread"
-  data-thread-my-comment-class="comment--mine">
-  <% cache thread do %>
-    <%= render partial: "bubbles/threads/entry", collection: thread.entries, cache: true %>
-  <% end %>
-
+<section id="<%= dom_id(bubble, :thread) %>" class="comments align-center center borderless margin flex flex-column gap-half" style="--bubble-color: <%= bubble.color %>;">
+  <%= render thread.entries %>
   <%= render "comments/new", bubble: bubble %>
 </section>

app/views/comments/_comment.html.erb

@@ -1,4 +1,4 @@
-<div id="<%= dom_id(comment) %>" class="comment flex align-start full-width" data-creator-id="<%= comment.creator.id %>">
+<%= tag.div id: dom_id(comment), class: [ "comment flex align-start full-width", { "comment--mine": Current.user == comment.creator } ] do %>
   <figure class="comment__avatar flex-item-no-shrink">
     <%= avatar_tag comment.creator, loading: :lazy %>
   </figure>
@@ -16,4 +16,4 @@
       <%= simple_format comment.body %>
     </div>
   </div>
-</div>
+<% end %>

app/views/layouts/application.html.erb

@@ -9,10 +9,6 @@
     <%= csrf_meta_tags %>
     <%= csp_meta_tag %>
 
-    <% if Current.user %>
-      <meta name="current-user-id" content="<%= Current.user.id %>">
-    <% end %>
-
     <%= yield :head %>
 
     <%= stylesheet_link_tag :all, "data-turbo-track": "reload" %>

config/importmap.rb

@@ -4,8 +4,6 @@ pin "application"
 pin "@hotwired/turbo-rails", to: "turbo.min.js"
 pin "@hotwired/stimulus", to: "stimulus.min.js"
 pin "@hotwired/stimulus-loading", to: "stimulus-loading.js"
-pin "local-time" # @3.0.2
 
-pin_all_from "app/javascript/initializers", under: "initializers"
 pin_all_from "app/javascript/controllers", under: "controllers"
 pin_all_from "app/javascript/helpers", under: "helpers"