Merge pull request #2482 from basecamp/omit-inactive-users-from-mentions

Omit inactive users from board mention picker

app/controllers/prompts/boards/users_controller.rb

@@ -2,7 +2,7 @@ class Prompts::Boards::UsersController < ApplicationController
   include BoardScoped
 
   def index
-    @users = @board.users.alphabetically
+    @users = @board.users.active.alphabetically
 
     if stale? etag: @users
       render layout: false

test/controllers/prompts/boards/users_controller_test.rb

@@ -11,4 +11,16 @@ class Prompts::Boards::UsersControllerTest < ActionDispatch::IntegrationTest
     assert_response :success
     assert_select "lexxy-prompt-item", count: 3
   end
+
+  test "index excludes inactive users" do
+    get prompts_board_users_path(@board)
+    assert_response :success
+    assert_select "lexxy-prompt-item[search*='David']", count: 1
+
+    users(:david).update!(active: false)
+
+    get prompts_board_users_path(@board)
+    assert_response :success
+    assert_select "lexxy-prompt-item[search*='David']", count: 0
+  end
 end