bterkuile/fizzy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

It is both reacting and reactions

Browse Source 
So stick with the simpler dom id scope
This commit is contained in:
David Heinemeier Hansson
2025-04-11 18:10:26 +02:00
parent 73f1989861
commit 227d5a8757
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/views/cards/comments/reactions/_reactions.html.erb
+1 -1
View File
@@ -1,4 +1,4 @@
<%= turbo_frame_tag comment, :reacting do %>
<%= turbo_frame_tag comment, :reactions do %>
<div class="reactions flex flex-wrap align-center gap full-width">
<div class="flex-inline flex-wrap gap">
<%= render partial: "cards/comments/reactions/reaction", collection: comment.reactions.ordered, locals: { comment: comment } %>
app/views/cards/comments/reactions/new.html.erb
+1 -1
View File
@@ -2,7 +2,7 @@
<%= form_with url: card_comment_reactions_path(@comment.card, @comment),
class: "reaction reaction__form flex-inline postion--relative max-width align-center fill-white gap expanded",
html: { aria: { label: "New reaction" } },
data: { controller: "form", turbo_frame: dom_id(@comment, :reacting), action: "keydown.esc->form#cancel" } do |form| %>
data: { controller: "form", turbo_frame: dom_id(@comment, :reactions), action: "keydown.esc->form#cancel" } do |form| %>
<label class="reaction__form-label flex gap" style="--column-gap: 0.7ch;">
<figure class="reaction__avatar margin-none flex-item-no-shrink">
<%= avatar_tag Current.user %>