bterkuile/fizzy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix double _seconds suffix in GVL request wait metric name (#2539)

Browse Source 
Rename histogram from :request_wait_seconds to :request_wait so Yabeda's
unit: :seconds produces gvl_request_wait_seconds instead of
gvl_request_wait_seconds_seconds.
This commit is contained in:
Jeremy Daer
2026-02-12 16:41:20 -08:00
committed by GitHub
parent a5a5a62169
commit 231db6e742
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
saas/lib/fizzy/saas/gvl_instrumentation.rb
+1 -1
View File
@@ -10,7 +10,7 @@ module Fizzy
before = GVLTools::LocalTimer.monotonic_time
result = @app.call(env)
gvl_wait_ns = GVLTools::LocalTimer.monotonic_time - before
Yabeda.gvl.request_wait_seconds.measure({}, gvl_wait_ns / 1_000_000_000.0)
Yabeda.gvl.request_wait.measure({}, gvl_wait_ns / 1_000_000_000.0)
result
ensure
GVLTools::LocalTimer.disable
saas/lib/yabeda/gvl.rb
+1 -1
View File
@@ -14,7 +14,7 @@ module Yabeda
gauge :global_timer_total_seconds,
comment: "Total time all threads spent waiting on the GVL (seconds)"
histogram :request_wait_seconds,
histogram :request_wait,
unit: :seconds,
comment: "GVL wait time experienced during a single request (seconds)",
buckets: WAIT_HISTOGRAM_BUCKETS