bterkuile/fizzy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixes for multi selection

Browse Source
This commit is contained in:
Jorge Manrubia
2025-09-18 18:44:15 +02:00
parent 81cae9cbe0
commit 2d575737b5
7 changed files with 12 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/javascript/controllers/combobox_controller.js
+1 -3
View File
@@ -24,13 +24,11 @@ export default class extends Controller {
get #selectedLabel() {
const selectedValue = this.#selectedItemValue()
console.debug("Es ", this.defaultValueValue);
if (this.hasDefaultLabelValue && (selectedValue === this.defaultValueValue || !selectedValue)) {
return this.defaultLabelValue
}
console.debug("EIN", this.#selectedItem);
return this.#selectedItem?.dataset?.comboboxLabel || ""
}
app/javascript/controllers/filter_settings_controller.js
+3 -2
View File
@@ -26,11 +26,12 @@ export default class extends Controller {
if (!value) return false
const defaultValue = this.#defaultValueForField(field)
console.debug("defaultValue", defaultValue);
return defaultValue ? value !== defaultValue : true
}
#defaultValueForField(field) {
const comboboxContainer = field.closest("[data-combobox-default-value]")
return comboboxContainer?.dataset?.comboboxDefaultValue
const comboboxContainer = field.closest("[data-combobox-default-value-value]")
return comboboxContainer?.dataset?.comboboxDefaultValueValue
}
}
app/views/filters/settings/_assignees.html.erb
+1 -1
View File
@@ -1,7 +1,7 @@
<% filter = user_filtering.filter %>
<%= tag.div class: "quick-filter position-relative",
data: {
controller: "dialog multi-selection-combobox form",
controller: "dialog multi-selection-combobox",
action: "keydown.esc->dialog#close click@document->dialog#closeOnClickOutside",
filter_show: user_filtering.show_assignees?,
multi_selection_combobox_no_selection_label_value: "Assigned to…" } do %>
app/views/filters/settings/_closers.html.erb
+1 -1
View File
@@ -2,7 +2,7 @@
<%= tag.div class: "quick-filter position-relative",
data: {
controller: "dialog multi-selection-combobox form",
controller: "dialog multi-selection-combobox",
action: "keydown.esc->dialog#close click@document->dialog#closeOnClickOutside",
filter_show: user_filtering.show_closers?,
multi_selection_combobox_no_selection_label_value: "Closed by…" } do %>
app/views/filters/settings/_controls.html.erb
+4 -4
View File
@@ -3,8 +3,8 @@
<%= hidden_field_tag :expand_all, true, disabled: !user_filtering.expanded?, data: { toggle_enable_target: "element" } %>
<%= render "filters/settings/sorted_by", user_filtering: user_filtering %>
<%= render "filters/settings/indexed_by", user_filtering: user_filtering %>
<%#= render "filters/settings/tags", user_filtering: user_filtering %>
<%#= render "filters/settings/assignees", user_filtering: user_filtering %>
<%#= render "filters/settings/creators", user_filtering: user_filtering %>
<%#= render "filters/settings/closers", user_filtering: user_filtering %>
<%= render "filters/settings/tags", user_filtering: user_filtering %>
<%= render "filters/settings/assignees", user_filtering: user_filtering %>
<%= render "filters/settings/creators", user_filtering: user_filtering %>
<%= render "filters/settings/closers", user_filtering: user_filtering %>
<% end %>
app/views/filters/settings/_creators.html.erb
+1 -1
View File
@@ -2,7 +2,7 @@
<%= tag.div class: "quick-filter position-relative",
data: {
controller: "dialog multi-selection-combobox form",
controller: "dialog multi-selection-combobox",
action: "keydown.esc->dialog#close click@document->dialog#closeOnClickOutside",
filter_show: user_filtering.show_creators?,
multi_selection_combobox_no_selection_label_value: "Added by…" } do %>
app/views/filters/settings/_indexed_by.html.erb
+1 -1
View File
@@ -1,7 +1,7 @@
<% filter = user_filtering.filter %>
<%= tag.div class: class_names("quick-filter position-relative"),
data: { controller: "dialog combobox form",
data: { controller: "dialog combobox",
action: "keydown.esc->dialog#close click@document->dialog#closeOnClickOutside",
filter_show: user_filtering.show_indexed_by?,
turbo_action: "advance",