Address HTML markup issues reported by Herb

This commit is contained in:
Marco Roth
2025-12-02 17:21:35 +01:00
parent 60e7e9ffd8
commit 2f88908cdf
4 changed files with 6 additions and 5 deletions
+1 -1
View File
@@ -2,7 +2,7 @@
<div class="panel panel--centered">
<%= form_with model: @board, class: "flex flex-column gap", data: { controller: "form" } do |form| %>
<h1 class="txt-x-large margin-none font-weight-black"><%= @page_title %></h2>
<h1 class="txt-x-large margin-none font-weight-black"><%= @page_title %></h1>
<%= form.text_field :name, required: true, class: "input full-width", autofocus: true, autocomplete: "off",placeholder: "Name it…", data: { action: "keydown.esc@document->form#cancel" } %>
<button type="submit" class="btn btn--link center">
@@ -37,6 +37,6 @@
<% if card.entropic? %>
<%= render "cards/display/preview/bubble", card: card %>
<span class="card__board-name">
<span class="card__board-name"></span>
<% end %>
<% end %>
+1
View File
@@ -21,5 +21,6 @@
<footer id="footer">
<%= yield :footer %>
</footer>
</body>
</html>
+3 -3
View File
@@ -12,7 +12,7 @@
<%= icon_tag "pencil" %>
<span class="for-screen-reader">Edit</span>
<% end %>
<div>
</div>
<% end %>
<div class="panel panel--wide shadow center flex flex-column gap txt-align-start">
@@ -39,7 +39,7 @@
<div class="flex flex-column">
<h2 class="margin-none txt-uppercase txt-medium">Subscribed to</h2>
<% if @webhook.subscribed_actions.empty? %>
<p class="margin-none txt-subtle">This Webhook isn't subscribed to any events. It will never trigger.<p/>
<p class="margin-none txt-subtle">This Webhook isn't subscribed to any events. It will never trigger.</p>
<% else %>
<ul class="margin-none unpad-block">
<% @webhook.subscribed_actions.each do |action| %>
@@ -52,7 +52,7 @@
<div class="flex flex-column">
<h2 class="margin-none txt-uppercase txt-medium">Deliveries</h2>
<% if @webhook.deliveries.empty? %>
<p class="margin-none txt-subtle">This Webhook hasn't been triggered yet<p/>
<p class="margin-none txt-subtle">This Webhook hasn't been triggered yet</p>
<% else %>
<ul class="margin-none unpad-block">
<%= render partial: "webhooks/delivery", collection: @webhook.deliveries.ordered.limit(20), as: :delivery %>