Ensure avatars aren't tab-focusable when previewing

This commit is contained in:
Andy Smith
2025-08-12 15:12:48 -05:00
parent bdf3356e1b
commit 327f48bd4f
6 changed files with 6 additions and 6 deletions
+1 -1
View File
@@ -20,7 +20,7 @@ module AvatarsHelper
end
def avatar_preview_tag(user, hidden_for_screen_reader: false, **options)
tag.span class: "avatar",
tag.span class: class_names("avatar", options.delete(:class)),
aria: { hidden: hidden_for_screen_reader, label: user.name },
tabindex: hidden_for_screen_reader ? -1 : nil do
avatar_image_tag(user, **options)
@@ -1,6 +1,6 @@
<div class="display-contents" id="<%= dom_id(card, :assignees) %>">
<% card.assignees.each do |assignee| %>
<%= avatar_tag assignee %>
<%= avatar_tag assignee, tabindex: (local_assigns.key?(:preview) && local_assigns[:preview]) ? -1 : 0 %>
<% end %>
<div class="position-relative" data-controller="dialog" data-action="keydown.esc->dialog#close click@document->dialog#closeOnClickOutside" <%= "hidden" if card.closed? %>>
@@ -1,7 +1,7 @@
<div class="card__meta" id="<%= dom_id(card, :meta) %>">
<div class="card__meta-grid card__meta-grid--author">
<%= avatar_tag card.creator, class: "card__meta-author" %>
<%= avatar_tag card.creator, class: "card__meta-author", tabindex: (local_assigns.key?(:preview) && local_assigns[:preview]) ? -1 : 0 %>
<span class="card__meta-text card__meta-text--added overflow-ellipsis">
Added <%= local_datetime_tag(card.created_at, style: :daysago) %>
@@ -1 +1 @@
<%= render "cards/display/common/assignees", card: card %>
<%= render "cards/display/common/assignees", card: card, preview: true %>
@@ -1,3 +1,3 @@
<%= render "cards/display/common/meta", card: card do %>
<%= render "cards/display/common/meta", card: card, preview: true do %>
<%= render "cards/display/preview/assignees", card: card %>
<% end %>
@@ -1,3 +1,3 @@
<%= render "cards/display/common/people", card: card do%>
<%= render "cards/display/preview/assignees", card: card %>
<%= render "cards/display/preview/assignees", card: card, preview: true %>
<% end %>