Use script_name and url helpers

instead of string concatenation
2025-11-14 16:23:42 -05:00
parent 142a342e53
commit 3ed36004e4
1 changed files with 7 additions and 3 deletions
@@ -88,7 +88,7 @@ class NotificationPusher
      {
        title: "New notification",
        body: "You have a new notification",
-        path: "#{notification.account.slug}#{notifications_path}"
+        path: notifications_path(script_name: notification.account.slug)
      }
    end

@@ -110,10 +110,14 @@ class NotificationPusher
    end

    def card_path(card)
-      "#{notification.account.slug}#{Rails.application.routes.url_helpers.card_path(card)}"
+      Rails.application.routes.url_helpers.card_path(card, script_name: notification.account.slug)
    end

    def card_path_with_comment_anchor(comment)
-      "#{notification.account.slug}#{Rails.application.routes.url_helpers.card_path(comment.card, anchor: ActionView::RecordIdentifier.dom_id(comment))}"
+      Rails.application.routes.url_helpers.card_path(
+        comment.card,
+        anchor: ActionView::RecordIdentifier.dom_id(comment),
+        script_name: notification.account.slug
+      )
    end
 end