Simplify filter destruction
This commit is contained in:
@@ -1,5 +1,5 @@
|
||||
class FiltersController < ApplicationController
|
||||
before_action :set_filter, :remember_params, only: :destroy
|
||||
before_action :set_filter, only: :destroy
|
||||
|
||||
def create
|
||||
@filter = Current.user.filters.persist! filter_params
|
||||
@@ -16,10 +16,6 @@ class FiltersController < ApplicationController
|
||||
@filter = Current.user.filters.find params[:id]
|
||||
end
|
||||
|
||||
def remember_params
|
||||
@filter_params = @filter.to_params
|
||||
end
|
||||
|
||||
def filter_params
|
||||
params.permit(*Filter::KNOWN_PARAMS).compact_blank
|
||||
end
|
||||
@@ -28,7 +24,7 @@ class FiltersController < ApplicationController
|
||||
if request.referer == root_url
|
||||
redirect_to root_path
|
||||
else
|
||||
redirect_to bubbles_path(@filter_params)
|
||||
redirect_to bubbles_path(@filter.to_params)
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
@@ -25,10 +25,9 @@ class FiltersControllerTest < ActionDispatch::IntegrationTest
|
||||
end
|
||||
|
||||
test "destroy" do
|
||||
params = filters(:jz_assignments).to_params
|
||||
assert_difference "Filter.count", -1 do
|
||||
delete filter_url(filters(:jz_assignments))
|
||||
end
|
||||
assert_redirected_to bubbles_path(params)
|
||||
assert_redirected_to bubbles_path(filters(:jz_assignments).params)
|
||||
end
|
||||
end
|
||||
|
||||
Reference in New Issue
Block a user