bterkuile/fizzy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #1264 from basecamp/remove-problematic-caching

Browse Source 
Don't cache the whole stream column
This commit is contained in:
Jorge Manrubia
2025-10-08 12:20:15 +02:00
committed by GitHub
parent 509464778f 245823ad1c
commit 753cba1cd8
1 changed files with 20 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/views/collections/show/_stream.html.erb
+20 -23
View File
@@ -1,27 +1,24 @@
<% cache [ collection, page.records ] do %>
<section id="the-stream" class="cards cards--considering"
data-drag-and-drop-target="container"
data-action="turbo:before-morph-attribute->collapsible-columns#preventToggle"
data-drag-and-drop-url="<%= columns_card_drops_stream_path("__id__") %>">
<div class="cards__decoration"></div>
<section id="the-stream" class="cards cards--considering"
data-drag-and-drop-target="container"
data-action="turbo:before-morph-attribute->collapsible-columns#preventToggle"
data-drag-and-drop-url="<%= columns_card_drops_stream_path("__id__") %>">
<div class="cards__decoration"></div>
<header class="cards__expander">
<h2 class="cards__expander-title">The Stream</h2>
<%= link_to collection_columns_stream_path(collection), class: "btn btn--circle txt-x-small borderless cards__expander-button", data: { turbo_frame: "_top" } do %>
<%= icon_tag "expand", class: "translucent" %>
<span class="for-screen-reader">Expand column</span>
<% end %>
</header>
<%= render "columns/show/add_card_button", collection: collection %>
<% if page.used? %>
<%= with_automatic_pagination "the-stream", @page do %>
<%= render "collections/columns/list", cards: page.records, draggable: true %>
<% end %>
<header class="cards__expander">
<h2 class="cards__expander-title">The Stream</h2>
<%= link_to collection_columns_stream_path(collection), class: "btn btn--circle txt-x-small borderless cards__expander-button", data: { turbo_frame: "_top" } do %>
<%= icon_tag "expand", class: "translucent" %>
<span class="for-screen-reader">Expand column</span>
<% end %>
</header>
<div class="cards__decoration-end"></div>
</section>
<% end %>
<%= render "columns/show/add_card_button", collection: collection %>
<% if page.used? %>
<%= with_automatic_pagination "the-stream", @page do %>
<%= render "collections/columns/list", cards: page.records, draggable: true %>
<% end %>
<% end %>
<div class="cards__decoration-end"></div>
</section>