bterkuile/fizzy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Cache is going to churn too frequently to matter

Browse Source 
Anything that touches the bucket, and thats almost everything, will
churn the cache. This is already hidden behind a turbo frame, so thats
enough to get it out of the rendering hot path.
This commit is contained in:
David Heinemeier Hansson
2025-04-05 16:23:47 +02:00
parent 64c00aea30
commit 77f412f875
1 changed files with 11 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/views/bubbles/assignments/new.html.erb
+11 -13
View File
@@ -1,16 +1,14 @@
<% cache [ @bubble ] do %>
<%= turbo_frame_tag @bubble, :assignment do %>
<dialog class="popup panel flex-column align-start gap-half fill-white shadow" data-dialog-target="dialog">
<strong class="popup__title margin-block-start-half pad-inline-half txt-nowrap">Assign this to…</strong>
<%= turbo_frame_tag @bubble, :assignment do %>
<dialog class="popup panel flex-column align-start gap-half fill-white shadow" data-dialog-target="dialog">
<strong class="popup__title margin-block-start-half pad-inline-half txt-nowrap">Assign this to…</strong>
<%= form_with url: bubble_assignments_path(@bubble), class: "flex flex-column full-width popup__list", data: { controller: "form" } do |form| %>
<% @bubble.bucket.users.active.alphabetically.each do |user| %>
<div class="btn popup__item">
<%= bubble_assignee_checkbox(form, @bubble, user) %>
<%= icon_tag "check", size: 18, class: "checked flex-item-justify-end" %>
</div>
<% end %>
<%= form_with url: bubble_assignments_path(@bubble), class: "flex flex-column full-width popup__list", data: { controller: "form" } do |form| %>
<% @bubble.bucket.users.active.alphabetically.each do |user| %>
<div class="btn popup__item">
<%= bubble_assignee_checkbox(form, @bubble, user) %>
<%= icon_tag "check", size: 18, class: "checked flex-item-justify-end" %>
</div>
<% end %>
</dialog>
<% end %>
<% end %>
</dialog>
<% end %>