refactor: remove unused routes associated with "resource :account"

- Drop from 313 unused routes to 306 unused routes
- Use a namespace for the account-related resource routes
- Controllers are nested under the "Account" module now
- Move views from "accounts/" to "account/"

app/controllers/account/entropy_configurations_controller.rb

@@ -1,4 +1,4 @@
-class Accounts::EntropyConfigurationsController < ApplicationController
+class Account::EntropyConfigurationsController < ApplicationController
   def update
     Entropy::Configuration.default.update!(entropy_configuration_params)
 

app/controllers/account/join_codes_controller.rb

@@ -1,4 +1,4 @@
-class Accounts::JoinCodesController < ApplicationController
+class Account::JoinCodesController < ApplicationController
   def show
     render svg: RQRCode::QRCode.new(join_url(Account.sole.join_code)).as_svg(viewbox: true, fill: :white, color: :black)
   end

app/controllers/account/settings_controller.rb

@@ -1,4 +1,4 @@
-class Accounts::SettingsController < ApplicationController
+class Account::SettingsController < ApplicationController
   def show
     @account = Account.sole
     @users = User.active

app/views/account/settings/_users.html.erb

@@ -5,13 +5,13 @@
   navigable_list_actionable_items_value: true
 } do %>
   <h2 class="divider txt-large">People on the account</h2>
-  <%#= render "accounts/invite" # Scheduled work in https://3.basecamp.com/2914079/buckets/37331921/todos/8746162337 %>
+  <%#= render "account/invite" # Scheduled work in https://3.basecamp.com/2914079/buckets/37331921/todos/8746162337 %>
 
   <div class="settings__user-filter">
     <input placeholder="Filter…" class="input input--transparent full-width" type="search" autocorrect="off" autocomplete="off" data-1p-ignore="true" data-filter-target="input" data-action="input->filter#filter">
 
     <ul class="settings__user-list" data-filter-target="list">
-      <%= render partial: "accounts/user", collection: users %>
+      <%= render partial: "account/user", collection: users %>
     </ul>
 
     <footer class="settings__user-list-tips">

app/views/account/settings/show.html.erb

@@ -18,6 +18,6 @@
 <% end %>
 
 <section class="settings">
-  <%= render "accounts/settings/users", users: @users %>
-  <%= render "accounts/settings/entropy_configuration", account: @account %>
+  <%= render "account/settings/users", users: @users %>
+  <%= render "account/settings/entropy_configuration", account: @account %>
 </section>

config/routes.rb

@@ -1,11 +1,8 @@
 Rails.application.routes.draw do
-  resource :account do
-    resource :join_code, module: :accounts
-
-    scope module: :accounts do
-      resource :settings
-      resource :entropy_configuration
-    end
+  namespace :account do
+    resource :join_code
+    resource :settings
+    resource :entropy_configuration
   end
 
   resources :users do

test/controllers/accounts/entropy_configurations_controller_test.rb

@@ -1,6 +1,6 @@
 require "test_helper"
 
-class Accounts::EntropyConfigurationsControllerTest < ActionDispatch::IntegrationTest
+class Account::EntropyConfigurationsControllerTest < ActionDispatch::IntegrationTest
   setup do
     sign_in_as :kevin
   end

test/controllers/accounts/settings_controller_test.rb

@@ -1,6 +1,6 @@
 require "test_helper"
 
-class Accounts::SettingsControllerTest < ActionDispatch::IntegrationTest
+class Account::SettingsControllerTest < ActionDispatch::IntegrationTest
   setup do
     sign_in_as :kevin
   end

test/routes_test.rb

@@ -2,14 +2,14 @@ require "test_helper"
 
 class RouteTest < ActionDispatch::IntegrationTest
   test "account/join_code" do
-    assert_recognizes({ controller: "accounts/join_codes", action: "show" }, "/account/join_code")
+    assert_recognizes({ controller: "account/join_codes", action: "show" }, "/account/join_code")
   end
 
   test "account/settings" do
-    assert_recognizes({ controller: "accounts/settings", action: "show" }, "/account/settings")
+    assert_recognizes({ controller: "account/settings", action: "show" }, "/account/settings")
   end
 
   test "account/entropy_configuration" do
-    assert_recognizes({ controller: "accounts/entropy_configurations", action: "show" }, "/account/entropy_configuration")
+    assert_recognizes({ controller: "account/entropy_configurations", action: "show" }, "/account/entropy_configuration")
   end
 end