Merge pull request #1728 from basecamp/update-bundle-mailer

Make it clear this is just notifications, not comprehensive activity
This commit is contained in:
Jason Zimdars
2025-11-25 16:12:13 -06:00
committed by GitHub
4 changed files with 4 additions and 4 deletions
+1 -1
View File
@@ -11,6 +11,6 @@ class Notification::BundleMailer < ApplicationMailer
mail \
to: bundle.user.identity.email_address,
subject: "Fizzy#{ " (#{ Current.account.name })" if @user.identity.accounts.many? }: Latest Activity"
subject: "Fizzy#{ " (#{ Current.account.name })" if @user.identity.accounts.many? }: New notifications"
end
end
@@ -1,6 +1,6 @@
<tr>
<td>
<h1 class="title">Everything since <%= @bundle.starts_at.strftime("%-l%P on %A, %B %-d") %></h1>
<h1 class="title">Notifications since <%= @bundle.starts_at.strftime("%-l%P on %A, %B %-d") %></h1>
<p class="subtitle margin-block-end-double">
You have <%= link_to pluralize(@notifications.count, "new notification"), notifications_url %><%= " in #{ Current.account.name }" if @user.identity.accounts.many? %>.
</p>
@@ -1,4 +1,4 @@
Everything since <%= @bundle.starts_at.strftime("%-l%P on %A, %B %-d") %>
Notifications since <%= @bundle.starts_at.strftime("%-l%P on %A, %B %-d") %>
You have <%= pluralize @notifications.count, "new notification" %><%= " in #{ Current.account.name }" if @user.identity.accounts.many? %>.
<% @notifications.group_by(&:card).each do |card, notifications| %>
+1 -1
View File
@@ -142,7 +142,7 @@ class Notification::BundleTest < ActiveSupport::TestCase
assert_not_nil email
# Time in Madrid should be 15:30 (UTC+1 in winter)
assert_match /everything since 3pm/i, email.text_part&.body&.to_s
assert_match /notifications since 3pm/i, email.text_part&.body&.to_s
end
end