Merge pull request #1124 from basecamp/fix-missing-default-value-for-delinquency-tracker

Fix crash due to missing default value
This commit is contained in:
Stanko Krtalić
2025-09-17 11:53:41 +02:00
committed by GitHub
4 changed files with 10 additions and 5 deletions
+1 -1
View File
@@ -9,7 +9,7 @@ class Webhook::DelinquencyTracker < ApplicationRecord
reset
else
mark_first_failure_time if consecutive_failures_count.zero?
increment!(:consecutive_failures_count)
increment!(:consecutive_failures_count, touch: true)
webhook.deactivate if delinquent?
end
@@ -0,0 +1,5 @@
class AddDefaultValueForConsecutiveFailuresCountToWebhookDelinquencyTrackers < ActiveRecord::Migration[8.1]
def change
change_column_default :webhook_delinquency_trackers, :consecutive_failures_count, from: nil, to: 0
end
end
Generated
+2 -2
View File
@@ -10,7 +10,7 @@
#
# It's strongly recommended that you check this file into your version control system.
ActiveRecord::Schema[8.1].define(version: 2025_09_15_170056) do
ActiveRecord::Schema[8.1].define(version: 2025_09_17_064006) do
create_table "accesses", force: :cascade do |t|
t.datetime "accessed_at"
t.integer "collection_id", null: false
@@ -456,7 +456,7 @@ ActiveRecord::Schema[8.1].define(version: 2025_09_15_170056) do
end
create_table "webhook_delinquency_trackers", force: :cascade do |t|
t.integer "consecutive_failures_count"
t.integer "consecutive_failures_count", default: 0
t.datetime "created_at", null: false
t.datetime "first_failure_at"
t.datetime "updated_at", null: false
+2 -2
View File
@@ -1325,7 +1325,7 @@ columns:
cast_type: *3
sql_type_metadata: *4
'null': true
default:
default: 0
default_function:
collation:
comment:
@@ -3191,4 +3191,4 @@ indexes:
comment:
valid: true
workflows: []
version: 20250915170056
version: 20250917064006