Merge pull request #1320 from basecamp/better-localstorage-keys

Make collection-specific keys for collapsed column state

app/javascript/controllers/collapsible_columns_controller.js

@@ -3,6 +3,9 @@ import { Controller } from "@hotwired/stimulus"
 export default class extends Controller {
   static classes = [ "collapsed" ]
   static targets = [ "column", "button" ]
+  static values = {
+    collection: String
+  }
 
   connect() {
     this.#restoreColumns()
@@ -71,6 +74,6 @@ export default class extends Controller {
   }
 
   #localStorageKeyFor(column) {
-    return `expand-${column.getAttribute("id")}`
+    return `expand-${this.collectionValue}-${column.getAttribute("id")}`
   }
 }

app/views/collections/show/_columns.html.erb

@@ -8,7 +8,7 @@
         dragenter->drag-and-strum#dragEnter
         drop->drag-and-drop#drop
         dragend->drag-and-drop#dragEnd" } do %>
-  <div class="card-columns" data-controller="collapsible-columns" data-collapsible-columns-collapsed-class="is-collapsed">
+  <div class="card-columns" data-controller="collapsible-columns" data-collapsible-columns-collection-value="<%= collection.id %>" data-collapsible-columns-collapsed-class="is-collapsed">
     <div class="card-columns__left">
       <%= render "collections/show/not_now", collection: collection %>
     </div>

app/views/public/collections/show/_columns.html.erb

@@ -1,5 +1,5 @@
 <%= turbo_frame_tag :cards_container do %>
-  <div class="card-columns" data-controller="collapsible-columns" data-collapsible-columns-collapsed-class="is-collapsed">
+  <div class="card-columns" data-controller="collapsible-columns" data-collapsible-columns-collection-value="<%= collection.id %>" data-collapsible-columns-collapsed-class="is-collapsed">
 
     <div class="card-columns__left">
       <%= render "public/collections/show/not_now", collection: collection %>
@@ -12,4 +12,4 @@
       <%= render "public/collections/show/closed", collection: collection %>
     </div>
   </div>
-<% end %>
+<% end %>