Refine queries

app/javascript/controllers/terminal_controller.js

@@ -40,12 +40,12 @@ export default class extends Controller {
 
   handleCommandResponse(event) {
     if (event.detail.success) {
-      const response = event.detail.fetchResponse;
+      const response = event.detail.fetchResponse
       if (response && response.response.headers.get("Content-Type")?.includes("application/json")) {
         response.response.json().then((commands) => {
           this.element.querySelector("#chat-responses").textContent = JSON.stringify(commands, null, 2)
           this.#executeCommands(commands)
-        });
+        })
       } else {
         this.#reset()
       }
@@ -130,9 +130,8 @@ export default class extends Controller {
   async #executeCommands(commands) {
     for (const command of commands) {
       if (command.command == "/search") {
-        const params = new URLSearchParams(command)
         // Clunky example, for PoC purposes
-        Turbo.visit(`/cards?${params.toString()}`)
+        Turbo.visit(`/cards?${toQueryString(command)}`)
         await delay(2000)
       } else {
         this.inputTarget.value = command.command
@@ -141,3 +140,18 @@ export default class extends Controller {
     }
   }
 }
+
+function toQueryString(obj) {
+  const params = new URLSearchParams()
+  for (const key in obj) {
+    const value = obj[key]
+    if (Array.isArray(value)) {
+      for (const item of value) {
+        params.append(`${key}[]`, item)
+      }
+    } else if (value !== undefined && value !== null) {
+      params.append(key, value)
+    }
+  }
+  return params.toString()
+}

app/models/command/chat_query.rb

@@ -33,7 +33,7 @@ class Command::ChatQuery < Command
         asks for a certain set of cards, you can use the /search command to filter. It supports the following
         conditions:
 
-          - assignment_status: can be "unassigned"
+          - assignment_status: can be "unassigned". Only include if asking for unassigned cards explicitly
           - indexed_by: can be "newest", "oldest", "latest", "stalled", "closed"
           - engagement_status: can be "considering" or "doing"
           - card_ids: a list of card ids
@@ -56,6 +56,9 @@ class Command::ChatQuery < Command
 
         { command: "/search", indexed_by: "closed", collection_ids: [ "Writebook", "Design" ] }
 
+        Notice that there are overlapping commands (filter by assignee or assign cards). Favor filtering/queries for
+        commands like "cards assigned to someone".
+
         Notice that only /search commands carry additional JSON params. For /tag, /close and /assign just append the
         param to the string command.
 
@@ -67,8 +70,8 @@ class Command::ChatQuery < Command
     def replace_names_with_ids(commands)
       commands.each do |command|
         if command["command"] == "/search"
-          command["assignee_ids"] = command["assignee_ids"]&.filter_map { |name| assignee_from(name).id }
-          command["creator_id"] = assignee_from(command["creator_id"]).id if command["creator_id"]
+          command["assignee_ids"] = command["assignee_ids"]&.filter_map { |name| assignee_from(name)&.id }
+          command["creator_id"] = assignee_from(command["creator_id"])&.id if command["creator_id"]
           command["collection_ids"] = command["collection_ids"]&.filter_map { |name| Collection.where("lower(name) = ?", name.downcase).first&.id }
           command["tag_ids"] = command["tag_ids"]&.filter_map { |name| ::Tag.find_by_title(name)&.id }
           command.compact!