bterkuile/fizzy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #2558 from basecamp/correct-card-url-in-webhook-payload

Browse Source 
Correct card URL in comment JSON output
This commit is contained in:
Kevin McConnell
2026-02-17 17:20:02 +00:00
committed by GitHub
parent 4b2586769b 4e9773f9f5
commit b2b8465ae8
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/views/cards/comments/_comment.json.jbuilder
+3 -3
View File
@@ -13,9 +13,9 @@ json.cache! comment do
json.card do
json.id comment.card_id
json.url card_url(comment.card_id)
json.url card_url(comment.card)
end
json.reactions_url card_comment_reactions_url(comment.card_id, comment.id)
json.url card_comment_url(comment.card_id, comment.id)
json.reactions_url card_comment_reactions_url(comment.card, comment)
json.url card_comment_url(comment.card, comment)
end
test/controllers/cards/comments_controller_test.rb
+3 -3
View File
@@ -78,9 +78,9 @@ class Cards::CommentsControllerTest < ActionDispatch::IntegrationTest
assert_response :success
assert_equal comment.id, @response.parsed_body["id"]
assert_equal comment.card.id, @response.parsed_body.dig("card", "id")
assert_equal card_url(comment.card.id), @response.parsed_body.dig("card", "url")
assert_equal card_comment_reactions_url(comment.card_id, comment.id), @response.parsed_body["reactions_url"]
assert_equal card_comment_url(comment.card_id, comment.id), @response.parsed_body["url"]
assert_equal card_url(comment.card), @response.parsed_body.dig("card", "url")
assert_equal card_comment_reactions_url(comment.card, comment), @response.parsed_body["reactions_url"]
assert_equal card_comment_url(comment.card, comment), @response.parsed_body["url"]
end
test "update as JSON" do