Move card__list outside pagination

This commit is contained in:
Andy Smith
2026-01-02 11:42:00 -06:00
parent 1686c48654
commit b4096d9f22
12 changed files with 75 additions and 68 deletions
@@ -1,6 +1,4 @@
<div class="cards__list hide-scrollbar" data-drag-drop-item-container>
<div class="blank-slate blank-slate--drag card card--hide-unless-empty">
<p>Drag cards here</p>
</div>
<div class="blank-slate blank-slate--empty card--hide-unless-empty">No cards here</div>
<div class="blank-slate blank-slate--drag card card--hide-unless-empty">
<p>Drag cards here</p>
</div>
<div class="blank-slate blank-slate--empty card--hide-unless-empty">No cards here</div>
-4
View File
@@ -1,4 +0,0 @@
<div class="cards__list hide-scrollbar" data-drag-drop-item-container>
<%= yield %>
<%= render "cards/display/previews", cards: cards, draggable: draggable %>
</div>
@@ -12,12 +12,14 @@
<section class="cards cards--grid">
<%= turbo_frame_tag :closed_column do %>
<% if @page.used? %>
<%= with_automatic_pagination :closed_column, @page do %>
<%= render "boards/columns/list", cards: @page.records, draggable: true %>
<div class="cards__list hide-scrollbar" data-drag-drop-item-container>
<% if @page.used? %>
<%= with_automatic_pagination :closed_column, @page do %>
<%= render "cards/display/previews", cards: @page.records, draggable: true %>
<% end %>
<% else %>
<%= render "boards/columns/empty_placeholder" %>
<% end %>
<% else %>
<%= render "boards/columns/empty_placeholder" %>
<% end %>
</div>
<% end %>
</section>
@@ -12,12 +12,14 @@
<section class="cards cards--grid">
<%= turbo_frame_tag :not_now_column do %>
<% if @page.used? %>
<%= with_automatic_pagination :not_now_column, @page do %>
<%= render "boards/columns/list", cards: @page.records, draggable: true %>
<div class="cards__list hide-scrollbar" data-drag-drop-item-container>
<% if @page.used? %>
<%= with_automatic_pagination :not_now_column, @page do %>
<%= render "cards/display/previews", cards: @page.records, draggable: true %>
<% end %>
<% else %>
<%= render "boards/columns/empty_placeholder" %>
<% end %>
<% else %>
<%= render "boards/columns/empty_placeholder" %>
<% end %>
</div>
<% end %>
</section>
+8 -6
View File
@@ -12,12 +12,14 @@
<section class="cards cards--grid">
<%= turbo_frame_tag @column, :cards do %>
<% if @page.used? %>
<%= with_automatic_pagination dom_id(@column, :cards), @page do %>
<%= render "boards/columns/list", cards: @page.records, draggable: true %>
<div class="cards__list hide-scrollbar" data-drag-drop-item-container>
<% if @page.used? %>
<%= with_automatic_pagination dom_id(@column, :cards), @page do %>
<%= render "cards/display/previews", cards: @page.records, draggable: true %>
<% end %>
<% else %>
<%= render "boards/columns/empty_placeholder" %>
<% end %>
<% else %>
<%= render "boards/columns/empty_placeholder" %>
<% end %>
</div>
<% end %>
</section>
@@ -12,12 +12,14 @@
<section class="cards cards--grid">
<%= turbo_frame_tag :stream_column do %>
<% if @page.used? %>
<%= with_automatic_pagination :stream_column, @page do %>
<%= render "boards/columns/list", cards: @page.records, draggable: true %>
<div class="cards__list hide-scrollbar" data-drag-drop-item-container>
<% if @page.used? %>
<%= with_automatic_pagination :stream_column, @page do %>
<%= render "cards/display/previews", cards: @page.records, draggable: true %>
<% end %>
<% else %>
<%= render "boards/columns/empty_placeholder" %>
<% end %>
<% else %>
<%= render "boards/columns/empty_placeholder" %>
<% end %>
</div>
<% end %>
</section>
+8 -8
View File
@@ -7,14 +7,14 @@
<%= render "boards/show/expander", title: "Maybe?", count: board.cards.awaiting_triage.count, column_id: "maybe" %>
<%= render "boards/show/menu/maximize", column_path: board_columns_stream_path(board) %>
</header>
<% if page.used? %>
<%= with_automatic_pagination "maybe", @page do %>
<%= render "boards/columns/list", cards: page.records, draggable: true do %>
<%= render "columns/show/add_card_button", board: board %>
<div class="cards__list">
<%= render "columns/show/add_card_button", board: board %>
</div>
<div class="cards__list hide-scrollbar" data-drag-drop-item-container>
<% if page.used? %>
<%= with_automatic_pagination "maybe", @page do %>
<%= render "cards/display/previews", cards: page.records, draggable: true %>
<% end %>
<% end %>
<% else %>
<div class="cards__list hide-scrollbar" data-drag-drop-item-container>
</div>
<% end %>
</div>
<% end %>
@@ -1,3 +0,0 @@
<div class="cards__list hide-scrollbar">
<%= render "cards/display/public_previews", cards: cards %>
</div>
@@ -12,13 +12,15 @@
<section class="cards cards--grid">
<%= turbo_frame_tag :closed_column do %>
<% if @page.used? %>
<%= with_automatic_pagination :closed_column, @page do %>
<%= render "public/boards/columns/list", cards: @page.records %>
<div class="cards__list hide-scrollbar">
<% if @page.used? %>
<%= with_automatic_pagination :closed_column, @page do %>
<%= render "cards/display/public_previews", cards: @page.records %>
<% end %>
<% else %>
<div class="blank-slate blank-slate--empty">No cards here</div>
<% end %>
<% else %>
<div class="blank-slate blank-slate--empty">No cards here</div>
<% end %>
</div>
<% end %>
</section>
@@ -12,13 +12,15 @@
<section class="cards cards--grid">
<%= turbo_frame_tag :not_now_column do %>
<% if @page.used? %>
<%= with_automatic_pagination :not_now_column, @page do %>
<%= render "public/boards/columns/list", cards: @page.records %>
<div class="cards__list hide-scrollbar">
<% if @page.used? %>
<%= with_automatic_pagination :not_now_column, @page do %>
<%= render "cards/display/public_previews", cards: @page.records %>
<% end %>
<% else %>
<div class="blank-slate blank-slate--empty">No cards here</div>
<% end %>
<% else %>
<div class="blank-slate blank-slate--empty">No cards here</div>
<% end %>
</div>
<% end %>
</section>
@@ -12,13 +12,15 @@
<section class="cards cards--grid">
<%= turbo_frame_tag @column, :cards do %>
<% if @page.used? %>
<%= with_automatic_pagination dom_id(@column, :cards), @page do %>
<%= render "public/boards/columns/list", cards: @page.records %>
<div class="cards__list hide-scrollbar">
<% if @page.used? %>
<%= with_automatic_pagination dom_id(@column, :cards), @page do %>
<%= render "cards/display/public_previews", cards: @page.records %>
<% end %>
<% else %>
<div class="blank-slate blank-slate--empty">No cards here</div>
<% end %>
<% else %>
<div class="blank-slate blank-slate--empty">No cards here</div>
<% end %>
</div>
<% end %>
</section>
@@ -12,13 +12,15 @@
<section class="cards cards--grid">
<%= turbo_frame_tag :stream_column do %>
<% if @page.used? %>
<%= with_automatic_pagination :stream_column, @page do %>
<%= render "public/boards/columns/list", cards: @page.records %>
<div class="cards__list hide-scrollbar">
<% if @page.used? %>
<%= with_automatic_pagination :stream_column, @page do %>
<%= render "cards/display/public_previews", cards: @page.records %>
<% end %>
<% else %>
<div class="blank-slate blank-slate--empty">No cards here</div>
<% end %>
<% else %>
<div class="blank-slate blank-slate--empty">No cards here</div>
<% end %>
</div>
<% end %>
</section>