bterkuile/fizzy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #1247 from basecamp/a11y-column-picker

Browse Source 
Add proper radio functionality to column picker
This commit is contained in:
Andy Smith
2025-10-06 14:32:56 -05:00
committed by GitHub
parent a2b21b75ee 7affff16fd
commit c0ac0fb0f2
2 changed files with 34 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/views/cards/stagings/_stages.html.erb
+12 -1
View File
@@ -1,16 +1,27 @@
<% if workflow = card.collection.workflow %>
<div id="<%= dom_id(card, :stages) %>" class="card__stages">
<div id="<%= dom_id(card, :stages) %>" class="card__stages" role="radiogroup">
<legend class="for-screen-reader">Choose a column for this card</legend>
<%= button_to "Not now", card_closure_path(card, reason: "Not now"),
class: [ "workflow-stage btn", { "workflow-stage--current": card.closed? } ],
role: "radio",
aria: { checked: card.closed? },
form_class: "flex align-center gap-half" %>
<%= button_to "The Stream", card_engagement_path(card), method: :delete,
class: [ "workflow-stage workflow-stage--stream btn", { "workflow-stage--current": card.considering? } ],
role: "radio",
aria: { checked: card.considering? },
form_class: "flex align-center gap-half" %>
<% workflow.stages.each do |stage| %>
<%= button_to_set_stage card, stage %>
<% end %>
<%= button_to "Closed", card_closure_path(card, reason: "Completed"),
class: [ "workflow-stage btn", { "workflow-stage--current": card.closed? } ],
role: "radio",
aria: { checked: card.closed? },
form_class: "flex align-center gap-half" %>
</div>
<% end %>
app/views/cards/triage/_columns.html.erb
+22 -14
View File
@@ -1,17 +1,25 @@
<div id="<%= dom_id(card, :stages) %>" class="card__stages">
<%= button_to "Not now", card_not_now_path(card),
class: [ "workflow-stage btn", { "workflow-stage--current": card.postponed? } ],
form_class: "flex align-center gap-half" %>
<div id="<%= dom_id(card, :stages) %>" class="card__stages" role="radiogroup">
<legend class="for-screen-reader">Choose a column for this card</legend>
<%= button_to "The Stream", card_triage_path(card), method: :delete,
class: [ "workflow-stage workflow-stage--stream btn", { "workflow-stage--current": card.awaiting_triage? } ],
form_class: "flex align-center gap-half" %>
<%= button_to "Not now", card_not_now_path(card),
class: [ "workflow-stage btn", { "workflow-stage--current": card.postponed? } ],
role: "radio",
aria: { checked: card.postponed? },
form_class: "flex align-center gap-half" %>
<% card.collection.columns.each do |column| %>
<%= button_to_set_column card, column %>
<% end %>
<%= button_to "The Stream", card_triage_path(card), method: :delete,
class: [ "workflow-stage workflow-stage--stream btn", { "workflow-stage--current": card.awaiting_triage? } ],
role: "radio",
aria: { checked: card.awaiting_triage? },
form_class: "flex align-center gap-half" %>
<%= button_to "Closed", card_closure_path(card, reason: "Completed"),
class: [ "workflow-stage btn", { "workflow-stage--current": card.closed? } ],
form_class: "flex align-center gap-half" %>
</div>
<% card.collection.columns.each do |column| %>
<%= button_to_set_column card, column %>
<% end %>
<%= button_to "Closed", card_closure_path(card, reason: "Completed"),
class: [ "workflow-stage btn", { "workflow-stage--current": card.closed? } ],
role: "radio",
aria: { checked: card.closed? },
form_class: "flex align-center gap-half" %>
</div>