Move constant to new concern to group labels together
This commit is contained in:
@@ -8,10 +8,12 @@ module Account::PopReasons
|
||||
"Working as intended"
|
||||
]
|
||||
|
||||
FALLBACK_LABEL = "Done"
|
||||
|
||||
included do
|
||||
has_many :pop_reasons, dependent: :destroy, class_name: "Pop::Reason" do
|
||||
def labels
|
||||
pluck(:label).presence || [ Pop::Reason::FALLBACK_LABEL ]
|
||||
pluck(:label).presence || [ FALLBACK_LABEL ]
|
||||
end
|
||||
end
|
||||
|
||||
|
||||
+1
-1
@@ -3,6 +3,6 @@ class Pop < ApplicationRecord
|
||||
belongs_to :user, optional: true
|
||||
|
||||
def reason
|
||||
super || Pop::Reason::FALLBACK_LABEL
|
||||
super || Account::PopReasons::FALLBACK_LABEL
|
||||
end
|
||||
end
|
||||
|
||||
@@ -1,5 +1,3 @@
|
||||
class Pop::Reason < ApplicationRecord
|
||||
belongs_to :account
|
||||
|
||||
FALLBACK_LABEL = "Done"
|
||||
end
|
||||
|
||||
@@ -1,4 +1,4 @@
|
||||
require 'test_helper'
|
||||
require "test_helper"
|
||||
|
||||
class PopReasonsTest < ActiveSupport::TestCase
|
||||
test "create defaults pop reasons on creation" do
|
||||
|
||||
Reference in New Issue
Block a user