Simplify Bucket::View validations

This commit is contained in:
Jose Farias
2024-10-17 17:15:45 -06:00
parent 62a72f216b
commit eb68fbe8ff
+10 -6
View File
@@ -6,14 +6,18 @@ class Bucket::View < ApplicationRecord
has_one :account, through: :creator
validate :must_have_filters, :must_not_be_the_default_view
validate :must_not_be_the_default_view
class << self
def default_filters
{ "order_by" => "most_active" }
end
end
private
def must_have_filters
errors.add(:base, "must have filters") if filters.values.all?(&:blank?)
end
def must_not_be_the_default_view
errors.add(:base, "must be different than the default view") if filters.compact_blank == { "order_by" => "most_active" }
if filters.values.all?(&:blank?) || filters == self.class.default_filters
errors.add :base, "must be different than the default view"
end
end
end