Commit Graph

3718 Commits

Author SHA1 Message Date
Jorge Manrubia 0191eb85dc Merge branch 'main' into card-attachments
* main:
  Don't create mentions from drafts until those are published
  Change Active Storage account slug extension to a to_prepare block
  dep: bump actiontext-lexical for previewable attachment fix
  Add assertion for composite command line
  Remove trace
  restore the right command
  Update action text
  The prompt confirmation system wasn't really working after moving to lexical
  Parse commands where it's just a gid properly
  Move inside concerns or the override won't work
  Truncation for comment author line
  Avoid duplicated queries and, instead, bump the last ones
  Adjust screen for screen readers
  Adjust icon sizing and uploading styles
2025-07-04 17:38:27 +02:00
Jorge Manrubia ec0c019967 Merge pull request #711 from basecamp/mentionable-published
Don't create mentions from drafts until those are published
2025-07-04 17:28:19 +02:00
Jorge Manrubia b9f7634457 Merge pull request #706 from basecamp/duplicated-seraches
Avoid duplicated queries and, instead, bump the last ones
2025-07-04 17:28:15 +02:00
Jorge Manrubia 17f9df8df3 Don't create mentions from drafts until those are published
https://fizzy.37signals.com/5986089/collections/2/cards/982
2025-07-04 17:25:39 +02:00
Jason Zimdars 2f1f45c1c7 Merge branch 'main' into jz-7-3-25-pm
* main:
  Change Active Storage account slug extension to a to_prepare block
  dep: bump actiontext-lexical for previewable attachment fix
  Add assertion for composite command line
  Remove trace
  restore the right command
  Update action text
  The prompt confirmation system wasn't really working after moving to lexical
  Parse commands where it's just a gid properly
  Move inside concerns or the override won't work
2025-07-03 19:24:56 -05:00
Mike Dalessio ec5f7b1efa Merge pull request #710 from basecamp/flavorjones/fix-attach-after-reload
Change Active Storage account slug extension to a to_prepare block
2025-07-03 19:02:23 -04:00
Mike Dalessio 05984845ca Change Active Storage account slug extension to a to_prepare block
because it was breaking in development after a reload.
2025-07-03 19:01:03 -04:00
Mike Dalessio abb4046f0f Merge pull request #709 from basecamp/flavorjones/lexical-bump-for-previewable-attachments
dep: bump actiontext-lexical for previewable attachment fix
2025-07-03 18:37:03 -04:00
Mike Dalessio 93f9e93239 dep: bump actiontext-lexical for previewable attachment fix
ref: https://fizzy.37signals.com/5986089/collections/2/cards/1004
2025-07-03 18:35:53 -04:00
Jorge Manrubia fc2e7597f0 Merge pull request #708 from basecamp/commandline-issues
More prompt fixes
2025-07-04 00:09:22 +02:00
Jorge Manrubia 68277183e3 Add assertion for composite command line 2025-07-04 00:08:47 +02:00
Jorge Manrubia 3ed7c940d9 Remove trace 2025-07-04 00:07:03 +02:00
Jason Zimdars f1fe0ade1d Merge branch 'main' into jz-7-3-25-pm
* main:
  Store the normalized line not the raw line!
  Always resolve rich text commands
2025-07-03 17:06:27 -05:00
Jorge Manrubia 2cd8df4975 restore the right command 2025-07-04 00:05:52 +02:00
Jorge Manrubia 5c68dac4d5 Update action text 2025-07-04 00:05:39 +02:00
Jason Zimdars 132059e77a This is a hack but we should be showing the card description and attachments for new cards 2025-07-03 16:54:26 -05:00
Jason Zimdars 0539d366d7 Display attachments in events for comments 2025-07-03 16:48:43 -05:00
Jorge Manrubia 809d23245f The prompt confirmation system wasn't really working after moving to lexical
The async value setting was biting us here
2025-07-03 23:29:36 +02:00
Jorge Manrubia c134df1bb8 Parse commands where it's just a gid properly 2025-07-03 23:10:19 +02:00
Jorge Manrubia 994560c1b7 Move inside concerns or the override won't work 2025-07-03 23:06:37 +02:00
Jason Zimdars cf4c6dba9c Indicate cards with attachments in the description 2025-07-03 15:56:25 -05:00
Jorge Manrubia 8071c7b522 Store the normalized line not the raw line! 2025-07-03 22:40:16 +02:00
Jorge Manrubia fd418b123e Always resolve rich text commands
I don't remember why I added this but we don't really need it. Also, this result
in potential ambiguity even when you use prompts for standalone tags and mentions
2025-07-03 22:21:50 +02:00
Jason Zimdars 8f42086703 Truncation for comment author line 2025-07-03 15:06:15 -05:00
Jorge Manrubia fef9e74503 Avoid duplicated queries and, instead, bump the last ones 2025-07-03 21:52:58 +02:00
Jason Zimdars 5d34cb3f51 Adjust screen for screen readers 2025-07-03 14:37:31 -05:00
Jason Zimdars 512cd32b2d Adjust icon sizing and uploading styles 2025-07-03 14:36:15 -05:00
Jorge Manrubia 020c99fc99 Update editor 2025-07-03 19:57:29 +02:00
Jorge Manrubia 26cb727e0c Update editor 2025-07-03 19:55:55 +02:00
Jorge Manrubia 7d0149ae84 Not committing hard coded gems is a good idea 2025-07-03 19:27:44 +02:00
Jorge Manrubia 6b22fb3259 Update editor 2025-07-03 19:25:07 +02:00
Jorge Manrubia 7ff21f95d2 Update editor 2025-07-03 19:11:51 +02:00
Jason Zimdars 2f566bcaa2 Merge branch 'main' into jz-7-3-25
* main:
  Update lexical to fix problem with multi file uploads
  Update to include fix for Safari
  Broadcast when all notifications are cleared
2025-07-03 11:48:25 -05:00
Jorge Manrubia 181ced13d0 Update lexical to fix problem with multi file uploads 2025-07-03 18:35:11 +02:00
Jorge Manrubia 2c0bb6ecb6 Update to include fix for Safari 2025-07-03 18:21:35 +02:00
Mike Dalessio a04508ca3c Merge pull request #705 from basecamp/flavorjones/fix-notifs-turbo-response
Broadcast when all notifications are cleared
2025-07-03 12:12:07 -04:00
Mike Dalessio 53ebb509d8 Broadcast when all notifications are cleared
Then make the turbo response to clearing all notifications a no-op.

This has the bonus side effect of properly clearing the notifications
try on all open pages.

ref: https://fizzy.37signals.com/5986089/collections/2/cards/796
2025-07-03 12:05:41 -04:00
Jason Zimdars 24fa687b2d Merge branch 'main' into jz-7-3-25
* main: (57 commits)
  Rename /add_card => /add
  Cards' "stalled" metric is reset when reconsidered
  Use composite commands even for single commands since they can carry custom titles, which is what we want with AI
  Fix merge issues
  More prompt tweaks
  Support completed by via natural language
  Add filter pill for completed by
  Add "close by" filter
  Add /reopen command
  Improved support to act on cards via ID
  Refine prompt
  Add more tests and fix failing ones
  Add clarifying comment
  Return standalone command when only one command
  Extract attachable concerns
  Format
  Update lexical
  Use your user gid to resolve yourself, so that this is not ambiguous
  Support trailing spaces in inserted commands
  Disable attachments in the terminal
  ...
2025-07-03 11:04:15 -05:00
Mike Dalessio 19af7c7c50 Merge pull request #704 from basecamp/flavorjones/reconsider-resets-stalling
Cards' "stalled" metric is reset when reconsidered
2025-07-03 11:26:30 -04:00
Jorge Manrubia eb795a7265 Merge pull request #703 from basecamp/rename-add-card
Rename /add_card => /add
2025-07-03 17:25:59 +02:00
Jorge Manrubia f18b79d464 Rename /add_card => /add 2025-07-03 17:23:56 +02:00
Mike Dalessio d376d7aa0c Cards' "stalled" metric is reset when reconsidered
Specifically, reconsidering removes the existing activity spike (if
one exists). This happens whether the card is reconsidered by entropy
or manually by a user.

ref: https://fizzy.37signals.com/5986089/collections/2/cards/916
2025-07-03 11:15:08 -04:00
Jason Zimdars 954d209cbc Link should break out of frame 2025-07-03 10:13:09 -05:00
Jason Zimdars 1dfe541bd4 Allow deselecting a Workflow 2025-07-03 10:11:36 -05:00
Jason Zimdars 277965e8dc Don't show duplicate searches 2025-07-03 09:51:44 -05:00
Jason Zimdars 645d4b3497 Fix broken page title 2025-07-03 09:35:24 -05:00
Jorge Manrubia a1a8828191 Merge pull request #684 from basecamp/fizzy-do-prompts
Add prompts to the Fizzy menu
2025-07-03 16:28:31 +02:00
Jorge Manrubia 702169384c Use composite commands even for single commands since they can carry custom titles, which is what we want with AI 2025-07-03 16:26:52 +02:00
Jorge Manrubia 7e2f3894f6 Fix merge issues 2025-07-03 16:11:44 +02:00
Mike Dalessio 5cc5e26cb8 Merge pull request #702 from basecamp/flavorjones/pwa-manifest-tweak
PWS manifest uses paths and not URLs
2025-07-03 10:11:07 -04:00