029c151a4e
Add missing data-attr on public board
2025-12-04 15:43:19 -06:00
d5f8eeddaa
Merge pull request #1937 from basecamp/mobile-polish
...
Fix hotkey text size on tiny viewports
2025-12-04 15:26:24 -06:00
34d3383cbd
Fix hotkey text size on tiny viewports
2025-12-04 15:23:20 -06:00
1c5ead0096
Merge pull request #1930 from basecamp/prevent-blank-board-names
...
Prevent board names with only spaces and show validation message
2025-12-04 14:50:17 -06:00
e3e57a6a7e
Merge pull request #1927 from basecamp/speed-up-sorting
...
Faster D&D by optimistically inserting dropped cards
2025-12-04 21:31:21 +01:00
9639e07ab8
Save a bunch of invocations on morph events from children elements
2025-12-04 21:27:22 +01:00
704b5b9788
Fix: memoization was showing stale values when morphing
2025-12-04 21:21:54 +01:00
fee376b12b
Merge pull request #1932 from basecamp/flavorjones-validate-email
...
Validate Identity email address
2025-12-04 14:06:04 -05:00
bc1075f194
GitHub actions: limit GITHUB_TOKEN permissions ( #1933 )
2025-12-04 11:05:50 -08:00
00eee29837
Validate Identity email address
...
using the "standard" email regexp URI::MailTo::EMAIL_REGEXP. The form
field will validate this in the browser, but if bots are creating
identities, they can put whatever they want in here. So let's add some
protection against that.
The HtmlHelper regex was renamed here to avoid confusing Brakeman,
which does imprecise constant lookup and was confusing the two
constants, one of which uses `\A` and `\z` and the other does
not (intentionally).
ref: https://app.fizzy.do/5986089/cards/3276
2025-12-04 14:01:15 -05:00
4e0b83340d
Drop defunct user creation script
2025-12-04 10:42:34 -08:00
bbec988516
Golden cards should be placed at the top
2025-12-04 19:23:55 +01:00
a380492b32
Animate the column height with a stimulus controller so that it does not depend to the server to update when you D&D
2025-12-04 19:15:38 +01:00
53b97c94e0
mise: respect .ruby-version
...
(37signals have this configured globally; setting locally for others)
Closes #1891
2025-12-04 09:59:17 -08:00
23ec3f129a
Support custom validation messages
2025-12-04 11:43:55 -06:00
1122556383
Move css bit to the new blank slates CSS
2025-12-04 18:42:44 +01:00
5c4fe9fe8b
Prevent board names with only spaces and show validation message
2025-12-04 11:37:27 -06:00
03e4f86b7a
Merge pull request #1878 from basecamp/flavorjones/console1984-v2
...
Bump fizzy-saas to enable console auditing
2025-12-04 12:31:34 -05:00
539d3721db
Keep the column color when D&D cards
2025-12-04 18:31:23 +01:00
104bb5faa9
Add container to drop cards when the stream is empty
2025-12-04 18:31:23 +01:00
3536b6fb32
Modify counters optimistically too
2025-12-04 18:31:23 +01:00
19051aec3e
Append dropped cards instead of relying on server-side rendering to refresh the columns
...
This implements a simple strategy to optimistically insert cards in columns without waiting for the column refresh. Cards will be placed at the top respecting golden cards.
This uses sorting by "created at" with sorting by "updated at" for the _Not now_ column, so that the treatment everywhere is homogenous.
2025-12-04 18:31:23 +01:00
912bb8a8e5
Bump fizzy-saas to enable console auditing
...
ref: https://app.fizzy.do/5986089/cards/2469
ref: https://github.com/basecamp/fizzy-saas/pull/20
2025-12-04 12:25:54 -05:00
d4a50c996a
Merge pull request #1894 from Venkat-RK/main
...
Added 'Back to Home' link on notifications list page
2025-12-04 11:19:55 -06:00
c9eb44119d
Fixed typo in VCR filters ( #1929 )
...
I know it's a small thing, but I just noticed that 🤷
Be careful if you reintroduce your old VCRs as they have OPEN_API_KEY
2025-12-04 08:58:12 -08:00
78ea18b5da
Merge pull request #1872 from basecamp/filters-no-results
...
Nicer blank slates
2025-12-04 10:52:08 -06:00
a92aab9981
Removed test to verify back button.
2025-12-04 08:44:37 -08:00
373f4d5116
Merge pull request #1924 from basecamp/flavorjones/retry-mail-jobs
...
Retry mailer jobs on common networking and SMTP errors
2025-12-04 10:29:53 -05:00
c4a8996562
Retry mailer jobs on common networking and SMTP errors
...
This concern is lifted nearly verbatim from Basecamp.
ref: https://app.fizzy.do/5986089/cards/3300
2025-12-04 10:26:24 -05:00
dfe7095ee6
Merge pull request #1917 from basecamp/dont-resize-svg-avatars
...
Don't try to resize non-variable avatars
2025-12-04 14:53:00 +00:00
2fcdd921fc
Merge pull request #1922 from basecamp/flavorjones/revert-board-column-restriction
...
Revert "Changing columns requires board admin"
2025-12-04 09:50:59 -05:00
394c5dbf03
Revert "Changing columns requires board admin"
...
This reverts commit cecccadc14
2025-12-04 09:46:30 -05:00
916be75bed
Merge pull request #1859 from basecamp/flavorjones/fix-broken-remote-images
...
Gracefully handle ill-formed remote images in rich text
2025-12-04 09:39:26 -05:00
2e47749739
Don't allow SVG avatar uploads in the first place
2025-12-04 14:27:28 +00:00
89940d36f8
Gracefully handle ill-formed remote images in rich text
...
A better fix has been proposed upstream at
https://github.com/rails/rails/pull/56283 but this should be fine in
the meantime.
ref: https://app.fizzy.do/5986089/cards/3188
2025-12-04 09:24:52 -05:00
6475ad3425
Don't try to resize non-variable avatars
2025-12-04 13:36:21 +00:00
069e0ca0b2
Merge pull request #1920 from basecamp/routes-trailing-whitespace
...
Remove trailing whitespace
2025-12-04 13:36:02 +00:00
08c380cc71
Remove trailing whitespace
...
Appease the Rubocop
2025-12-04 13:32:47 +00:00
150e7caf03
Merge pull request #1908 from basecamp/install-runtime-and-ci-dependencies-on-mac
...
Install any runtime or ci dependencies in bin/setup on MacOS
2025-12-04 13:16:46 +01:00
b3481b10a8
Move legacy out of sight
2025-12-04 03:34:30 -08:00
d466b633fc
Merge pull request #1915 from basecamp/sign-up-new-users-on-sign-in
...
Sign up new users on sign in
2025-12-04 11:32:51 +01:00
9e0b5593ad
Merge pull request #1848 from basecamp/rate-limit-warning
...
Show alert message on login when rate limited
2025-12-04 10:30:37 +00:00
a8f328c921
Sign up new users on sign in
2025-12-04 11:30:21 +01:00
06478f23d2
Merge pull request #1912 from basecamp/refactor-reaction-permission-check
...
Change reaction admin permission check to be in-line with other controllers
2025-12-04 11:04:12 +01:00
5cfe6930ee
Change reaction admin permission check to be in-line with other controllers
2025-12-04 11:01:23 +01:00
6050f187ca
Merge pull request #1895 from jbnunn/remove-legacy-join-pattern
...
Removed legacy join link
2025-12-04 09:21:08 +01:00
ea826860e0
Install any runtime or ci dependencies in bin/setup
2025-12-04 09:16:30 +01:00
af43ef4962
Merge pull request #1897 from Hacksore/fix/board-bell-title
...
Move the title to the button
2025-12-04 09:02:08 +01:00
a0cb25a951
Merge pull request #1881 from basecamp/card-notification-removal-scope
...
Tighten scope on card notification removals
2025-12-04 08:44:52 +01:00
457a6d71b7
Merge pull request #1906 from basecamp/column-management-auth
...
Changing columns requires board admin
2025-12-04 08:34:49 +01:00
Andy Smith