Commit Graph

651 Commits

Author SHA1 Message Date
Jorge Manrubia e3e57a6a7e Merge pull request #1927 from basecamp/speed-up-sorting
Faster D&D by optimistically inserting dropped cards
2025-12-04 21:31:21 +01:00
Mike Dalessio 00eee29837 Validate Identity email address
using the "standard" email regexp URI::MailTo::EMAIL_REGEXP. The form
field will validate this in the browser, but if bots are creating
identities, they can put whatever they want in here. So let's add some
protection against that.

The HtmlHelper regex was renamed here to avoid confusing Brakeman,
which does imprecise constant lookup and was confusing the two
constants, one of which uses `\A` and `\z` and the other does
not (intentionally).

ref: https://app.fizzy.do/5986089/cards/3276
2025-12-04 14:01:15 -05:00
Jorge Manrubia a380492b32 Animate the column height with a stimulus controller so that it does not depend to the server to update when you D&D 2025-12-04 19:15:38 +01:00
Jorge Manrubia 539d3721db Keep the column color when D&D cards 2025-12-04 18:31:23 +01:00
Jorge Manrubia 19051aec3e Append dropped cards instead of relying on server-side rendering to refresh the columns
This implements a simple strategy to optimistically insert cards in columns without waiting for the column refresh. Cards will be placed at the top respecting golden cards.

This uses sorting by "created at" with sorting by "updated at" for the _Not now_ column, so that the treatment everywhere is homogenous.
2025-12-04 18:31:23 +01:00
Mike Dalessio 912bb8a8e5 Bump fizzy-saas to enable console auditing
ref: https://app.fizzy.do/5986089/cards/2469
ref: https://github.com/basecamp/fizzy-saas/pull/20
2025-12-04 12:25:54 -05:00
Sean Boult c1468de3d7 Fix title on bell icon 2025-12-03 21:20:34 -06:00
Jorge Manrubia 11249949eb Fix: edit comment button disappears when morphing the page
This also replaces the ad-hoc stimulus controller with the pure-css based
solution we recently added.

https://app.fizzy.do/5986089/cards/3243
2025-12-02 07:06:50 +01:00
Jason Zimdars 06a1473f5b Allow using '#' to match tags when filtering 2025-12-01 15:22:42 -06:00
Andy Smith 67921430a6 Merge pull request #1776 from basecamp/fizzy-menu-ui-updates
Add dividers and move icon to left
2025-12-01 14:51:24 -06:00
Andy Smith 9bbaee4f3a Add dividers and move icon to left 2025-12-01 14:43:06 -06:00
Jason Zimdars 6bb1a7238c No need to special case shift
The symbol isn't doing it
2025-12-01 14:12:46 -06:00
Jason Zimdars 7644b0e793 ESC is primary back hotkey, use helper in more places 2025-12-01 13:54:08 -06:00
Andy Smith 971244092d Colorful column list names on hover 2025-12-01 12:38:20 -06:00
Jason Zimdars 0fc3ed5042 No need for x tags if this is just for private cards 2025-12-01 10:58:06 -06:00
Jason Zimdars 0452a456d6 Update opengraph tile; update helper to include X tags and use it on public 2025-12-01 10:19:28 -06:00
Mike Dalessio edf6b53469 Introduce an "owner" role, and prevent it from being administered
to prevent the owner from being demoted or kicked out.

ref: https://app.fizzy.do/5986089/cards/3213
2025-11-29 14:13:29 -05:00
Jason Zimdars 6af569ddd8 Use move icon here, too 2025-11-24 12:03:34 +01:00
Jason Zimdars 86932803e4 Clarify not now move actions copy 2025-11-24 12:03:34 +01:00
Jorge Manrubia a4cc568a71 Merge branch 'main' into column-nav-keyboard
Resolved conflict in app/views/boards/show/_columns.html.erb by combining:
- hide-scrollbar class from main
- navigable-list controller from column-nav-keyboard

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-21 10:54:45 +01:00
Jorge Manrubia 9d08f26c59 Disable turbo when navigating to another account
So that the turbo-permanent trays get properly replaced

https://app.fizzy.do/5986089/cards/3094
2025-11-21 09:54:16 +01:00
Jason Zimdars ad7eb594d3 Match copy coming in #1663 2025-11-20 21:31:40 -06:00
Jorge Manrubia c052839bd6 Removed quotes since we were not using them 2025-11-20 21:37:41 +01:00
Jorge Manrubia baadd484b4 Review triage 2025-11-20 21:28:41 +01:00
Jorge Manrubia 3f21ea2329 Revert "Revert "Add more detail to events summaries"" 2025-11-20 21:12:41 +01:00
Jorge Manrubia 7200af879f Revert "Add more detail to events summaries" 2025-11-20 21:12:10 +01:00
Jorge Manrubia 4aef7230e5 Merge pull request #1659 from basecamp/notifications-copy
Add more detail to events summaries
2025-11-20 21:11:58 +01:00
Jorge Manrubia a48aa84f11 Remove legacy event 2025-11-20 21:11:02 +01:00
Jorge Manrubia 93a80ab8c2 Add more detail to events 2025-11-20 21:07:55 +01:00
Mike Dalessio 71f2ffbf59 Change "ADDED" to "DRAFTED" when rendering draft cards
ref: https://app.fizzy.do/5986089/cards/3062
2025-11-20 09:32:42 -05:00
Jorge Manrubia ccfc1b6058 Support containing actionable items to focused items in the navigable list 2025-11-20 14:03:00 +01:00
Jorge Manrubia eb51edac1c Rename properties 2025-11-20 13:56:27 +01:00
Jorge Manrubia 62d85f9b3b Extract helper for common code across columns 2025-11-20 13:32:50 +01:00
Jason Zimdars a15043a336 The symbol is hard to read, go back to text labels 2025-11-19 16:23:21 -06:00
David Heinemeier Hansson 80b2bbb652 Kill the slow count on tags 2025-11-18 17:07:18 +01:00
Jorge Manrubia 4d4a15a4d8 Fix: close dialog when removing background image
https://app.fizzy.do/5986089/cards/2990
2025-11-18 15:54:08 +01:00
Jorge Manrubia 0d2870c1f9 Fix: use the move icon for cards that are triaged or postponed too
https://app.fizzy.do/5986089/cards/2905#comment_994785588
2025-11-18 09:10:39 +01:00
Jason Zimdars def42d3375 Use symbols when reasonable 2025-11-17 17:35:01 -06:00
Stanko K.R. 0b8c51c2e9 Preload cards for columns 2025-11-17 16:16:19 +01:00
Mike Dalessio 2cb050af33 Missed a few changes in a rebase somewhere
This changeset now matches plan-b commit 609a0041
2025-11-17 09:19:46 -05:00
Stanko K.R. edf837fed3 Drop memberships 2025-11-17 09:12:39 -05:00
Mike Dalessio b5197fe6d3 Fix notifications to use the user's account 2025-11-17 09:11:57 -05:00
Mike Dalessio d41d50d52b Account.sole → Current.account
and some other de-tenant changes, including removing the controller
tenanting concerns
2025-11-17 09:11:40 -05:00
Jorge Manrubia eea9afb639 Fix: dismiss grouped notifications by card from the notifications tray
This also splits the templates into two: index and tray, since the URL now changes.
2025-11-14 12:58:24 +01:00
Andy Smith 5246c202b0 Create back link helper that works nicely on mobile 2025-11-13 14:13:29 -06:00
Andy Smith 3d2b649828 Add btn--back class 2025-11-13 13:57:36 -06:00
Jorge Manrubia 3b60e68ceb Merge branch 'main' into unique-notifications 2025-11-13 09:38:01 +01:00
Andy Smith 43ee91cee7 Move filter controller up to dialog for narrower listener scope 2025-11-12 15:41:36 -06:00
Andy Smith 3615c07f7f Clear filters when dialog closes 2025-11-12 15:29:27 -06:00
Jason Zimdars 3625585a9d Adjust unread indicator to include unread count 2025-11-12 11:15:25 -06:00