07ee06ddbd
Merge pull request #205 from basecamp/simplify-filters
...
Simplify filters
2025-01-15 17:03:17 -06:00
5ac9063a84
default_fields -> default_values
2025-01-15 16:57:02 -06:00
4441dc7cd8
Test passing params in different order
2025-01-15 16:55:57 -06:00
8d75429431
Remove old digest_params method
2025-01-15 16:45:15 -06:00
19874dcc2a
Test creating an equivalent filter with a different user
2025-01-15 16:41:25 -06:00
e9a085f848
Simplify filters
2025-01-15 16:27:33 -06:00
e807c2a8d1
Migration shouldn't unpublish existing bubbles
2025-01-15 12:34:58 +00:00
8a114e0d8d
Merge pull request #195 from basecamp/drafts
...
Draft bubbles
2025-01-15 12:08:06 +00:00
dbb3fd3b9c
Simplify
2025-01-15 12:03:56 +00:00
056d853cc8
Don't notify while bubbles are still drafted
2025-01-15 11:42:35 +00:00
731f93b55a
Add test
2025-01-15 10:58:00 +00:00
782259a678
Events should track published now
...
Previously when an item was `created`, we'd track the event, update the
summary text, and broadcast the notifications. But now that we have a
draft state, we shold do all of this when it's published instead.
2025-01-15 10:58:00 +00:00
cd1e6378d0
Add drafted and published states
2025-01-15 10:58:00 +00:00
f209c23e45
Cache notification partial
2025-01-15 10:57:27 +00:00
b85d300df1
Fix casing warning in Dockerfile
2025-01-15 10:57:27 +00:00
b5f4f7015e
Add missing libyaml dependency in Docker image
2025-01-15 10:57:27 +00:00
bab5bc718d
Rename deployment targets
2025-01-15 10:57:27 +00:00
e7819328e8
A little janky but we probably don't want to navigate when you're typing a comment
2025-01-14 17:00:32 -06:00
6a40256969
Prevent back navigation when cancelling comment edits
2025-01-14 16:57:29 -06:00
d20288f929
Don't trigger esc to go back when closing dialog
2025-01-14 16:53:38 -06:00
1f911b234b
Avoid navigating back when closing the filter dialog
2025-01-14 16:49:21 -06:00
a596d7cea7
Cancel and go back for forms with autofocused inputs
2025-01-14 16:45:29 -06:00
39ff31b14b
esc to cancel here, too
2025-01-14 16:04:41 -06:00
95f077672b
esc to navigate back to buckets index
2025-01-14 15:57:55 -06:00
f7f063ae0c
Can just use @bucket
2025-01-14 15:49:25 -06:00
32532c53cb
Add bucket link/title so you know where you are
2025-01-14 15:48:49 -06:00
55e6efd137
Merge pull request #199 from basecamp/notifs
...
Notifications
2025-01-14 15:25:47 +00:00
345acb1c0b
Add test for readings controller
2025-01-14 14:38:46 +00:00
b8ecfa0125
Replace notifications on read, instead of removing
...
Previously when a notification was read, we'd remove it from the list.
This will often be fine, but if there were more unread notifications
that hadn't been loaded yet (because there were too many for the initial
page) then the list could become empty when really there are still more
items to show.
So instead of removing the items when they're read, we can reload the
list with the new page of items. This should allow the older
notifications to come into view when necessary.
2025-01-14 14:23:46 +00:00
9fc5311ddc
Add simple controller test
2025-01-14 14:10:24 +00:00
9ddb7b260b
Remove empty test
2025-01-14 14:07:21 +00:00
415e872a2b
Combine concerns
2025-01-14 13:57:48 +00:00
c11b5af5e0
Make Stimulus controller more generic
2025-01-14 13:37:54 +00:00
df260840ab
Simplify test
2025-01-14 13:29:39 +00:00
78b7fe0f3d
Fix tests
2025-01-14 13:21:20 +00:00
ab154f2f35
Generate notification content in a helper
2025-01-14 13:08:12 +00:00
30b58f716b
Make title a notifier attribute
2025-01-14 10:21:47 +00:00
5f88cd3900
Design for notifications
2025-01-13 20:46:51 -06:00
64795804ba
Style
2025-01-13 14:21:47 +00:00
196575c0a2
Use a job to generate notifications
2025-01-13 14:21:47 +00:00
46989f6ebe
Mark notification read when viewing the Bubble
2025-01-13 14:21:47 +00:00
271ac063f9
Adjust a fixture
2025-01-13 14:21:47 +00:00
c62e800b08
Notifications are all related to a Bubble
2025-01-13 14:21:47 +00:00
df1225e58d
Style
2025-01-13 14:21:47 +00:00
febcb6c344
A partial is clearer than a helper here
2025-01-13 14:21:47 +00:00
10c7b61af9
Split up a long line for clarity
2025-01-13 14:21:47 +00:00
31ac7950ce
Use turbo:click, not click
...
Otherwise Turbo falls back to a regular Browser navigation.
2025-01-13 14:21:47 +00:00
d536358228
Make fixture match expected content
2025-01-13 14:21:47 +00:00
07fcb7ee6b
More style shuffling
2025-01-13 14:21:47 +00:00
6f7268f941
Set ID so a notification can't show up twice
2025-01-13 14:21:47 +00:00
Jose Farias