Commit Graph

109 Commits

Author SHA1 Message Date
Jose Farias 1b2df2200f Unnecessary after_touch 2024-10-25 16:06:43 -06:00
Jose Farias a3edee6e58 Extract grouping of boosts 2024-10-25 16:06:34 -06:00
Jose Farias 7b104287ba Roll up boosts server-side 2024-10-25 15:39:54 -06:00
Jose Farias 46c2b450da has_one allows for touch: true 2024-10-25 15:25:57 -06:00
Jose Farias 85d47a35ab threadables -> messageables 2024-10-25 15:03:31 -06:00
Jose Farias 3cd1d34f9d Thread entries relay touches to thread 2024-10-24 19:27:55 -06:00
Jose Farias 78232fabf8 map -> pluck 2024-10-24 18:15:23 -06:00
Jose Farias f5b01415aa Bubble events can be deleted 2024-10-24 18:01:32 -06:00
Jose Farias 652ec68e9c Threadables should thread entry 2024-10-24 17:48:32 -06:00
Jose Farias 3db14a117c Store stage ids in event particulars 2024-10-24 17:36:40 -06:00
Jose Farias c57f18c20c Materialize abstract thread
The domain language is clearer if we just persist a thread. Also rename some models so their purpose is clear.
2024-10-24 17:36:14 -06:00
Jose Farias ad88f90302 Fine not to denormalize user names in events 2024-10-24 15:50:00 -06:00
Jose Farias e2f608eb71 Remove *_names accessors for bucket views 2024-10-24 15:47:39 -06:00
Jose Farias 28a024b1da Pull out Threadable::TYPES 2024-10-24 11:36:24 -06:00
Jose Farias 042bc2c10e Use Proc for Threadable after_create 2024-10-24 11:31:06 -06:00
Jose Farias 70ff52f883 Move inverse_of further up 2024-10-24 11:28:59 -06:00
Jose Farias e3db8e8700 Inline thread entry creation 2024-10-24 11:25:50 -06:00
Jose Farias c41da5837c Add back bubble association to events 2024-10-24 11:22:23 -06:00
Jose Farias 5fed37a8c4 Refactor Bubble::Thread#latest_rollup 2024-10-24 10:55:30 -06:00
Jose Farias a49c6dc3f6 Refactor Bubble#toggle_stage 2024-10-24 10:51:23 -06:00
Jose Farias 804be0a971 Create thread entry in a callback 2024-10-24 10:38:59 -06:00
Jose Farias e1f03fb8fd comment! -> comment 2024-10-23 19:13:35 -06:00
Jose Farias ca85326638 Simplify Bubble#comment! 2024-10-23 19:07:48 -06:00
Jose Farias a0c1c7d0ed Move rollup param further up 2024-10-23 19:06:55 -06:00
Jose Farias 208ace7214 Delegate Current.user to session 2024-10-23 18:49:40 -06:00
Jose Farias cf22fb454a not_popped -> active 2024-10-23 18:32:27 -06:00
Jose Farias 77e00488af Move rollup further up 2024-10-23 18:09:32 -06:00
Jose Farias 11efca5af9 Bubbles don't have events anymore 2024-10-23 18:08:01 -06:00
Jose Farias 398baed6a6 Assignments should touch their bubbles 2024-10-23 17:29:49 -06:00
Jose Farias 567dec2197 Simplify threadable<>bubble relationships 2024-10-23 17:29:24 -06:00
Jose Farias ae497aae85 Clear up dependency destruction chain
Buckets destroy their bubbles, which destroy their thread entries, which destroy their threadables, which is how comments end up destroyed, and then rollups end up deleting their events
2024-10-23 14:51:12 -06:00
Jose Farias 35a31e3203 Model threadables 2024-10-23 14:10:04 -06:00
Jose Farias 06ea38a9f7 Denormalize event data 2024-10-23 13:38:00 -06:00
Jose Farias 0a5854e02e Merge pull request #121 from basecamp/workflows-spike
Spike workflows
2024-10-22 11:32:44 -06:00
Jason Zimdars 128fc22eb1 Make it look like the filter 2024-10-21 16:39:39 -05:00
Jose Farias b0565fbf20 Spike workflows 2024-10-21 15:33:30 -06:00
David Heinemeier Hansson b1f5498914 Encapsulate tagging as a taggable domain method
Tag scope control should not float around in the controller
2024-10-19 20:14:59 -07:00
David Heinemeier Hansson 255435a38f No need for a non-standard factory method for something this simple 2024-10-19 19:53:20 -07:00
David Heinemeier Hansson 1d404830f4 Must touch to bust bubble caches 2024-10-19 17:42:06 -07:00
David Heinemeier Hansson 0bffcb8b86 Actually need to do all work outside of transaction loop
We can be more efficient as just as descriptive with an explaining
variable
2024-10-19 17:08:05 -07:00
David Heinemeier Hansson 942eb9fd64 Extract explaining method
And keep parent method at a consistent level of abstraction
2024-10-19 17:03:37 -07:00
Jose Farias d9d473723b Clean up Bucket::BubbleFilter initializer 2024-10-18 11:15:53 -06:00
Jose Farias 09c003431e Pull out Bucket::BubbleFilter 2024-10-18 11:11:23 -06:00
Jose Farias bd2f4fc476 Fix tag_filters and assignee_filters calls 2024-10-17 23:02:59 -06:00
Jose Farias e7cc426fdc Move bubble filtering to the model 2024-10-17 22:51:02 -06:00
Jose Farias 6dc01479b7 Fix search form 2024-10-17 21:34:48 -06:00
Jose Farias a7a9c46327 Put tag summary first 2024-10-17 17:46:49 -06:00
Jose Farias e754b5bf92 Move all of Bubble's searchable concerns into Searchable 2024-10-17 17:38:33 -06:00
Jose Farias eb68fbe8ff Simplify Bucket::View validations 2024-10-17 17:15:45 -06:00
Jose Farias 8fd28c3809 Remove unnecesary compact_blank 2024-10-16 17:10:48 -06:00